Swfdec - May 2008 - [Bug 15960] New: "Done" and "Error" columns are redundant with each other

http://bugs.freedesktop.org/show_bug.cgi?id=15960

           Summary: "Done" and "Error" columns are redundant
with each other
           Product: swfdec
           Version: 0.6.0
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: trivial
          Priority: medium
         Component: plugin
        AssignedTo: swfdec at lists.freedesktop.org
        ReportedBy: mpt at myrealbox.com
         QAContact: swfdec at lists.freedesktop.org
        Depends on: 15959


swfdec-mozilla 0.6.0-2ubuntu1, Ubuntu 8.04

In the "Properties" window for a Flash object, there is a
"Done" column showing
download progress for each item, and an "Error" column showing whether
the item
had an error.

Issues with these columns:

* When an item is completely downloaded, the progress bar is still present.
Progress bars should disappear within a couple of seconds of reaching 100%.

* The error cell looks like a checkable checkbox, but isn't.

* If an item is successfully downloaded, it didn't have an error; and if it
had
an error, it wasn't successfully downloaded. So the columns can be merged.

Safari's Activity window shows how to present progress, size (instead of
percentage progress), and errors in a single column.
<http://www.myokyawhtun.com/wp-content/uploads/2008/03/safari-activity.jpg>


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960


Matthew Paul Thomas <mpt at myrealbox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|15959                       |
           Severity|trivial                     |minor




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960





--- Comment #1 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-22 13:26:26 PST ---
Created an attachment (id=16697)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16697)
marge done and error column

Attached a patch that implement the suggestion. Should add i'm not able to
find
a flash file that give an error so never excercised that path. The patch should
be applied on top of the other one i posted for 15958 and 15959 to avoid merge
issues.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960





--- Comment #2 from Benjamin Otte <otte at gnome.org>  2008-05-24 03:12:10
PST ---
You seem to be used to languages that do automatic memory management. ;)
The return value of g_format_size_for_display() must be freed.
Also, I'm not sure if using red on errors is a good idea as it might look
odd
on some themes. So we'd better use something theme-agnostic, like bold, if
we
use a special marker at all.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16697|0                           |1
        is obsolete|                            |




--- Comment #3 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-24 04:50:23 PST ---
Created an attachment (id=16712)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16712)
 merge done and error column - try 2

(In reply to comment #2)
> You seem to be used to languages that do automatic memory management. ;)
> The return value of g_format_size_for_display() must be freed.
You are right, fixed.
> Also, I'm not sure if using red on errors is a good idea as it might
look odd
> on some themes. So we'd better use something theme-agnostic, like bold,
if we
> use a special marker at all.
Ok, in case of error i've removed the red color for text. 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16712|0                           |1
        is obsolete|                            |




--- Comment #4 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-24 05:17:59 PST ---
Created an attachment (id=16713)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16713)
merge done and error column - try 3  

Removed a hunk of a previous patch.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960





--- Comment #5 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-24 05:36:37 PST ---
Created an attachment (id=16714)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16714)
distinguish file with unknown size

Use a different string format for files with size unknown as discuessed on irc.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15960


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-06-17 04:39:59 PST ---
This is in git now.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.