Swfdec - May 2008 - [Bug 15958] New: "Save media as" button does nothing by default

http://bugs.freedesktop.org/show_bug.cgi?id=15958

           Summary: "Save media as" button does nothing by default
           Product: swfdec
           Version: 0.6.0
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: minor
          Priority: medium
         Component: plugin
        AssignedTo: swfdec at lists.freedesktop.org
        ReportedBy: mpt at myrealbox.com
         QAContact: swfdec at lists.freedesktop.org


swfdec-mozilla 0.6.0-2ubuntu1, Ubuntu 8.04

1. Go to a Web page containing a Flash object.
2. Right-click on the object and choose "Properties".
3. In the properties window, click "Save media as".

What should happen: A filepicker appears.
What actually happens: Nothing.

I think two things should be changed here:
(a) the first item in the list should be selected by default;
(b) either the "Save media as" button should be insensitive when no
item is
selected, or it should be impossible to not have an item selected.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15958





--- Comment #1 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-21 02:37:25 PST ---
Created an attachment (id=16661)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16661)
select first media url by default

Make sense, attached a patch that implement your suggestion a): the first media
url is selected by default.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15958


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16661|0                           |1
        is obsolete|                            |




--- Comment #2 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-21 08:33:52 PST ---
Created an attachment (id=16662)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16662)
select first media url by default try 2

New revision of the patch with this changes:
Use gtk_tree_path_new_from_indices instead of gtk_tree_path_new_from_string
which looks like more cheap and fix leaking of the path as pointed out by
Company.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15958


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16662|0                           |1
        is obsolete|                            |




--- Comment #3 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-05-22 07:43:20 PST ---
Created an attachment (id=16682)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=16682)
select first media url by default try 3

New revision of the patch:
- set the selection mode so that there is always one element selected
- move the code where more appropriate


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=15958


Benjamin Otte <otte at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Benjamin Otte <otte at gnome.org>  2008-05-24 02:30:06
PST ---
commit d673e1ffe79ac7be521f7b5bc17ea50db408603d
Author: Riccardo Magliocchetti <riccardo at datahost.it>
Date:   Sat May 24 11:28:44 2008 +0200

    select first media url by default (fixes #15958)

    Also set the selection mode so that there is always one element selected


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.