I'm patching oggenc with this fix. If Conrad reports success in his test, I'll go ahead and patch all other implementations I can find. -Ivo
On 2/1/08, Ivo Emanuel Gon?alves <justivo@gmail.com> wrote:> I'm patching oggenc with this fix.If it wasn't clear, my own test there was successful and the resulting file with skeleton works just fine. -Ivo
On 02/02/2008, Ivo Emanuel Gon?alves <justivo@gmail.com> wrote:> I'm patching oggenc with this fix. If Conrad reports success in his > test, I'll go ahead and patch all other implementations I can find.I've merged this patch and fixed the other problems that were reported in the liboggz source tree: http://svn.annodex.net/liboggz/trunk/src/tools/skeleton.c It includes the fixes for handling skeleton on big-endian hosts. I think it would be a good idea to use this version everywhere else that that skeleton.c file is used, ie. in vorbisfile, ffmpeg2theora, oggenc, speexenc/speexdec as listed at: http://trac.annodex.net/wiki/OggSkeleton As far as I understand, that file is simply duplicated in each source tree. It would be great if you could update it in each. cheers, Conrad.
Jean-Marc, you might like to simply copy the skeleton.c from liboggz, as described below. cheers, Conrad. ---------- Forwarded message ---------- From: Conrad Parker <conrad@metadecks.org> Date: 2 Feb 2008 16:41 Subject: Re: [ogg-dev] [PATCH] skeleton.c To: Ivo Emanuel Gon?alves <justivo@gmail.com> Cc: "ogg.k.ogg.k@googlemail.com" <ogg.k.ogg.k@googlemail.com>, ogg-dev@xiph.org On 02/02/2008, Ivo Emanuel Gon?alves <justivo@gmail.com> wrote:> I'm patching oggenc with this fix. If Conrad reports success in his > test, I'll go ahead and patch all other implementations I can find.I've merged this patch and fixed the other problems that were reported in the liboggz source tree: http://svn.annodex.net/liboggz/trunk/src/tools/skeleton.c It includes the fixes for handling skeleton on big-endian hosts. I think it would be a good idea to use this version everywhere else that that skeleton.c file is used, ie. in vorbisfile, ffmpeg2theora, oggenc, speexenc/speexdec as listed at: http://trac.annodex.net/wiki/OggSkeleton As far as I understand, that file is simply duplicated in each source tree. It would be great if you could update it in each. cheers, Conrad.
On 2/2/08, Conrad Parker <conrad@metadecks.org> wrote:> As far as I understand, that file is simply duplicated in each source > tree. It would be great if you could update it in each.I don't think it is that easy. I have made a mere diff and see so many differences I'm not sure we can just blindly replace every skeleton.c with the one used in liboggz. Diff attached. -Ivo -------------- next part -------------- A non-text attachment was scrubbed... Name: diff Type: application/octet-stream Size: 9477 bytes Desc: not available Url : http://lists.xiph.org/pipermail/ogg-dev/attachments/20080202/658a037e/diff-0001.obj