lvqcl
2016-Feb-02 16:53 UTC
[flac-dev] [PATCH] use more windows API in src/share/utf8/utf8.c
src/share/utf8/utf8.c mentions that "On NT-based windows systems, we could use WideCharToMultiByte()/MultiByteToWideChar(CP_UTF8), but MS doesn't actually have a consistent API across win32". flac/metaflac don't support Win98 since ver. 1.3.0, so it's possible to use system routines to convert to/from UTF-8. I removed all fprintf(stderr...) code from the win32 code because non-windows code in utf8.c doesn't print anything in such cases and simply returns an error. -------------- next part -------------- A non-text attachment was scrubbed... Name: utf8_new.patch Type: application/octet-stream Size: 7751 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20160202/c8409ffc/attachment.obj
Erik de Castro Lopo
2016-Feb-08 11:05 UTC
[flac-dev] [PATCH] use more windows API in src/share/utf8/utf8.c
lvqcl wrote:> src/share/utf8/utf8.c mentions that "On NT-based windows systems, > we could use WideCharToMultiByte()/MultiByteToWideChar(CP_UTF8), > but MS doesn't actually have a consistent API across win32". > > flac/metaflac don't support Win98 since ver. 1.3.0, so it's > possible to use system routines to convert to/from UTF-8. > > > I removed all fprintf(stderr...) code from the win32 code because > non-windows code in utf8.c doesn't print anything in such cases and > simply returns an error.Applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/