similar to: [PATCH] for potential memory leaks

Erik de Castro Lopo wrote: > Working on a fix for this and re-visiting some of this realloc() > stuff. I noticed that your patch removes the call to vorbiscomment_entry_array_delete_() in FLAC__metadata_object_vorbiscomment_resize_comments() function, and I think that it reintroduces one place of a potential memory leak: 'object->data.vorbis_comment.comments' is a pointer to an

--- include/share/alloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/share/alloc.h b/include/share/alloc.h index 914de9ba..63878db0 100644 --- a/include/share/alloc.h +++ b/include/share/alloc.h @@ -168,7 +168,7 @@ static inline void *safe_realloc_add_2op_(void *ptr, size_t size1, size_t size2) free(ptr); return 0; } - return realloc(ptr, size2); + return

I passed a valid FILE* (from fopen() with "rb") and the address of an OggVorbis_File struct, but an access violation occured when ov_open is called. I have enabled the Multithreaded, but it still doesn't fix the problem. I look at the vorbis_comment.exe source and I see vcedit_open() function and other vcedit_*() functions everywhere. I am assuming that there is known issue with VC

I am using the standard Xiph.org FLAC encoder, but I couldn't find any option to update the meta-data mid-stream. Also the FLAC spec says, that it defines VORBIS_COMMENT as the only way to transmit meta-data information. This is the only officially supported tagging mechanism in FLAC. There may be only one VORBIS_COMMENT block in a stream. As such, when you state, that meta data is the domain

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus

This patch offers interface to get the library name which software uses. Function: char *vorbis_version_string(void); PATCH (for libvorbis-1.2.1RC2): diff -crN libvorbis-1.2.1RC2/include/vorbis/codec.h libvorbis-1.2.1RC2_NI/include/vorbis/codec.h *** libvorbis-1.2.1RC2/include/vorbis/codec.h Mon Aug 25 05:57:44 2008 --- libvorbis-1.2.1RC2_NI/include/vorbis/codec.h Sat Sep 13 05:00:22 2008

It seems, that with FLAC and OPUS streams (not individual files) the song title (meta data) updates do not work. Also the ICEcast admin web interface isn’t working for FLAC and OPUS; while it is working for MP3, AAC as well as OGG streams. I.e. when sending a continuous FLAC or OPUS stream to an ICEcast server, it seems impossible to update the meta data mid-stream (like it works for MP3, AAC

I have just released a source distribution which is the candidate for the 1.0.3 release. At this time I would ask anyone who is willing to help test it to do the following: 1. download the tarball and unzip it: http://prdownloads.sourceforge.net/flac/flac-1.0.3_beta-src.tar.gz?download 2. do ./configure && make && make check This will build all code and run all the tests.

Well, I'm quite frankly stumped. I'm writing a program that recurses into directories and reads (among others) FLAC files and should be able to read the vorbis comments ARTIST and TITLE from the file. A while back, I was popen()ing to metaflac, because I didn't want to mess with libFLAC. But now, it's the weekend, so I can mess around with this. Here's the code in question:

Hi, This mozilla bug report is a crash triggered by a Vorbis file with corrupt headers: https://bugzilla.mozilla.org/show_bug.cgi?id=481601 The patch to fix the crash adds a new vorbis_dsp_init() function to libvorbis, and calls that from fs_vorbis_init() in libfishsound: https://bug481601.bugzilla.mozilla.org/attachment.cgi?id=366150 The public function it adds is: void

So, let's provide some information then :-) ---------------------------------------------------------------------------------------------- soa2ii at thor /mnt/files/music/Slime/Alle gegen Alle $ flac -aF 02\ St?rtebecker.flac flac 1.2.1, Copyright (C) 2000,2001,2002,2003,2004,2005,2006,2007 Josh Coalson flac comes with ABSOLUTELY NO WARRANTY. This is free software, and you are welcome

Correction, the flac command-line does create a 40-byte Vorbis comment by default. I just never noticed it before. I’ve been using —no-padding all these years for minimal file sizes without realizing that I could save another 40 bytes. Anyway, since metaflac can remove the Vorbis comment using the standard library, then you should be able to create a solution without modifying libFLAC. Brian

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

Function FLAC__metadata_object_delete_data() in libFLAC/metadata_object.c: it frees a pointer, then assigns 0 to it. But it doesn't do it for data.vorbis_comment.comments and object->data.cue_sheet.tracks. The patch adds assignment to zero for them. -------------- next part -------------- A non-text attachment was scrubbed... Name: free_and_null.patch Type: application/octet-stream Size:

This is *nothing* major, just a minor tweak that makes FreeStream's rebroadcast system work smoother. It is a patch for icecast CVS( checked out at 20040505 20:00UTC), That simply adds to format_vorbis.c the ability to read more vorbis_comment information (namely; comment, info and length) Hopefully this can be useful. -- Justin Zeigler, a.k.a. Barbicane (jzeigler@freestream.net)

Hi list, It seems that when playing several OggVorbis files under xmms, there is a memory leak. It's a rather annoying problem because when you have a playlist of 100+ files, xmms will at the end eat something like 100M or more.. Such a memory leak have been reported inside xmms-1.2.2 code and I could see it playing Ogg files and mp3 files ; upgrading to 1.2.3 solves the problem with mp3

I change a lot of my CD to Ogg to be able to listen them easily from my computer (I use foobar, I was used to WMP but it does not support library for Ogg files and plug-ins I found for this where poor) without the need for frequent CD changing. I like my music to be richly tagged. But with classical music CD it is a real pain to tag those files. Typical problems involve: - single CD

Hello, I'm currently doing a little music player using libflac and libao. What I've currently done works as it should, but I have a problem where only one metadata block is detected, even if there are more (it doesn't have the last attribute set to true). This is using flac 1.3.2 on Gentoo amd64. The main code file is attached, it mainly follows the examples given with the libflac

Ok, so I finally got the id3/mp3 end of things worked out for the next release of QTagger and I'm back to implementing tag reading for Ogg Vorbis. I've got some code that will read tags, but I haven't been able to figure out how to write them. Here's the code that I'm using. It's a fine C/C++ mix. The code will eventually be in a C++ app, so I don't mind

Josh Coalson <xflac@yahoo.com> wrote: > --- Scott F <graue@oceanbase.org> wrote: > > > If I use flac to encode with the --replay-gain > > option, I get a warning about the --no-padding > > option... > > > > "NOTE: --replay-gain may leave a small PADDING block even with > > --no-padding" > > > > ...even though I'm