similar to: PATCH: OS SSE support detection, version 2

Erik de Castro Lopo wrote: >> part 1: fixes >> >> part 2: new code >> >> Any comments? > > Applied cpu_part2.patch. Thanks! Thanks. I hope that this code will help to avoid "bug" reports such as http://sourceforge.net/p/flac/bugs/409/ (it seems that the author of this report compiled FLAC without --enable-sse option). OTOH, SSE support is

Erik de Castro Lopo wrote: >> About part 1:does it have any problems? I can split it into several patches >> (1 fix = 1 patch) or explain the changes in it in detail. > > I didn't apply patch1 because I mis-read your comment here: > > http://lists.xiph.org/pipermail/flac-dev/2014-March/004582.html > > So, for the patches in this email: > >

op 11-03-14 15:57, Olivier Tristan schreef: > I may say something stupid but is this helpful ? > http://stackoverflow.com/questions/6121792/how-to-check-if-a-cpu-supports-the-sse3-instruction-set That question on stackoverflow is about CPU support, the patch you replied to was about OS support. Because of the registers used (which must be saved and restored on a context switch), the

Olivier Tristan <o.tristan at uvi.net> ?????(?) ? ????? ?????? Fri, 21 Mar 2014 22:41:00 +0400: > Check with -mfpmath=387 to be sure that x87 FPU code is used and not some > SSE optim made by GCC I added "XIPH_ADD_CFLAGS([-mfpmath=387])" into configure.ac Still the result is different from SSE version. --------------- MSVS adds two instructions to the generated code after

libFLAC for Windows compiled with GCC/MinGW can't detect SSE OS support: it can't use GCC+Linux detection code and can't use MSVC+Win32 code that uses SEH (__try/__except). So it doesn't use any SSE/SSE2/etc routines. One way to fix it is to call configure script with --enable-sse (flac will probably crash on Win95/WinNT4 but who cares). Another way is to add a new code just for

1. A program can use SSE instructions only if both CPU and OS support SSE. Currently libFLAC tests both CPU and OS for this support, but is it really necessary? Maybe CPU check is enough? Operating systems that don't support SSE (Win95, WinNT 4.0, Linux kernel 2.2 (iirc), ...) are really outdated now. Removing OS check will greatly simplify src/libFLAC/cpu.c. 2. "configure" build

On 12/6/16, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > MauritsVB wrote: > >> I noticed you’ve started compiling the changelog for 1.3.2. > > I had sort of hoped I'd finished :). Seems I was wrong! > >> I have kept track of some of the bigger changes since 1.3.1 although >> admittedly haven’t been on top of it this year. Perhaps some of these

This patch tries to simplify the code that tries to detect whether OS supports SSE instructions. a) Linux: "old" vs "new" sigaction OBSOLETE_SIGCONTEXT_FLAVOR was disabled in Mar 2007 in commit <http://git.xiph.org/?p=flac.git;a=commit;h=1ca3a445f832be5e8a99364fb38d9e2ea9a3a772> According to <http://unixhelp.ed.ac.uk/CGI/man-cgi?sigaction>: "Support for

It's not possible to use ia32/*.nasm code in 64-bit compiles. There's still no 64-bit asm code in FLAC. I'm not familiar with asm too, so I wrote SSE-accelerated code using intrinsics. This code uses two new preprocessor macros: FLAC__CPU_X86_64 (analogous to FLAC__CPU_IA32) and FLAC__HAS_X86INTRIN (analogous to FLAC__HAS_NASM) Patch for cpu.c/cpu.h adds CPU features (sse3, ssse3)

On 28-04-13 13:23, LRN wrote: > On 28.04.2013 13:38, Erik de Castro Lopo wrote: >> I have tagged 1.3.0pre4 in git and provided a tarball here: >> >> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre4.tar.xz >> >> I have built and tested the git tree on: >> >> linux-x86_64 openbsd5-i386 freebsd5-i386 > i686-w64-mingw32 - builds correctly,

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > The biggest of these tweaks weas to disable the intrinsics version > fero FLAC__CPU_IA32 because I couldn't get this to compile on > i386-linux (and we have the nasm versions). Still open to re-enabling > this if someone can get it to work. I know you're a skilled programmer, but... maybe you forgot to add -msse

Erik de Castro Lopo wrote: > lvqcl.mail wrote: >> now. Removing OS check will greatly simplify src/libFLAC/cpu.c. > > That makes sense. Should I post a patch that removes OS check and keeps only CPU check? >> 2. >> "configure" build system adds -msse2 option by default. It means that >> x86 (32-bit) library won't work on older, non-SSE2

For anyone wondering, here's a PDF comparing encoding speed, decoding speed and compression between FLAC 1.2.1, 1.3.0 and 1.3.1pre1. Compiles on a Intel Core 2 Duo T9600 (SSE up to and including 4.1, no AVX), Kubuntu 14.04.1, GCC 4.9.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: long set of samples-1.3.1pre1.pdf Type: application/pdf Size: 16795

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: >> -msse for SSE code, -msse2 for SSE2 code, -msse4.1 for SSE4.1 code > > Yes, that was it. Brain fart. These flags were not needed on x86_64. > > Erik But now all C code is compiled with -msse2 and it won't work on older CPUs. Isn't it better to compile only necessary files with this flag?

OS SSE support is now mandatory, so the description of --disable-sse option isn't correct now (actually, it wasn't fully correct even before this). *Currently all it does is disables -msse2 flag* The relevant parts of configure.ac: AC_ARG_ENABLE(sse, AC_HELP_STRING([--disable-sse], [Disable SSE if the OS does not support SSE instructions]), [case "${enableval}" in yes)

This patch removes check for OS SSE support. (I assume that all OSes that are usable today support SSE, so this complicated check in cpu.c is not needed). -------------- next part -------------- A non-text attachment was scrubbed... Name: remove_OS_SSE_check.patch Type: application/octet-stream Size: 8206 bytes Desc: not available URL:

Currently -msse2 option is added to CFLAGS even when FLAC was configured with --disable-sse option. This patch fixes this (if I corrrectly understood the syntax of configure.ac). -------------- next part -------------- A non-text attachment was scrubbed... Name: sse2_config.patch Type: application/octet-stream Size: 378 bytes Desc: not available Url :

Hi all, I had some time to spare so I made a comparison of current git versus the FLAC 1.3.0 release considering encoding and decoding speed. This was done with GCC 4.7.3 for AMD64 linux. There's a very nice speedup visible. Keep up the good work! -------------- next part -------------- A non-text attachment was scrubbed... Name: FLAC 1.3.0 versus git a6a4b6f.pdf Type: application/x-pdf

On 26-05-13 14:20, Martijn van Beurden wrote: > On 26-05-13 11:33, Erik de Castro Lopo wrote: >> Hi all, >> >> In my latest commit I have updated all version strings and copyright >> dates. > > Here are two patches for the website, updating the copyright as well > and copying the changelog. I would like to propose copying the > contents of flac-website.git

Hi all, I thought it was a good idea to get an overview of the developments since the release of 1.3.0, so here are a few graphs. The first was compiled with GCC 4.8, the second was compiled with MSVC 2013. Both were tested on a Kubuntu 14.04 machine, with an Intel Core 2 Duo T9600 (SSE support up to "version" 4.1), the MSVC compiles were run through wine, as I don't think