On 26-05-13 14:20, Martijn van Beurden wrote:> On 26-05-13 11:33, Erik de Castro Lopo wrote: >> Hi all, >> >> In my latest commit I have updated all version strings and copyright >> dates. > > Here are two patches for the website, updating the copyright as well > and copying the changelog. I would like to propose copying the > contents of flac-website.git (after patching) to doc/html in flac.git, > but because of the size of the patch (because of the size of the > images in the comparison) I think it's better you do that yourself > instead of me sending a patch.I just sent this message, but it seems it has been placed in the moderation queue. Trying again with patched linked instead of attached: www.icer.nl/misc_stuff/copyright-and-changelog-website-patch.zip
On Sun, May 26, 2013 at 5:31 AM, Martijn van Beurden <mvanb1 at gmail.com> wrote:> On 26-05-13 14:20, Martijn van Beurden wrote: >> On 26-05-13 11:33, Erik de Castro Lopo wrote: >>> Hi all, >>> >>> In my latest commit I have updated all version strings and copyright >>> dates. >> >> Here are two patches for the website, updating the copyright as well >> and copying the changelog. I would like to propose copying the >> contents of flac-website.git (after patching) to doc/html in flac.git, >> but because of the size of the patch (because of the size of the >> images in the comparison) I think it's better you do that yourself >> instead of me sending a patch. > > I just sent this message, but it seems it has been placed in the > moderation queue. Trying again with patched linked instead of attached: > > www.icer.nl/misc_stuff/copyright-and-changelog-website-patch.zipAlso I have a patch fixing bootstrap on Mac OS X that may also be on moderation queue. It will be great it can be reviewed and given a green light.> _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev
On Sun, May 26, 2013 at 5:54 AM, Xiyue Deng <manphiz at gmail.com> wrote:> On Sun, May 26, 2013 at 5:41 AM, Martijn van Beurden <mvanb1 at gmail.com> wrote: >> On 26-05-13 14:34, Xiyue Deng wrote: >>> >>> Also I have a patch fixing bootstrap on Mac OS X that may also be on >>> moderation queue. It will be great it can be reviewed and given a green >>> light. >> >> >> I'm not sure who has access to the queue, uploading it somewhere and sending >> a link might be faster :) > > I've uploaded the patch to github, which can be found at [1]. Here are > some explanations. > > Currently flac's autogen.sh will check for gettext command and relies > on gettext and iconv installation for various m4 scripts. However on > Mac OS X, the gettext/iconv utilities are partially installed on Mac > OS X: it doesn't have gettext command, but the libraries and msg* are > provided, also the m4 scripts are missing. So I have crafted a patch > that avoids checking for gettext command on Mac OS X and imported the > required m4 scripts so it can be bootstrapped and built without custom > gettext and iconv installations. > > Please note that only autogen.sh is modified, and other m4 files are > added from gettext/iconv installations. > > [1] https://raw.github.com/manphiz/patches/master/patch-flac-macosx.patchForgot to send to mailling list. Resend as per request by Martijn.
Xiyue Deng wrote:> On Sun, May 26, 2013 at 5:54 AM, Xiyue Deng <manphiz at gmail.com> wrote: > > On Sun, May 26, 2013 at 5:41 AM, Martijn van Beurden <mvanb1 at gmail.com> wrote: > >> On 26-05-13 14:34, Xiyue Deng wrote: > >>> > >>> Also I have a patch fixing bootstrap on Mac OS X that may also be on > >>> moderation queue. It will be great it can be reviewed and given a green > >>> light. > >> > >> > >> I'm not sure who has access to the queue, uploading it somewhere and sending > >> a link might be faster :) > > > > I've uploaded the patch to github, which can be found at [1]. Here are > > some explanations. > > > > Currently flac's autogen.sh will check for gettext command and relies > > on gettext and iconv installation for various m4 scripts. However on > > Mac OS X, the gettext/iconv utilities are partially installed on Mac > > OS X: it doesn't have gettext command, but the libraries and msg* are > > provided, also the m4 scripts are missing. So I have crafted a patch > > that avoids checking for gettext command on Mac OS X and imported the > > required m4 scripts so it can be bootstrapped and built without custom > > gettext and iconv installations. > > > > Please note that only autogen.sh is modified, and other m4 files are > > added from gettext/iconv installations. > > > > [1] https://raw.github.com/manphiz/patches/master/patch-flac-macosx.patch > > Forgot to send to mailling list. Resend as per request by Martijn.Applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Martijn van Beurden wrote:> On 26-05-13 14:20, Martijn van Beurden wrote: > > On 26-05-13 11:33, Erik de Castro Lopo wrote: > >> Hi all, > >> > >> In my latest commit I have updated all version strings and copyright > >> dates. > > > > Here are two patches for the website, updating the copyright as well > > and copying the changelog. I would like to propose copying the > > contents of flac-website.git (after patching) to doc/html in flac.git, > > but because of the size of the patch (because of the size of the > > images in the comparison) I think it's better you do that yourself > > instead of me sending a patch. > > I just sent this message, but it seems it has been placed in the > moderation queue. Trying again with patched linked instead of attached: > > www.icer.nl/misc_stuff/copyright-and-changelog-website-patch.zipApplied Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Martijn van Beurden wrote:>> I would like to propose copying the >> contents of flac-website.git (after patching) to doc/html in flac.gitI don't think this should be done. The website in flac-website.git and the one in flac.git/docs/html have diverged and will require some kind of merge effort. Actually, I'd prefer stripping down flac.git/docs/html to the bare minimum, something like changelog and licence plus links to the Doxygen documentation and to the website. Otherwise it will (continue to) be unmanageable. Ulrich
Ulrich Klauer wrote:> Martijn van Beurden wrote: > > >> I would like to propose copying the > >> contents of flac-website.git (after patching) to doc/html in flac.git > > I don't think this should be done. The website in flac-website.git and > the one in flac.git/docs/html have diverged and will require some kind > of merge effort. > > Actually, I'd prefer stripping down flac.git/docs/html to the bare > minimum, something like changelog and licence plus links to the > Doxygen documentation and to the website. Otherwise it will (continue > to) be unmanageable.+1 for doing this after the release. -1000 for doing it before :-) Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/