similar to: [PATCH] Add missing functions to VorbisComment class + a few other things

--- On Tue, 5/8/12, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Honestly, I really doubt this is a bug in valgrind :-). How > were you testing > this? Well, I've read that there have been bugs in valgrind, were SSE optimized versions of strlen() do guaranteed safe overreads of memory, but valgrind wasn't aware the overreads were safe. Anyway, it seems easy to

Attached is a patch that adds 5 missing FLAC__metadata_object_vorbiscomment_* functions to the VorbisComment class. In my previous message I stated 8 functions were missing, but on closer inspection, 3 of those belong in the VorbisComment::Entry class, and 2 of them already have equivalent functions in there. The last one (FLAC__metadata_object_vorbiscomment_entry_matches()) does not, but I have

Patch v2, now handles more malformed cases. Original patch was for a file for which I had a sample from a user but this allows handling some manually broken test cases. On 25.9.2014 21:53, Janne Hyv?rinen wrote: > Here's a patch to allow flac and metaflac handle files with malformed > vorbiscomment metadata block. > > > _______________________________________________ >

Erik, thanks for the swift answer. Your right, I haven't seen any issues yet. But it a thought stroke me when implementing edit capabilities of FLAC vorbis comments. I've already implemented reading vorbis comments from FLAC files in 64-bit and it works without any issues. This now leave me a bit confused, since it should have issues(!). Using the MS 64-bit compiler on Windows 7/2008R2

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus

Well, I have been away a couple of days, so I don't know if I'm in time, but I reported a memory leak and submitted a patch a couple of months ago. It would be nice if it can make it in. I first reported the leak here: http://lists.xiph.org/pipermail/flac-dev/2011-August/003002.html And the patch is here:

> Err, no it wouldn't. In fact this example you gave only confuses > the matter. ? What do you mean? typedef struct { FLAC__uint32 length; FLAC__byte *entry; } FLAC__StreamMetadata_VorbisComment_Entry; Can you confirm that the entry member is a pointer and not a byte array? In that case: What happens if the compiler expands the size of the structure twice (8=>16 bytes)? I

On 26.9.2014 15:21, Erik de Castro Lopo wrote: > Janne Hyv?rinen wrote: > >> Patch v2, now handles more malformed cases. Original patch was for a >> file for which I had a sample from a user but this allows handling some >> manually broken test cases. > > Err, I'm getting warning messages on that patch: > > CC metadata_iterators.lo >

The attached patch adds the missing FLAC__metadata_object_seektable_*() functions from FLAC's metadata object methods (FLAC/metadata.h) to FLAC++'s SeekTable class. Of the 11 functions in the C API, only 4 are currently in the C++ API, this patch adds the missing 7. If this patch is ok, VorbisComment will be next. A quick look tells me only 5 out of 13

Well, I sent this earlier this week, but I guess it's stuck in the spam filter, so I'll send it again split up in several parts. First the full source, if this one arrives I'll reply with the patch. Ok, so I ended up creating 2 versions of this. The first one is what I mentioned earlier, pretty much a line-for-line translation of the original example. The c++-style casts made the

> From: Cristian Rodr?guez <crrodriguez at opensuse.org> > Sent: Sunday, May 6, 2012 8:24 AM > > El 05/05/12 02:23, Bastiaan Timmer escribi?: >> The attached patch adds the missing FLAC__metadata_object_seektable_*() >> functions from FLAC's metadata object methods (FLAC/metadata.h) to >> FLAC++'s SeekTable class. Of the 11 functions in the C API,

Hi! I think this patch adds the last of the libFLAC metadata functions to the correct classes in libFLAC++. This is 4 CueSheet member function and 1 Picture function. If I haven't looked properly and more functions are still missing, let me know. Next I would like to maybe add a few convenience functions. For instance, a padding block can really only be created and given a size, but this

Building with MinGW-w64 GCC 5.3.0 via Makefile.lite, I get the following warnings: bitwriter.c: In function 'FLAC__bitwriter_write_utf8_uint64': bitwriter.c:324:19: warning: inlining failed in call to 'FLAC__bitwriter_write_raw_uint32.constprop': --param large-function-growth limit reached [-Winline] inline FLAC__bool FLAC__bitwriter_write_raw_uint32(FLAC__BitWriter *bw,

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

This patch adds support for other compilers and systems including MSVC, Intel C compiler etc.. --- src/libFLAC/bitmath.c | 48 ------------- src/libFLAC/bitreader.c | 54 ++------------- src/libFLAC/include/private/bitmath.h | 120 ++++++++++++++++++++++++++++++--- 3 files changed, 116 insertions(+), 106 deletions(-) diff --git a/src/libFLAC/bitmath.c

Bastiaan Timmer wrote: ... > In a > previous message I mentioned writing some more convenience functions, but on > closer inspection they would either be inefficient or very difficult > to implement. Could you briefly list these, in case somebody else wants to have a go. Many thanks, Martin -- Martin J Leese E-mail: martin.leese stanfordalumni.org Web:

1) FLAC supports only MSVS 2005 and newer, so (_MSC_VER >= 1400) is always true and can be removed. 2) The argument for FLAC__clz_uint32() is of FLAC__uint32 type, so FLAC__clz_soft_uint32() should have the same argument type. 3) The patch removes unnecessary parentheses around 'word' variable. 4) It also replaces "sizeof(FLAC__uint32) * CHAR_BIT - 1 -

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Well first of all, none of them apply :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and

Hi! Attached is a tiny patch adding a convenience function to create a Metadata::Padding object with a certain size in one statement. In a previous message I mentioned writing some more convenience functions, but on closer inspection they would either be inefficient or very difficult to implement. I have also nearly finished converting the cpp file-encode example to use the C++ api, and will

Erik de Castro Lopo wrote: > > http://wootangent.net/~lsd/blah/snippet6.wav > > Great, thanks! Confirmed the problem here. Will look at it ASAP. Same problem with flac 1.2.1. Interesting! Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/