flac dev - Jun 2012 - [PATCH] Adds last functions from C metadata api to C++ metadata api

Hi! I think this patch adds the last of the libFLAC metadata functions to the
correct classes in libFLAC++. This is 4 CueSheet member function and 1 Picture
function. If I haven't looked properly and more functions are still missing,
let me know.

Next I would like to maybe add a few convenience functions. For instance, a
padding block can really only be created and given a size, but this still takes
2 statements. I think it would make sense to just have a constructor which takes
a size argument. But let me know if this sort of thing is not wanted. Also, I
think eventually the cpp example should be rewritten to make use of the C++
library (atm only the encoder class is used, all the metadata is done as in the
C example). But again, just let me know if this is not deemed necessary or if
some other things have higher priority (but realize I have no skills in the
actual encoding/decoding parts of FLAC).

Bas Timmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flacpp.patch
Type: text/x-patch
Size: 4477 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20120621/be2090d9/attachment-0001.bin

Bastiaan Timmer wrote:
> Hi! I think this patch adds the last of the libFLAC metadata
> functions to the correct classes in libFLAC++.
Thanks Bastiaan. Applied.
> Next I would like to maybe add a few convenience functions.
I have no major problem with that, but I am not a user of the C++
API.
> Also, I think eventually the cpp example should be rewritten to
> make use of the C++ library.
That definitely would be useful. +1.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/