flac dev - Sep 2012 - Patch for Metadata::Padding

Hi! Attached is a tiny patch adding a convenience function to create a
Metadata::Padding object with a certain size in one statement. In a

previous message I mentioned writing some more convenience functions, but on
closer inspection they would either be inefficient or very difficult

to implement.


I have also nearly finished converting the cpp file-encode example to use the
C++ api, and will upload that later today or tomorrow. I have

also changed the non-FLAC related code to be more C++ like (C++ streams for IO,
no c style casts, no global vars), but let me know if

this is not wanted. Other than that, the new example is just a line-for-line
translation into c++. Also, the patch will probably be big (maybe

bigger than the raw file), and hard to read. Should I send a patch or just the
the file?

thanks,
Bas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metadata_padding.patch
Type: application/octet-stream
Size: 1177 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20120910/34184734/attachment.obj

Bastiaan Timmer wrote:
> Hi! Attached is a tiny patch adding a convenience function to create
> a Metadata::Padding object with a certain size in one statement. In a 
Applied. Thanks.
> I have also nearly finished converting the cpp file-encode example to
> use the C++ api, and will upload that later today or tomorrow. I have 
> also changed the non-FLAC related code to be more C++ like (C++ streams
> for IO, no c style casts, no global vars), but let me know if  
> this is not wanted.
Yes, thats a good idea.
> Other than that, the new example is just a line-for-line translation into
> c++. Also, the patch will probably be big (maybe bigger than the raw file),
> and hard to read. Should I send a patch or just the the file?
Can you send both the patch and the raw file? Then I can review both.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/