similar to: [PATCH] Support 56kHz to 19.2kHz gain analysis (Patch v4)

Copy additional filter values from Foobar2000 as found in <http://code.google.com/p/sirens2/source/browse/trunk/libwavpack-4.32.psp/wvgain.c?r=32> to allow metaflac to perform gain analysis on high sample rate audio. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120107/018c821b/attachment-0001.htm

The test is rather simple, and only compares the computed output values for a 1kHz signal at the known filter table sampling frequencies with previously obained golden values. As such, the test only verifies that the performance of the replay gain analyser has not changed. A better test would be to compare the computed value with an independently obtain theorectical value. This is possible by

Sorry about the duplicate posts from Earl Chew. He's resent because the first v3 patch got caught in the moderation queue, and I didn't notice when I released the messages. Not his fault. :-) -r

On 12 January 2012 16:07, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > However, it looks like I'm changing jobs soon and should have two > weeks free between finishing one and starting the other. Good thing you've got time off work so you can get work done! Shall I harass you about your patch queue at LCA? -r

Erik, I suspect /bin/sh being dash is what is causing the problem. I will rework the syntax. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 11, 2012 10:59:50 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote:

Erik, I'm using bash.? Before I alter the syntax, what shell are you using ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 11, 2012 3:16:11 AM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote: > There is

Hi all, In the last couple of months, there have been two proposed patches for the regain play analysis code. The first by Nathan Rennie-Waldock: http://lists.xiph.org/pipermail/flac-dev/2011-December/003070.html simply adds some more higher sample rates. The second by Earl Chew: http://lists.xiph.org/pipermail/flac-dev/2012-January/003067.html is more comprehensive. Neither of the

Erik ? ? Testing FLAC file with unknown metadata... OK ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then' ? ? ./test_metaflac.sh: line 450: `? then' Do both /bin/bash and /bin/dash give exactly the same error message ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew

Erik, I cannot reproduce the problem you see with either dash(1) or bash(1). > test case62: --import-picture-from... OK > Testing FLAC file with unknown metadata... OK > Testing FLAC replaygain 8000 (8000 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 12000 (12000 x 1) ... OK >

Josh, Sure. I can try. Would you give me a more detailed description of the requirement ? What exactly does "general MM:SS handling" mean ? Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: Earl Chew <earl_chew at yahoo.com>; "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Tuesday, May 1, 2012 8:25:34 PM Subject: Re:

Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either

Erik, I'll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl Chew wrote: > When reading the INDEX

David Robinson kindly provided me the filter values for 28 kHz sampling rate and I have inserted the filter values into the gain analysis table. Following the previous patch: http://lists.xiph.org/pipermail/flac-dev/2012-January/003067.html extend the supported sample rates to cover all rates supported in Foobar2000: 192000 = 4 x 48000 176400 = 4 x 44100 144000 = 4 x 36000 128000 = 4 x 32000

2007/4/1, Ivo Emanuel Gon?alves <justivo@gmail.com>: > > Those are Replay Gain elements. Please check on Wikipedia or > Hydrogenaudio for more information on RG. In short, they are values > to normalize in a lossless way the audio volume. Hi, But how can this be possibly lossless? You change the volume of the audio tracks, so isn't this lossy or does the actual volume

On Sun, Jun 24, 2001 at 01:51:05AM -0700, Dave Hayes wrote: > How are people doing gain control, out of curiosity? > > I know boxes exist (anyone have names and mfrs?) that ride the gain > for big radio stations, ensuring that there is no distortion and > raising the volume of songs recorded at a lower volume. I'd probably > buy one if I knew what to buy. This is a bit

When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. -------------- next part -------------- An HTML attachment was scrubbed... URL:

Erik, My working view has this as the last commit: commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 Author: David Schleef <ds at schleef.org> Date:?? Thu Aug 25 18:40:29 2011 -0700 ??? Fix md5 structure clearing in previous commit Using this, test_metaflac.sh runs cleanly with my cuesheet.c change. I set up another view using HEAD at git.xiph.org, and in this other view

Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate. Anyway, could you do another patch that updates to general MM:SS handling? >________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: Josh Coalson <xflac at yahoo.com>; "flac-dev at xiph.org" <flac-dev

Earl Chew wrote: > That being said, I think my patch leaves us better off than before ! I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

How are people doing gain control, out of curiosity? I know boxes exist (anyone have names and mfrs?) that ride the gain for big radio stations, ensuring that there is no distortion and raising the volume of songs recorded at a lower volume. I'd probably buy one if I knew what to buy. ------ Dave Hayes - Consultant - Altadena CA, USA - dave@jetcafe.org Now Playing at: