similar to: [PATCH] appliance: exclude /usr/lib/firmware

Brings the size of the appliance down to 95 MB [xz-compressed], which is the same as for libguestfs 1.28. --- appliance/excludefiles.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in index d3c66cc..574c828 100644 --- a/appliance/excludefiles.in +++ b/appliance/excludefiles.in @@ -22,6 +22,11 @@ dnl The right kernel modules are added

On Thursday 23 July 2015 15:10:41 Richard W.M. Jones wrote: > Brings the size of the appliance down to 95 MB [xz-compressed], which > is the same as for libguestfs 1.28. > --- > appliance/excludefiles.in | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in > index d3c66cc..a63eca9 100644 > ---

I also sorted the list. Between libguestfs 1.28 and 1.30, the appliance grew from 95MB to 213MB. Using guestmount and filelight (see link below) I could see that the main contributor was these two directories, which should not be necessary. With this change, the size goes down to 119MB. See also: https://rwmj.wordpress.com/2015/07/23/why-has-the-libguestfs-appliance-grown-by-118-mb/ ---

It normally makes no difference to the final size of the appliance, because 'supermin --build' will copy back the host kernel modules. --- appliance/excludefiles.in | 1 + 1 file changed, 1 insertion(+) diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in index 574c828..181b182 100644 --- a/appliance/excludefiles.in +++ b/appliance/excludefiles.in @@ -21,6 +21,7 @@ dnl Of

--- appliance/excludefiles.in | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in index 9a48db7..c53a913 100644 --- a/appliance/excludefiles.in +++ b/appliance/excludefiles.in @@ -32,12 +32,7 @@ dnl The right kernel modules are added back by supermin. -/usr/share/i18n/* -/usr/share/pkgconfig/* --/var/log/*.log*

Since v1: - Don't remove the whole of /var/log - Cleanups and fixes to appliance/Makefile.am

To allow easier downstream tweaks to the virt-rescue welcome message, just output the content of the /etc/issue file in the appliance. Thus, a new extras.tar.gz file appeared in supermin.d containing the etc/issue file and future tweaks like this one. --- appliance/Makefile.am | 11 +++++++++++ appliance/init | 11 ++--------- appliance/issue | 9 +++++++++ 3 files changed, 22

I had tried this approach, to add /etc/dhcp/dhclient-enter-hooks.d/resolved to excludefiles, however it didn't work. As far as I know, this hook is included in the base image and according to [1], the current implementation does not apply excludefiles to the base image. Jo [1] https://github.com/libguestfs/supermin/blob/b2401285cd3e3d42006fc164ef1f046cc35a50c4/src/mode_build.ml#L137 On

In data giovedì 9 luglio 2015 09:58:45, Richard W.M. Jones ha scritto: > --- > appliance/excludefiles.in | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in > index 9a48db7..c53a913 100644 > --- a/appliance/excludefiles.in > +++ b/appliance/excludefiles.in > @@ -32,12 +32,7 @@ dnl The

Debian is also doing a UsrMove/UsrMerge: https://wiki.debian.org/UsrMerge However it is not finalized that Debian will actually make this change. Since some Debian systems have /sbin as a symlink and other have /sbin as a real directory, and we should avoid choosing a symlinked directory for the daemon, the easiest fix is simply to probe /usr/sbin before /sbin since under all scenarios (and

Do not error out on empty files, just ignore them. --- src/mode_build.ml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mode_build.ml b/src/mode_build.ml index b5f5fa6..9cd0a21 100644 --- a/src/mode_build.ml +++ b/src/mode_build.ml @@ -46,6 +46,7 @@ and file_content = | Packages | Hostfiles | Excludefiles +| Empty let rec string_of_file_type = function |

Move the removal of the files which don't exist or cannot be read, doing it after the filtering with excludefiles and hostfiles files. This avoid stat'ing files which will be excluded later anyway, hence reducing the I/O during a supermin build phase. --- src/build.ml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/build.ml

Add a --with-distro=ID argument for configure, so it is possible to manually specify the distro to use for the packages (in case os-release does not provide ID=.., or the ID is not recognized yet). In the case when --with-distro is not set, keep doing the autodetection, but using os-release only, i.e. dropping the checks for all the other -release files -- since there is --with-distro, older

Use /etc/os-release as first option, translating the distro name to the current identifier used. The other options (the release files) are left as following checks, avoiding them if any matches. --- m4/guestfs_appliance.m4 | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index 8cff51e..b48da74 100644

Hi, Rich: I met a supermin issue on CentOS 7.1: supermin: version: 5.1.10 supermin: rpm: detected RPM version 4.11 supermin: package handler: fedora/rpm supermin: acquiring lock on /root/test/aaa/lock supermin: build: /usr/lib64/guestfs/supermin.d supermin: build: visiting /usr/lib64/guestfs/supermin.d/base.tar.gz type gzip base image (tar) supermin: build: visiting

Workaround for Ubuntu which uses this script to try to start a systemd service. That won't work because systemd is not used inside the appliance. See: https://bugs.launchpad.net/ubuntu/+source/supermin/+bug/1824236 Thanks: Ioanna Alifieraki --- appliance/init | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/appliance/init b/appliance/init index 4f2b55822..b1c4d09ea

On Fri, 2017-09-01 at 10:59 +0100, Daniel P. Berrange wrote: > On Fri, Sep 01, 2017 at 11:25:17AM +0200, Cédric Bosdonnat wrote: > > All SUSE distros have a ID_LIKE=suse, including the fake one used > > for building that has a ID=Dummy value. Without reading ID_LIKE > > on SUSE distros, the generated appliance packagelist is not correct. > > > > This fix reads

On Thu, Apr 18, 2019 at 12:17:18PM +0100, Ioanna Alifieraki wrote: > I had tried this approach, to add /etc/dhcp/dhclient-enter-hooks.d/resolved > to excludefiles, however it didn't work. > As far as I know, this hook is included in the base image and according > to [1], the current implementation does not apply excludefiles to the base > image. Yes I think that is right. It

Hi, Is there any chance you will merge the suggested patch? Thanks, Jo On Thu, Apr 18, 2019 at 2:01 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Thu, Apr 18, 2019 at 12:17:18PM +0100, Ioanna Alifieraki wrote: > > I had tried this approach, to add > /etc/dhcp/dhclient-enter-hooks.d/resolved > > to excludefiles, however it didn't work. > > As far as I

I am trying to mount a windows 10 backup .vhdx file. I installed libguestfs through ```sudo apt-get install libguestfs-tools``` I am running Ubuntu 18.04.1 LTS and this is the installed version: ```1:1.36.13-1ubuntu3.2``` This is the output of the command I ran: ``` ~$ guestmount --add Documents/8be29c38-0000-0000-0000-602200000000.vhdx --inspector --ro /media/Windows10/ libguestfs: trace: