Libguestfs - Jul 2015 - Re: [PATCH] appliance: exclude /usr/lib/firmware

Brings the size of the appliance down to 95 MB [xz-compressed], which
is the same as for libguestfs 1.28.
---
 appliance/excludefiles.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
index d3c66cc..a63eca9 100644
--- a/appliance/excludefiles.in
+++ b/appliance/excludefiles.in
@@ -22,6 +22,9 @@ dnl The right kernel modules are added back by supermin.
 -/boot/*
 -/lib/modules/*
 
+dnl Firmware blobs should not be required by a virtual machine.
+-/usr/lib/firmware/*
+
 -/usr/lib/locale/*
 -/usr/share/cracklib/*
 -/usr/share/doc/*
-- 
2.4.3

On Thursday 23 July 2015 15:10:41 Richard W.M. Jones
wrote:
> Brings the size of the appliance down to 95 MB [xz-compressed], which
> is the same as for libguestfs 1.28.
> ---
>  appliance/excludefiles.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
> index d3c66cc..a63eca9 100644
> --- a/appliance/excludefiles.in
> +++ b/appliance/excludefiles.in
> @@ -22,6 +22,9 @@ dnl The right kernel modules are added back by supermin.
>  -/boot/*
>  -/lib/modules/*
>  
> +dnl Firmware blobs should not be required by a virtual machine.
> +-/usr/lib/firmware/*
> +
Hm this should rather be /lib/firmware, as that's the canonical
locations for firmwares on Linux (/usr/lib/firmware exists on UsrMove
systems).

LGTM if changed to /lib/firmware.

Thanks,
-- 
Pino Toscano

On Thu, Jul 23, 2015 at 05:28:12PM +0200, Pino Toscano
wrote:
> On Thursday 23 July 2015 15:10:41 Richard W.M. Jones wrote:
> > Brings the size of the appliance down to 95 MB [xz-compressed], which
> > is the same as for libguestfs 1.28.
> > ---
> >  appliance/excludefiles.in | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
> > index d3c66cc..a63eca9 100644
> > --- a/appliance/excludefiles.in
> > +++ b/appliance/excludefiles.in
> > @@ -22,6 +22,9 @@ dnl The right kernel modules are added back by
supermin.
> >  -/boot/*
> >  -/lib/modules/*
> >  
> > +dnl Firmware blobs should not be required by a virtual machine.
> > +-/usr/lib/firmware/*
> > +
> 
> Hm this should rather be /lib/firmware, as that's the canonical
> locations for firmwares on Linux (/usr/lib/firmware exists on UsrMove
> systems).
> 
> LGTM if changed to /lib/firmware.
Good point.  Before I commit this I'll have to check it still works if
we use /lib/firmware.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW