Libguestfs - Jul 2015 - [PATCH] appliance: Exclude everything in /var/log/* from the appliance (RHBZ#1239154).

---
 appliance/excludefiles.in | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
index 9a48db7..c53a913 100644
--- a/appliance/excludefiles.in
+++ b/appliance/excludefiles.in
@@ -32,12 +32,7 @@ dnl The right kernel modules are added back by supermin.
 -/usr/share/i18n/*
 -/usr/share/pkgconfig/*
 
--/var/log/*.log*
--/var/log/cron*
--/var/log/lastlog*
--/var/log/messages*
--/var/log/secure*
--/var/log/syslog*
+-/var/log/*
 
 dnl For Debian:
 -/usr/share/lintian/*
-- 
2.3.1

In data giovedì 9 luglio 2015 09:58:45, Richard W.M. Jones ha
scritto:
> ---
>  appliance/excludefiles.in | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
> index 9a48db7..c53a913 100644
> --- a/appliance/excludefiles.in
> +++ b/appliance/excludefiles.in
> @@ -32,12 +32,7 @@ dnl The right kernel modules are added back by supermin.
>  -/usr/share/i18n/*
>  -/usr/share/pkgconfig/*
>  
> --/var/log/*.log*
> --/var/log/cron*
> --/var/log/lastlog*
> --/var/log/messages*
> --/var/log/secure*
> --/var/log/syslog*
> +-/var/log/*
>  
>  dnl For Debian:
>  -/usr/share/lintian/*
LGTM.

5 files less in the appliance on f21, and 1 file less on Debian/testing.

Thanks,
-- 
Pino Toscano

On Thu, Jul 09, 2015 at 11:53:49AM +0200, Pino Toscano
wrote:
> In data giovedì 9 luglio 2015 09:58:45, Richard W.M. Jones ha scritto:
> > ---
> >  appliance/excludefiles.in | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/appliance/excludefiles.in b/appliance/excludefiles.in
> > index 9a48db7..c53a913 100644
> > --- a/appliance/excludefiles.in
> > +++ b/appliance/excludefiles.in
> > @@ -32,12 +32,7 @@ dnl The right kernel modules are added back by
supermin.
> >  -/usr/share/i18n/*
> >  -/usr/share/pkgconfig/*
> >  
> > --/var/log/*.log*
> > --/var/log/cron*
> > --/var/log/lastlog*
> > --/var/log/messages*
> > --/var/log/secure*
> > --/var/log/syslog*
> > +-/var/log/*
> >  
> >  dnl For Debian:
> >  -/usr/share/lintian/*
> 
> LGTM.
> 
> 5 files less in the appliance on f21, and 1 file less on Debian/testing.
I'm worried this will break something, but I'm not sure what.

It completely removes everything in /var/log including subdirectories,
and therefore any program which we might run that expects to write to
a pre-created /var/log/<somedir>/ may fail.

Unfortunately supermin currently has no way to just exclude files, and
in the actual case I'm looking at we need to remove large files in
subdirectories too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top