similar to: Possible mitigation for forgetting phabricator subcriptions for {llvm, cfe}-commits?

Forgot to mention: > Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig? The review request will belong to a single repository, as you noticed (from the closest .arcconfig to where the arc command was invoked). However, when commits land, they will be imported under either one (rL for LLVM diffs) or two (rL + rC for e.g.

Hi Ben, (+llvm-dev since the email I'm replying to wasn't sent there) 2017-11-21 17:18 GMT+01:00 Ben Hamilton via cfe-dev <cfe-dev at lists.llvm.org> : > OK. I confirmed that Stephan's process to send out cross-repo diffs from > the monorepo is not affected by my proposal. > > I'm a bit late to the party, and I might just not have comprehended this correctly.

This seems to happen for several projects including libcxx, libcxxabi, and libunwind. Shouldn't herald and the commit hooks do the same thing? Here's a link to the rule herald is using: https://reviews.llvm.org/H270 -------------- next part -------------- An HTML attachment was scrubbed... URL:

I have been noticing odd behavior like that. I think it started with the auto-subscribe behavior when you specify a repository? --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Don Hinton via llvm-dev Sent: Monday, January 22, 2018 3:04 PM To: LLVM Development List Subject: [llvm-dev] Phabricator subscribes non-clang projects to llvm-commit, but the commit hook

On 27 May 2015 at 09:29, Justin Bogner <mail at justinbogner.com> wrote: > Mehdi Amini <mehdi.amini at apple.com> writes: >> Hi Manuel, >> >> I like Phabricator for code review much much more than emails. Let me know how >> I can help (I’m not afraid of PHP). > > Chandler updated the llvm phabricator doc to point at what we're deploying: > >

On Fri, May 29, 2015 at 1:54 AM Eitan Adler <lists at eitanadler.com> wrote: > On 27 May 2015 at 09:29, Justin Bogner <mail at justinbogner.com> wrote: > > Mehdi Amini <mehdi.amini at apple.com> writes: > >> Hi Manuel, > >> > >> I like Phabricator for code review much much more than emails. Let me > know how > >> I can help (I’m

It seems like this has already been set up for all the projects except for libunwind. Can we create a Differential repository for it as well? I'll be happy to update its .arcconfig once that's done. On Mon, Nov 27, 2017 at 9:02 AM Ben Hamilton via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Forgot to mention: > > > > Also, how would arcanist pick up two callsigns

+llvm-dev, so we get wider input :) Given how unfortunate reviews that are started without cc'ing the right list are (basically folks need to re-send the review from scratch), I support this idea. Ben, couldn't rL still be available for all projects? (and be the main project for LLVM). On Tue, Nov 21, 2017 at 5:18 PM Ben Hamilton via cfe-dev < cfe-dev at lists.llvm.org> wrote:

On Thu, Nov 23, 2017 at 12:58 AM Ben Hamilton <benhamilton at google.com> wrote: > Absolutely — I should have mentioned that we would keep the main rL > project and continue to use it. > Your original email said "Moving forward, only LLVM commits will be identified with the prefix rL (as in https://reviews.llvm.org/rL12345) — each project will get its own unique prefix, which

Files '.arcconfig' still contain reference to http://llvm-reviews.chandlerc.com/, so arcanist doesn't work. Thanks, --Serge 2014-04-06 3:11 GMT+07:00 Manuel Klimek <klimek at google.com>: > On Sat, Apr 5, 2014 at 8:42 PM, Manuel Klimek <klimek at google.com> wrote: > >> Short update - the sending to the *-commits lists doesn't work yet - I'm >>

On 10 January 2018 at 21:06, Petr Hosek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > It seems like this has already been set up for all the projects except for > libunwind. Can we create a Differential repository for it as well? I'll be > happy to update its .arcconfig once that's done. Additionally, it might be worth considering if this change means the guidance

On Wed, Jun 25, 2014 at 3:30 PM, John Criswell <criswell at illinois.edu> wrote: > On 6/25/14, 5:15 PM, Vadim Chugunov wrote: > > In a recent review via Phabricator, I was receiving bounce notifications for > mail being sent to llvm-commits because of "Too many recipients to the > message", even though I am a subscriber. I wonder how common is that. > > >

Thanks for the catch Dead! I'll send out patches to update .arcconfig files to use https. On Thu, Jul 14, 2016 at 3:22 PM Dean Michael Berris <dberris at google.com> wrote: > Thanks Eric, > > If you're like me who started doing this and found some weird errors, you > may have to do the following instead: > > $ arc install-certificate

Mehdi Amini <mehdi.amini at apple.com> writes: > Hi Manuel, > > I like Phabricator for code review much much more than emails. Let me know how > I can help (I’m not afraid of PHP). Chandler updated the llvm phabricator doc to point at what we're deploying: http://llvm.org/docs/Phabricator.html#status That'll lead you here: https://github.com/r4nt/llvm-reviews

I have seen the "Too many recipients to the message" several times. A limit of 10 includes the patch author and the list leaving just 8 subscribers/reviewers is way too low. Given that these e-mails can be sent only by a Phab. user I'm not sure that spam is a problem at all: A potential spammer would first have to subscribe to Phab. then create a proper diff,... far easier just to

You might want to mention other functionality, like Herald, which I think fills a need that a lot of developers have. Well, I guess since this message is on the list, I can just say: Phabricator's "Herald" tool lets you (among other things) set up actions to happen in response to certain events; one huge use case for this is setting up alerts when parts of the tree that you are

On 6/24/20 3:41 PM, Chris Lattner via llvm-dev wrote: >> When I looked into this possibility (GitHub PR) when we merged MLIR in the monorepo: just Herald rules was already a blocker and I couldn't find a replacement readily available on GitHub. The handling of stack of revisions on GitHub was another problem mentioned. > Fair enough - I haven’t investigated the technical issues with

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup reviewers my editor pops up and there is a "Reviewers:" line and but I'm unable email addresses directly. It seems it wants reviewers passed on the command line or some how in .arcconfig. But I haven't been able to find any

On Wed, Oct 17, 2012 at 8:25 PM, Sean Silva <silvas at purdue.edu> wrote: > You might want to mention other functionality, like Herald, which I > think fills a need that a lot of developers have. > > Well, I guess since this message is on the list, I can just say: > Phabricator's "Herald" tool lets you (among other things) set up > actions to happen in

Folks, For some reason, all new phabricator diffs are automatically including Amara, which is probably a bit annoying for him, but pointless. I believe it happens because his name is the first in the alphabetical order. Can someone have a look at what's going on? cheers, --renato