Don Hinton via llvm-dev
2018-Jan-22 23:03 UTC
[llvm-dev] Phabricator subscribes non-clang projects to llvm-commit, but the commit hook still uses cfe-commits
This seems to happen for several projects including libcxx, libcxxabi, and libunwind. Shouldn't herald and the commit hooks do the same thing? Here's a link to the rule herald is using: https://reviews.llvm.org/H270 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180122/7ce6b49a/attachment.html>
Robinson, Paul via llvm-dev
2018-Jan-23 01:29 UTC
[llvm-dev] Phabricator subscribes non-clang projects to llvm-commit, but the commit hook still uses cfe-commits
I have been noticing odd behavior like that. I think it started with the auto-subscribe behavior when you specify a repository? --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Don Hinton via llvm-dev Sent: Monday, January 22, 2018 3:04 PM To: LLVM Development List Subject: [llvm-dev] Phabricator subscribes non-clang projects to llvm-commit, but the commit hook still uses cfe-commits This seems to happen for several projects including libcxx, libcxxabi, and libunwind. Shouldn't herald and the commit hooks do the same thing? Here's a link to the rule herald is using: https://reviews.llvm.org/H270 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180123/9a913dbc/attachment.html>
Don Hinton via llvm-dev
2018-Jan-23 03:50 UTC
[llvm-dev] Phabricator subscribes non-clang projects to llvm-commit, but the commit hook still uses cfe-commits
Looks like these were created before .arcconfig was updated with the correct repository, so they incorrectly referenced LLVM. New ones seem to work correctly. On Mon, Jan 22, 2018 at 5:29 PM, Robinson, Paul <paul.robinson at sony.com> wrote:> I have been noticing odd behavior like that. I think it started with the > auto-subscribe behavior when you specify a repository? > > --paulr > > > > *From:* llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] *On Behalf Of *Don > Hinton via llvm-dev > *Sent:* Monday, January 22, 2018 3:04 PM > *To:* LLVM Development List > *Subject:* [llvm-dev] Phabricator subscribes non-clang projects to > llvm-commit, but the commit hook still uses cfe-commits > > > > This seems to happen for several projects including libcxx, libcxxabi, and > libunwind. > > > > Shouldn't herald and the commit hooks do the same thing? > > > > Here's a link to the rule herald is using: https://reviews.llvm.org/H270 >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180122/41cfa165/attachment.html>
Reasonably Related Threads
- Phabricator subscribes non-clang projects to llvm-commit, but the commit hook still uses cfe-commits
- FYI: LLVM Phabricactor notifications.
- [cfe-dev] [Proposal] Automatically Cc: cfe-commits@ on Clang reviews
- Possible mitigation for forgetting phabricator subcriptions for {llvm, cfe}-commits?
- [cfe-dev] [Proposal] Automatically Cc: cfe-commits@ on Clang reviews