similar to: Unable to Commit to GitHub

Hello, I was wondering what was the current expected practice for committing patches to LLVM now that the Git monorepo is here. I have commit access to SVN but when I try to land my patched through GitHub I get an error saying "Permission to llvm/llvm-project.git denied". Depending on the answer, the documentation might need to be slightly clarified: the getting started documents for

Hi Ben, (+llvm-dev since the email I'm replying to wasn't sent there) 2017-11-21 17:18 GMT+01:00 Ben Hamilton via cfe-dev <cfe-dev at lists.llvm.org> : > OK. I confirmed that Stephan's process to send out cross-repo diffs from > the monorepo is not affected by my proposal. > > I'm a bit late to the party, and I might just not have comprehended this correctly.

+llvm-dev, so we get wider input :) Given how unfortunate reviews that are started without cc'ing the right list are (basically folks need to re-send the review from scratch), I support this idea. Ben, couldn't rL still be available for all projects? (and be the main project for LLVM). On Tue, Nov 21, 2017 at 5:18 PM Ben Hamilton via cfe-dev < cfe-dev at lists.llvm.org> wrote:

On Thu, Nov 23, 2017 at 12:58 AM Ben Hamilton <benhamilton at google.com> wrote: > Absolutely — I should have mentioned that we would keep the main rL > project and continue to use it. > Your original email said "Moving forward, only LLVM commits will be identified with the prefix rL (as in https://reviews.llvm.org/rL12345) — each project will get its own unique prefix, which

Forgot to mention: > Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig? The review request will belong to a single repository, as you noticed (from the closest .arcconfig to where the arc command was invoked). However, when commits land, they will be imported under either one (rL for LLVM diffs) or two (rL + rC for e.g.

I'm sure I've seen many commits with both "Reviewed by:" and "Reviewers:" tags, which look to have been done with arc (though I can't be sure). How were those generated? On Sat, 4 Jan 2020 at 19:12, David Blaikie <dblaikie at gmail.com> wrote: > Yeah, I tend to prune it down myself - and if the list has only one name > on it, it's usually a pretty

One is expected to use `git llvm push`. For more information, please see: https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git > On Sep 3, 2019, at 7:06 PM, David Greene via cfe-dev <cfe-dev at lists.llvm.org> wrote: > > What is the expected way to do commits? Do we push directly to master > after a rebase? I know there has been talk of using

Hi, I've created a text file[1] in the SVN repository that developers can update in order to request commit access to the GitHub repository. All you need to do is add a line in the form of $SVN_USERNAME:$GITHUB_USERNAME Please add your information to this file before SVN becomes readonly on October 21 to avoid a gap in commit access. More details can be found in the phabriactor review[2]

Hi All, I just posted a review with arcanist (which I'm fairly new to) and it included a build status. How it got there is totally opaque to me, but my workflow was: Using git+svn (following the setup in https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn) make a change, commit with 'git commit', create review with 'air diff'. It would be cool if

Hi all, TL;DR - should we recommend core.autocrlf=input instead of core.autocrlf=false on Windows? I recently switched from doing pre-commit builds and tests from my Ubuntu VM, to my Windows machine where I do all my development. I was aware that line endings is an issue, so made sure to set core.autocrlf=false as directed in the Getting Started guide (see

Hi, I tried to commit the Differential revision D3021 with the "arc commit" command. While it showed that the command succeeded and the Differential revision was closed, I can't find the revision anywhere in the SVN repository or the GIT mirror. Did I forget something? I tried a manual commit a few days ago and it worked. I've put the output of the "arc

I'm not sure if this is well known, but it helped me so I thought I'd share it with you. When committing to gitmonorepo, (with git llvm push) you need to have committed to your local repo first and so you need to have crafted your commit message from your the Phabricator revision. (e.g. D12345) Phabricator has the ability to give you this commit message it would have used, even if you do

> On Feb 20, 2020, at 14:25, Johannes Doerfert <johannesdoerfert at gmail.com> wrote: > > On 02/20, Louis Dionne via llvm-dev wrote: >> I know there has been significant discussion about "moving" from >> Phabricator to GitHub reviews and pull requests, etc. I'm not >> suggesting that we do anything in terms of global LLVM policy. >> However, as

> On Mar 3, 2020, at 17:16, Shoaib Meenai <smeenai at fb.com> wrote: > > `arc patch` should preserve the author information in the original commit, if there was any. At least it has in my experience. Yes, but I think people can upload raw patches to Phabricator without using `arc diff`. I know I ran into one of these just last week where I used Johannes' script (thanks!) and

> On Mar 3, 2020, at 18:48, Eric Christopher <echristo at gmail.com> wrote: > > I'm one of those people ;) That's not something to be proud of if you expect a maintainer to commit on your behalf. If you commit yourself, then whatever. Louis > > -eric > > On Tue, Mar 3, 2020 at 2:20 PM Louis Dionne via llvm-dev <llvm-dev at lists.llvm.org

Right, my understanding is that files that specifically need CRLF should say so via .gitattributes somewhere. autocrlf=false ought to work if your Windows editor doesn’t (or can be persuaded not to) introduce CRLFs. I’ve observed that the Visual Studio editor will detect the line-ending style of the file you’re editing, and imitate it. This works great until you create a new file. 😝 So I’ve

What's the status here? Can someone keep https://llvm.org/docs/Proposals/GitHubMove.html updated with the current status of things? And once things are usable, probably update https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo as well. On Wed, Oct 24, 2018 at 4:57 AM Jacob Carlborg via lldb-dev < lldb-dev at lists.llvm.org> wrote: > On 2018-10-24

On Tue, Jan 7, 2020 at 5:35 PM Jonas Devlieghere <jonas at devlieghere.com> wrote: > On Tue, Jan 7, 2020 at 5:16 PM Bill Wendling via cfe-dev > <cfe-dev at lists.llvm.org> wrote: > > > > On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> > wrote: > >> > >> Hi Bill, > >> > >> On 01/07, Bill Wendling

That last post I see on this mailing list is from November <http://lists.llvm.org/pipermail/llvm-dev/2016-November/106941.html> concerning the results of the survey. So I was wondering what the latest status for moving to github? -- Wnk -------------- next part -------------- An HTML attachment was scrubbed... URL:

Folks, I'm now using the git mirror, but I'm not sure how to commit changes via git, if at all possible. So far, I'm diffing & applying it on an RW svn tree and committing, but that makes me test twice and it's error prone. I read the manual regarding git-svn setup and all it has is the connection to svn to keep svn's linearity, but nothing on commit strategy. With git,