similar to: [PATCH hivex 1/2] maint: avoid some syntax-check test failures

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

Does hivex have a trivial-patch policy? >From e23c45a2f813ac29b022faa9112c1977b651862f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 17:34:26 +0200 Subject: [PATCH hivex] maint: remove unnecessary mkdir -p * ocaml/Makefile.am (install-data-hook): Remove unneeded mkdir -p. It's job is handled by the very next mkdir -p. ---

Hi Rich, I noticed that libguestfs's cfg.mk had an old (and relatively inefficient) version of the rule that checks for empty lines at EOF. The one in maint.mk is much more efficient: >From cf93f04a980ec01ef37db9a0d4c7b99015169eee Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Sep 2012 11:49:34 +0200 Subject: [PATCH libguestfs] maint: remove a

With this, "make syntax-check" runs a few more tests, all passing. >From febff9d2a35c4f40abbaf8943146476bdeac671e Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 4 Aug 2009 13:49:19 +0200 Subject: [PATCH 1/8] build: remove more files added by ./autogen.sh * po/LINGUAS: Remove file. * po/Makefile.in.in: Likewise. * po/Makevars: Likewise. *

Whilst building hivex I'm seeing warnings/errors for the documentation: pod2html complaints: /usr/bin/pod2html: sh/hivexsh.pod: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivex(3)> in paragraph 8. /usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<virt-cat(1)> in paragraph 8. /usr/bin/pod2html:

--- sh/hivexsh.pod | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sh/hivexsh.pod b/sh/hivexsh.pod index 7d7fc0a..8b10a6a 100644 --- a/sh/hivexsh.pod +++ b/sh/hivexsh.pod @@ -61,6 +61,13 @@ script, use: #!/usr/bin/hivexsh -f +=item B<-u> + +Use heuristics to tolerate certain levels of corruption within hives. + +This is unsafe but may allow to export/merge valid keys/values

Otherwise we get "Can't open ..." warnings which don't seem to be fatal. --- regedit/Makefile.am | 2 +- sh/Makefile.am | 4 ++-- xml/Makefile.am | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/regedit/Makefile.am b/regedit/Makefile.am index 7977334..476c059 100644 --- a/regedit/Makefile.am +++ b/regedit/Makefile.am @@ -39,6 +39,6 @@

Move the temporary output of pod2man to the correct name only if pod2man did not fail: this also makes the whole command fail if pod2man fails, e.g. because of wrong markup. --- lib/Makefile.am | 2 +- regedit/Makefile.am | 2 +- sh/Makefile.am | 4 ++-- xml/Makefile.am | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index

... and why they are (probably) not errors. > bindtextdomain > daemon/guestfsd.c > erlang/erl-guestfs-proto.c > examples/copy_over.c > examples/create_disk.c > examples/display_icon.c > examples/inspect_vm.c > examples/mount_local.c > examples/virt-dhcp-address.c > tests/c-api/test-add-drive-opts.c > tests/c-api/test-add-libvirt-dom.c >

OS X lacks open_memstream, causing hivexsh to fail to build. This patch defines HAVE_HIVEXSH, setting the only condition to open_memstream existence. Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- Makefile.am | 6 +++++- configure.ac | 4 ++++ 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8d69c55..dbab38a 100644 ---

This patch series improves, but does not complete, OS X support for hivex. There are several outstanding issues before hivexml and hivexsh can run: * hivexsh uses open_memstream, which doesn't exist in OS X as near as I can see. Unfortunately, I'm inexperienced with autoconf, so I'm not sure how to employ AC_CHECK_FUNCS([open_memstream]) to conditionally add 'sh' to the

Currently 'hivexget' is a very clumsy command line tool which only lets you display a single registry key in a hive file, for example: $ hivexget SOFTWARE '\Microsoft\Windows\TabletPC\TabSetup\' "TabletSetup"=dword:00000000" This is inflexible and got really annoying as I was trying to explore these hive files in preparation for adding write support to hivex.

Thanks for providing the SOFTWARE and SYSTEM hives. Firstly the SOFTWARE hive has an unusually large 'nk' node, which required me to increase one of the limits in hivex: https://github.com/libguestfs/hivex/commit/bec3f0bb632c4b84a1dfb73eb6333c2ba9834ffb The SYSTEM hive was even more interesting: $ hivexsh system Welcome to hivexsh, the hivex interactive shell for examining

--- hivex/hivexsh.pod | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hivex/hivexsh.pod b/hivex/hivexsh.pod index 277e3ae..9336798 100644 --- a/hivex/hivexsh.pod +++ b/hivex/hivexsh.pod @@ -100,7 +100,14 @@ or even: Path elements (node names) are matched case insensitively, and characters like space, C<*>, and C<?> have I<no> special

On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote: > We?re looking into using Hivex and came across something odd. While > the license of hivex.c is LGPL 2.1, it appears to require the GPL > 3.0 licensed gnulib package for a few minor functions ( full_read, > full_write and c_toupper ). There are also a few GPL 3.0 build > files. It has always been our intention to

(Resending since my message from 2 days ago didn't make it to the list. Perhaps because of the log file attachment) Hi Rich, Sorry about the delayed response. I understand that since hive formats are not open, the current tack of warning about the hive file is a better one To respond to you question about "whether it fails", hivexsh is unable to open the hive file and it prints

I tried both hivex-1.2.5 and hivex-1.2.7, same result. The same software hive can be loaded using Windows regedit tool, and had no problem to access the "Classes" key. The other keys under Software (like Microsoft, Wow6432Node, etc.) are OK. Here is the hivexsh output with HIVEX_DEBUG=1 enabled:

On Fri, Oct 04, 2013 at 02:12:08PM +0000, Subramanian, Hari wrote: > To respond to you question about "whether it fails", hivexsh is unable to > open the hive file and it prints this message and exits. I've attached the > verbose logs as requested OK, I understand it now. It is in fact failing, setting errno = ENOSYS and returning an error. > This extract from the logs

The following patches address issues when dealing with hives that have corrupted data in them but are otherwise readable/writable. Those were found on some rather rare Windows installations that seem to work fine but current hivex fails to even open. Those patches change hivex to simply log and ignore such "corrupted" regions instead of aborting because the caller might be looking at

I recenetly came across a Windows XP image, where one REG_QWORD value (HKLM\Software\Microsoft\Windows\CurrentVersion\Group Policy\State\Machine\Scripts\Shutdown\0\0\ExecTime) would be displayed by hivexsh but hivex_value_qword() would return -1. It turned out that the data length of this value was 16 bytes instead of 8. There is no problem in simply interpreting the first 4 (DWORD) or 8 (QWORD)