Pino Toscano
2017-Jul-14 10:02 UTC
[Libguestfs] [hivex PATCH 1/2] hivexregedit: fix POD markup
Put the "=back" to close the list only after the last element. --- regedit/hivexregedit | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/regedit/hivexregedit b/regedit/hivexregedit index 02c382b..cd49063 100755 --- a/regedit/hivexregedit +++ b/regedit/hivexregedit @@ -248,8 +248,6 @@ You should only use this option for quick hacking and debugging of the hive contents, and I<never> use it if the output is going to be passed into another program or stored in another hive. -=back - =cut my $unsafe; @@ -261,6 +259,8 @@ Use heuristics to tolerate certain levels of corruption within hives. This is unsafe but may allow to export/merge valid keys/values in an othewise corrupted hive. +=back + =cut GetOptions ("help|?" => \$help, -- 2.9.4
Pino Toscano
2017-Jul-14 10:02 UTC
[Libguestfs] [hivex PATCH 2/2] build: do not ignore pod2man error codes
Move the temporary output of pod2man to the correct name only if pod2man did not fail: this also makes the whole command fail if pod2man fails, e.g. because of wrong markup. --- lib/Makefile.am | 2 +- regedit/Makefile.am | 2 +- sh/Makefile.am | 4 ++-- xml/Makefile.am | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index f711f22..4a7cea1 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -61,7 +61,7 @@ hivex.3: hivex.pod -c "Windows Registry" \ --name "hivex" \ --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \ - $< > $@-t; mv $@-t $@ + $< > $@-t && mv $@-t $@ noinst_DATA = \ $(top_builddir)/html/hivex.3.html diff --git a/regedit/Makefile.am b/regedit/Makefile.am index 476c059..749c221 100644 --- a/regedit/Makefile.am +++ b/regedit/Makefile.am @@ -28,7 +28,7 @@ hivexregedit.1: hivexregedit -c "Windows Registry" \ --name "hivexregedit" \ --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \ - $< > $@-t; mv $@-t $@ + $< > $@-t && mv $@-t $@ noinst_DATA = \ $(top_builddir)/html/hivexregedit.1.html diff --git a/sh/Makefile.am b/sh/Makefile.am index 1c2aba8..98fdd05 100644 --- a/sh/Makefile.am +++ b/sh/Makefile.am @@ -51,7 +51,7 @@ hivexget.1: hivexget.pod -c "Windows Registry" \ --name "hivexget" \ --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \ - $< > $@-t; mv $@-t $@ + $< > $@-t && mv $@-t $@ hivexsh.1: hivexsh.pod $(POD2MAN) \ @@ -59,7 +59,7 @@ hivexsh.1: hivexsh.pod -c "Windows Registry" \ --name "hivexsh" \ --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \ - $< > $@-t; mv $@-t $@ + $< > $@-t && mv $@-t $@ noinst_DATA = \ $(top_builddir)/html/hivexget.1.html \ diff --git a/xml/Makefile.am b/xml/Makefile.am index ca3f964..3ebe2cc 100644 --- a/xml/Makefile.am +++ b/xml/Makefile.am @@ -40,7 +40,7 @@ hivexml.1: hivexml.pod -c "Windows Registry" \ --name "hivexml" \ --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \ - $< > $@-t; mv $@-t $@ + $< > $@-t && mv $@-t $@ noinst_DATA = \ $(top_builddir)/html/hivexml.1.html -- 2.9.4
Richard W.M. Jones
2017-Jul-14 11:10 UTC
Re: [Libguestfs] [hivex PATCH 2/2] build: do not ignore pod2man error codes
ACK series. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Seemingly Similar Threads
- [PATCH 2/2] hivex: Make sure that pod2html finds the POD file when building out-of-tree
- [hivex PATCH 1/2] hivexregedit: fix POD markup
- [PATCH 1/2] hivex: ruby: find files to install in correct directories when building out-of-tree
- hivex: pod2html complaints
- [PATCH 0/2] hivex shell