similar to: [PATCH] Fix dbomatic state changes.

Also includes a couple minor model changes to support better error reporting. This method was added so that a client could submit multiple vms to the service layer in one call and get back appropriate messages showing any failures without those failures also causing the entire call to fail, or forcing the client to implement handling (begin/rescue blocks) of these errors to continue through the

The error is caused by the save! method updating an object that another thread (most likely in taskomatic) already updated. In the case of this race condition, we retry saving. However, a proper fix would involve fixing the locking. --- src/db-omatic/db_omatic.rb | 23 ++++++++++++++++++++--- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/db-omatic/db_omatic.rb

This patch updates dbomatic, taskomatic and host-register to use the new C++ wrapped ruby QMF bindings. It also fixes a couple of bugs along the way including the 0 cpu bug for host-register. This is a compilation of work done by myself and Arjun Roy. Signed-off-by: Ian Main <imain at redhat.com> --- src/db-omatic/db_omatic.rb | 111 ++++++-------

Hi all, We use for preproduction purpose the next branche of oVirt. We notice that a lot of bugs appears when the number of message in qpidd increase. It seems that qpidd is doing the job and that most of the issue are due to Qmf::Query . For example in db-omatic lines 265,296 When you restart db-omatic, if you have multiple node, you have mutiple threads launch (line 266) that hang on :

This fix db-omatic that cannot recover the node on wich the vm run for example. We have not investigate far away but that can be due to a change on the ruby-qmf API. Signed-off-by: Michel Loiseleur <mloiseleur at linagora.com> --- src/db-omatic/db_omatic.rb | 10 ++++++---- src/libvirt-list.rb | 6 +++--- src/matahari-list.rb | 4 ++-- 3 files changed, 11

--- src/db-omatic/db_omatic.rb | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/db-omatic/db_omatic.rb b/src/db-omatic/db_omatic.rb index 155ff5e..b5b7b81 100755 --- a/src/db-omatic/db_omatic.rb +++ b/src/db-omatic/db_omatic.rb @@ -270,10 +270,10 @@ class DbOmatic < Qpid::Qmf::Console end def object_props(broker, obj) - target =

The underlying issue has to do with optimistic locking for active record, and contention between db-omatic and task-omatic. That still needs to be fixed, especially since contention issues might get worse when the two daemons are made multithreaded. --- src/db-omatic/db_omatic.rb | 22 +++++++++++++++++++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git

Signed-off-by: Loiseleur Michel <mloiseleur at linagora.com> --- src/db-omatic/db_omatic.rb | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/db-omatic/db_omatic.rb b/src/db-omatic/db_omatic.rb index da11bfa..79f29d2 100755 --- a/src/db-omatic/db_omatic.rb +++ b/src/db-omatic/db_omatic.rb @@ -195,6 +195,9 @@ class DbOmatic < Qmf::ConsoleHandler end

This fixes a bug where if db-omatic restarted, any running vm lost the association with the host it is running on in the db. --- src/db-omatic/db_omatic.rb | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/db-omatic/db_omatic.rb b/src/db-omatic/db_omatic.rb index b5b7b81..d2540e1 100755 --- a/src/db-omatic/db_omatic.rb +++ b/src/db-omatic/db_omatic.rb @@

This patch changes taskomatic so it only sets the VM to shutdown if the undefine succeeds. Otherwise it's possible a shutdown event could not succeed, or take a while as it often does, giving confusing messages to the user. Basically we're just letting dbomatic handle it now. Signed-off-by: Ian Main <imain at redhat.com> --- src/task-omatic/taskomatic.rb | 1 - 1 files

Hi all, I've got some problems to make work oVirt. I've installed a Fedora 10 VM the lightest possible (nothing checked, even based) and installed after some packages (wget, sudo, acpid,...) and updated the system. By the way, acpid should be a dependency of ovirt-installer because the installation fails if it's not available. I've then installed ovirt (ovirt-server-installer

From: Simon Courtois <scourtois at linagora.com> Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 19 ++++++++++++++++- src/app/views/vm/_form.rhtml | 25 ++++++++++++++++++++--- src/db/migrate/044_add_virtio_to_vm_and_nic.rb | 11 ++++++++++ src/public/stylesheets/components.css | 5

Signed-off-by: Simon COURTOIS <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 5 ++ src/app/models/vm_task.rb | 4 +- src/app/views/vm/start.rhtml | 77 ++++++++++++++++++++++++++++++++++ src/task-omatic/taskomatic.rb | 7 +++- 4 files changed, 91 insertions(+), 2 deletions(-) create mode 100644 src/app/views/vm/start.rhtml diff

Previously, a pxe-booted vm would always boot to HD at next startup. Signed-off-by: Nicolas Ochem <nicolas.ochem at alcatel-lucent.com> --- src/app/controllers/vm_controller.rb | 1 + src/app/models/vm.rb | 15 +++++++++++---- src/app/views/vm/_form.rhtml | 2 +- src/task-omatic/taskomatic.rb | 13 +++++++++++-- 4 files changed, 24 insertions(+), 7

Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/task-omatic/taskomatic.rb | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index 471ec88..1dfd74f 100755 --- a/src/task-omatic/taskomatic.rb +++ b/src/task-omatic/taskomatic.rb @@ -355,11 +355,10 @@ class TaskOmatic end end

Hi, is there a good reason why taskomatic check the number of real cores in the find_capable_host ? It prevents to use the full capacity of multithreading Signed-off-by: Arthur Clement <aclement at linagora.com> --- src/task-omatic/taskomatic.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index

Removes node identification functionality from host-browser.rb and adds a new script, host-register.rb, that takes over that functionality. The chief difference is that host-browser used a simple TCP server setup to get data from the node, while host-register uses the qpid bus to do so. Specifically, it communicates with the matahari qmf agent added to the node in two related patchsets to node

The purpose of this patch is to replace the identify function in host-browser.rb with a new script, host-register.rb. host-register.rb is a qmf ruby console that interfaces with the newly added matahari qmf agent on the ovirt node. While it stores node data in the database with the same behavior as the original host-browser implementation, it acquires the data using the amqp protocol (and

Hi, Does somebody know what is the purpose of this line in taskomatic.rb : set_vm_vnc_port(db_vm, result.description) unless result.status != 0 We removed it to avoid 2 errors in taskomatic.log when a vm is launched : ERROR Mon Aug 30 15:23:00 +0000 2010 (26416) Task action processing failed: ActiveRecord::RecordInvalid: Validation failed: Vnc port must be greater than or equal to 0 ERROR

This patch uses the qpid migration call which requires the latest libvirt-qpid and libvirt. I also add a bunch of debug logging here which is switchable but I've left it on for now so all users will have this in their logs. Signed-off-by: Ian Main <imain at redhat.com> --- src/task-omatic/taskomatic.rb | 36 ++++++++++++++++++++++++++++-------- 1 files changed, 28 insertions(+), 8