similar to: [PATCH] Improving sftp client performance

Sftp fails to correctly preserve permissions when fetching a file. It adds write permission for the owner (presumably so it can write the file). Sftp also fails to preserve the uid/gid. Added code so that if is running as root, uid and gid are preserved. patch is based on Openssh 3.4p1. *** sftp-client.c@@\main\1 Tue Oct 1 17:26:20 2002 --- sftp-client.c Tue Nov 5 10:22:52 2002

we have implemented this function for 3.1p1, and have been using it in production sense may 2002. The patch has been ported to 3.7.1p2, we have been using it in 3.7.1p2 for awhile, if anyone is interested, here it is. This is the same patch David Bradford talked about on 2002-06-05 Regards, Greg Hayes diff -u -r openssh-3.7.1p2/sftp-client.c openssh-3.7.1p2_sftp/sftp-client.c ---

Folks, I've noticed poor performance using sftp. If anyone has any advice on how to improve performance, I'd like to hear it. Test simply involved transferring a single 143MB MP3 file using defaults for all the program configs. The opensshd 3.0.2p1 server is used in all tests. Software: openssh suite 3.0.2p1 psftp (putty sftp client) latest dev snapshot pscp (putty scp client) latest

Again, this has been lightly tested. I think there still are a few glitchs. 1. stole progressmeter() from scp.c - clean up and simplified a little to remove the 'flag' status. It now understands how to initialize itself and how to terminate itself. Along with a malloced status bar instead of the original fix width bar. 2. removed all initialization code from scp.c for progressmeter()

I think my first send was eaten by elm.. Yuck I hate this programm.. Anyawys, first the disclaimer: This is barely tests, I submit this to the general population, but I will not submit this for review of rest of the OpenSSH team. Mainly because it is horrible at best. dealing with alarm() in a sane way is not fun. It does not compile clean, but works. IF anyone cares to clean it up..

This is the LAST version I plan on doing.. If I hear no feed back good or bad. Then I'll assume I've wasted my time on a feature that people whine about but don't care to try. This is against 3.0.2pX so it should be VERY easy for anyone to test. - Ben diff -ur openssh-3.0.2p1/misc.c openssh/misc.c --- openssh-3.0.2p1/misc.c Tue Jul 3 23:46:58 2001 +++ openssh/misc.c Wed Feb 6

I saw several questions regarding 'resume transfer' support in sftp come up, in the archives, but no real satisfying answer. I had a particular itch myself, so I scratched it with a quick hack. Patch attached, since it's not really big. To explain, I need to use ssh (scp or sftp) to transfer files to and from a Windows box. No other method is available. And the Windows machine has no

On Fri, 27 Feb 2004, Job 317 wrote: > Sorry, wasn't sure how to describe this well in the Subject line... > > I am using OpenSSH-3.8p1 from a RedHat 7.3 to OpenSSH-3.8p1 on a RedHat > 9.0 box. While SFTP-ing using the 'put *' command in SFTP, I get > duplicate verbosity (?) in the terminal for each file uploaded... You have found a bug, thanks. Here is a patch:

https://bugzilla.mindrot.org/show_bug.cgi?id=2171 Bug ID: 2171 Summary: potential fd leak Product: Portable OpenSSH Version: -current Hardware: Other OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: sftp Assignee: unassigned-bugs at mindrot.org

--- ../openssh/sftp-client.c Fri Feb 9 08:44:24 2001 +++ sftp-client.c Fri Feb 9 19:14:01 2001 @@ -331,7 +331,7 @@ error("Couldn't read directory: %s", fx2txt(status)); do_close(fd_in, fd_out, handle, handle_len); - return(NULL); + return(0); } } else if (type != SSH2_FXP_NAME) fatal("Expected SSH2_FXP_NAME(%d) packet, got %d",

One of the features missing in sftp is the ability to transfer a symlink. This patch adds a new command to sftp which performs this transfer. Note that it uses messages that already exist in the protocol between client and server. This diff is based on OpenSSH 3.4p1. *** sftp-client.c@@\main\1 Tue Oct 1 17:26:20 2002 --- sftp-client.c Wed Oct 23 15:57:34 2002 *************** *** 666,672 ****

I've tried to use sieve-filter for my inbox (~6000 messages). It failed after some work with this backtrace: sieve-filter(kas): Error: socketpair() failed: Too many open files sieve-filter(kas): Panic: file script-client-local.c: line 155 (script_client_local_disconnect): assertion failed: (pid >= 0) sieve-filter(kas): Error: Raw backtrace: /usr/lib/dovecot/libdovecot.so.0(+0x66a71)

While looking for leaks I came across two old packet APIs which are easy to remove. I'm sending patches for each separately. First, there is the packet_set_connection(int fd_in, int fd_out) function in opacket.c The function relies on a behavior in ssh_packet_set_connection() where, when it is passed a NULL pointer, it will implicitely allocate a struct ssh and return it after then set

This applies to the OpenBSD --current tree. Don't see why it shouldn't work under portable. Within the patch are the updates I need to make before I'll actually submit it for real, but I figured I'd make a public drop. Since I'm not on this list anymore keep me in the CC: if you want me to respond. I'll continue to work as time permits, but it would be nice if people

I've finally took the time to figure the last few bugs (that I know of). This patch will be submit to be included in a few weeks. This patch should be generic enough for portable without too much hassle. This patch mimics OpenBSD's ftp behavior. I'm not sure like that (e.g. it doesn't put / at the end of directories by default), but that is more a question for the community

https://bugzilla.mindrot.org/show_bug.cgi?id=2176 Bug ID: 2176 Summary: unchecked returned value from ftruncate Product: Portable OpenSSH Version: -current Hardware: All OS: All Status: NEW Severity: minor Priority: P5 Component: sftp Assignee: unassigned-bugs at mindrot.org

Timo, I noticed this core dump from imap the other day from one of our users; there was no assertion. GDB output attached, I have saved the core if you need more information. Jeff Earickson Colby College -------------- next part -------------- Script started on Tue May 02 09:15:48 2006 %gdb imap core.jloo GNU gdb 6.3 Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered

Upon thinking, the variable names may not be descriptive enough as `host` is a bit ambiguous and `deleted_count` may refer to a different command than expunge in imap and may be valid to track at some point so I have changed `host` to `client_ip` and `deleted_count` in imap to `expunged_count`, below is the modified diff for version 1.2.11. diff -crB dovecot-1.2.11.orig/src/imap/client.c

Hi, the sftp client from openssh package can't upload data from local pipe to remote file. For example, such a command fails: $ cat file | sftp -b <(echo 'put /dev/stdin /directory/filename') -i ~/.ssh/key user at remote.host sftp> put /dev/stdin /directory/filename /dev/stdin is not a regular file What is a purpose for such a behaviour and limitation? As experiment, I removed

Here's a patch that adds support for the creation of hard links over SFTP. Hard links are not used very often nowdays, but they do still have their uses and this is currently the most often requested improvement for SSHFS. To detect hard links the st_nlink, st_dev and st_ino attributes are usually used. I'll also post patches adding extensions for these and other attributes. Please