bugzilla-daemon at natsu.mindrot.org
2013-Nov-12 04:17 UTC
[Bug 2171] New: potential fd leak
https://bugzilla.mindrot.org/show_bug.cgi?id=2171
Bug ID: 2171
Summary: potential fd leak
Product: Portable OpenSSH
Version: -current
Hardware: Other
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: sftp
Assignee: unassigned-bugs at mindrot.org
Reporter: loganaden at gmail.com
in sftp-client.c:
if (resume_flag) {
if (fstat(local_fd, &st) == -1) {
error("Unable to stat local file \"%s\":
%s",
local_path, strerror(errno));
goto fail;
}
if ((size_t)st.st_size > size) {
error("Unable to resume download of
\"%s\": "
"local file is larger than remote",
local_path);
fail:
do_close(conn, handle, handle_len);
buffer_free(&msg);
free(handle);
return -1;
in the fail label, local_fd is not closed in case open() call was
successful.
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=2171 --- Comment #1 from Loganaden Velvindron <loganaden at gmail.com> --- Created attachment 2374 --> https://bugzilla.mindrot.org/attachment.cgi?id=2374&action=edit potential_fd_leak_fix -- You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=2171
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |djm at mindrot.org
Blocks| |2130
Resolution|--- |FIXED
--- Comment #2 from Damien Miller <djm at mindrot.org> ---
applied - thanks.
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2016-Aug-02 00:40 UTC
[Bug 2171] potential fd leak
https://bugzilla.mindrot.org/show_bug.cgi?id=2171
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.