openssh bugs - Nov 2013 - [Bug 2176] New: unchecked returned value from ftruncate

https://bugzilla.mindrot.org/show_bug.cgi?id=2176

            Bug ID: 2176
           Summary: unchecked returned value from ftruncate
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: loganaden at gmail.com

Created attachment 2378
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2378&action=edit
sftp_unchecked_return

@@ -1253,7 +1253,9 @@ do_download(struct sftp_conn *conn, char
                 "server reordered requests", local_path);
         }
         debug("truncating at %llu", (unsigned long long)highwater);
-        ftruncate(local_fd, highwater);

ftruncate value isn't checked.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2176

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2378
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2378
sftp_unchecked_return
> 		debug("truncating at %llu", (unsigned long long)highwater);
>-		ftruncate(local_fd, highwater);
>+		if (ftruncate(local_fd, highwater) == -1) {
>+			error("Unable to truncate \"%s\"", local_path);
>+		}
Please add strerror(errno) to the error text to provide a hint about
what happened.
>-
Please remove the whitespace change.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2176

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2360

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2176

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
applied with darren's changes

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2176

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.