search for: xzfile_read_block

...wrote: > Not clear to me if the following malloc is freed within lzma or if this is a leak... > https://github.com/libguestfs/nbdkit/blob/master/plugins/xz/xzfile.c#L454 Sorry for the late reply - we don't use github for problem tracking so no one was looking at this. In this function (xzfile_read_block) the 'data' pointer is returned to the caller, who must free it. The calling code is a bit complicated because it puts the 'data' pointer into a cache, where it will be freed when the cache is deleted or the block in the cache expires. So I believe this is safe, but if you think o...

v2: - Fixes a number of bugs in corner cases. - Uses a 1M block size to fetch from the underlying plugin. This improves performance considerably. I also tested this much more thoroughly and can't find any more bugs. Rich.

Matt asked if xz should really be a filter rather than a plugin. The answer is yes, of course it should be! That's been something in the todo file for a while. The commit converts the xz plugin code into a filter (leaving the plugin around, but deprecating it). plugin: nbdkit xz file.xz filter: nbdkit --filter=xz file file.xz plugin: # can't be done filter: nbdkit