search for: xuanzhuo

On Wed, Aug 16, 2023 at 10:24?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Wed, 16 Aug 2023 10:19:34 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Wed, Aug 16, 2023 at 10:16?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wa...

On Tue, 21 Mar 2023 19:58:49 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > On Wed, 15 Mar 2023 12:10:34 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > Due to historical reasons, the implementation of XDP in virtio-net is relatively > > chaotic. For example, the processing of XDP actions has two copies of...

On Thu, Mar 02, 2023 at 11:26:53AM +0800, Jason Wang wrote: > On Thu, Mar 2, 2023 at 11:24?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > On Thu, 2 Mar 2023 11:05:26 +0800, Jason Wang <jasowang at redhat.com> wrote: > > > On Thu, Mar 2, 2023 at 10:24?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > > > On Tue, 28 Feb 2023 1...

On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" <mst at redhat.com> wrote: > > On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > > > On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig <hch at infradead.org...

...y: Jason Wang <jasowang at redhat.com> > Signed-off-by: Eli Cohen <elic at nvidia.com> I have a question. Could you guys try with the recent XDP mergeable buffer rework? Does this address the performance issue you are observing? Specifically: Message-Id: <20230322025701.2955-1-xuanzhuo at linux.alibaba.com> Message-Id: <20230322030308.16046-1-xuanzhuo at linux.alibaba.com> I would very much appreciate if you posted perf numbers in response to that thread - both to help evaluate that patchset and this one. Thanks! > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 ++...

On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote: > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > > > > On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig <hch a...

On Thu, 2 Mar 2023 11:05:26 +0800, Jason Wang <jasowang at redhat.com> wrote: > On Thu, Mar 2, 2023 at 10:24?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > On Tue, 28 Feb 2023 19:15:23 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > On Tue, 21 Feb 2023 09:51:07 +0800, Jason Wang <jasowang at redhat.com> wrote: > > > > On Mon, Feb 20, 2023 at 3:02 PM Xuan...

On Thu, Mar 2, 2023 at 10:24?AM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Tue, 28 Feb 2023 19:15:23 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Tue, 21 Feb 2023 09:51:07 +0800, Jason Wang <jasowang at redhat.com> wrote: > > > On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo <xuanzhuo a...

On Tue, 28 Feb 2023 19:15:23 +0800, Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > On Tue, 21 Feb 2023 09:51:07 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > On Mon, 20 Feb 2023 13:38:24 +0800, Jason Wang &lt...

On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Mon, 20 Feb 2023 13:38:24 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > Added virtio_dma_map() to map DMA addresses f...

On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Mon, 20 Feb 2023 13:38:24 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > Added virtio_dma_map() to map DMA addresses f...

On Tue, Apr 4, 2023 at 2:55?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Tue, 4 Apr 2023 14:35:05 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Tue, Apr 4, 2023 at 2:22?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > On Tue, 4 Apr 2023 13:04:02 +0800, Jason Wang &...

On Mon, 20 Feb 2023 13:38:20 +0800, Jason Wang <jasowang at redhat.com> wrote: > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > These API has been introduced: > > > > * virtio_dma_need_sync > > * virtio_dma_sync_single_range_for_cpu > > * virtio_dma_sync_single_range_for_device > > What's the advantages of exporting internal logic like &gt...

On Tue, Apr 4, 2023 at 2:22?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > On Tue, 4 Apr 2023 13:04:02 +0800, Jason Wang <jasowang at redhat.com> wrote: > > On Mon, Apr 3, 2023 at 12:17?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > On Mon, 3 Apr 2023 10:43:03 +0800, Jason Wang...

...ant to introduce a new similar code. In this way, I can reuse these codes in the future. This patches are developed on the top of another patch set[1]. I may have to wait to merge this. So this patch set is a RFC. Please review. Thanks. [1]. https://lore.kernel.org/netdev/20230315015223.89137-1-xuanzhuo at linux.alibaba.com/ Xuan Zhuo (8): virtio_net: mergeable xdp: put old page immediately virtio_net: mergeable xdp: introduce mergeable_xdp_prepare virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp virtio_net: separate the logic of freeing xdp shinfo virtio...

On Tue, Mar 28, 2023 at 8:04?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > In the xdp implementation of virtio-net mergeable, it always checks > whether two page is used and a page is selected to release. This is > complicated for the processing of action, and be careful. > > In the entire process, we have such princip...

## About DMA APIs Now, virtio may can not work with DMA APIs when virtio features do not have VIRTIO_F_ACCESS_PLATFORM. 1. I tried to let DMA APIs return phy address by virtio-device. But DMA APIs just work with the "real" devices. 2. I tried to let xsk support callballs to get phy address from virtio-net driver as the dma address. But the maintainers of xsk may want to use

...ZE -VIRTIO_XDP_HEADROOM). Then the memcpy will overflow. And this is completely possible, as long as the MTU is large, such as 4096. In our test environment, this will cause crash. Since crash is caused by the written memory, it is meaningless, so I do not include it. Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com> --- drivers/net/virtio_net.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2396c28c0122..ea1bd4bb326d 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -814,8 +814...

On Tue, 4 Apr 2023 13:04:02 +0800, Jason Wang <jasowang at redhat.com> wrote: > On Mon, Apr 3, 2023 at 12:17?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > On Mon, 3 Apr 2023 10:43:03 +0800, Jason Wang <jasowang at redhat.com> wrote: > > > On Tue, Mar 28, 2023 at 8:04?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote: > > > > > > > > At present, we have t...

## About DMA APIs Now, virtio may can not work with DMA APIs when virtio features do not have VIRTIO_F_ACCESS_PLATFORM. 1. I tried to let DMA APIs return phy address by virtio-device. But DMA APIs just work with the "real" devices. 2. I tried to let xsk support callballs to get phy address from virtio-net driver as the dma address. But the maintainers of xsk may want to use