search for: xf86handlecolormap

...] Fix colormap handling at screen depth > 30. > Message-ID: > <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> > Content-Type: text/plain; charset="UTF-8" > > NVLoadPalette is pretty hard-coded to 256. I haven't looked at what > all xf86HandleColormaps does, but it seems pretty suspicious. Also It's also pretty dead :). NVLoadPalette is not ever used, because nouveau hooks up the .gamma_set function in xf86CrtcFuncsRec, so xf86HandleColormaps ignores the NVLoadPalette pointer. Iow. dead code that can be removed. I'll send some follow...

...ions(-) diff --git a/src/nv_driver.c b/src/nv_driver.c index 32062eb..4fcd4c1 100644 --- a/src/nv_driver.c +++ b/src/nv_driver.c @@ -1568,8 +1568,8 @@ NVScreenInit(SCREEN_INIT_ARGS_DECL) * Must follow initialization of the default colormap */ if (xf86_config->num_crtc && - !xf86HandleColormaps(pScreen, 256, 8, NVLoadPalette, - NULL, CMAP_PALETTED_TRUECOLOR)) + !xf86HandleColormaps(pScreen, 1 << pScrn->rgbBits, pScrn->rgbBits, + NVLoadPalette, NULL, CMAP_PALETTED_TRUECOLOR)) return FALSE; /* Report any unused options (only for the first generation) */ -- 2...

...t;> 30. >> Message-ID: >> >> <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> >> Content-Type: text/plain; charset="UTF-8" >> >> NVLoadPalette is pretty hard-coded to 256. I haven't looked at what >> all xf86HandleColormaps does, but it seems pretty suspicious. Also > > > It's also pretty dead :). NVLoadPalette is not ever used, because nouveau > hooks up the .gamma_set function in xf86CrtcFuncsRec, so xf86HandleColormaps > ignores the NVLoadPalette pointer. Iow. dead code that can be removed. I...

...gt; Message-ID: >>> >>> <CAKb7UvhnUF6W41vXHpC+Q+jVSROgnHuxd8CzvfOGHmYSq_xTHQ at mail.gmail.com> >>> Content-Type: text/plain; charset="UTF-8" >>> >>> NVLoadPalette is pretty hard-coded to 256. I haven't looked at what >>> all xf86HandleColormaps does, but it seems pretty suspicious. Also >> >> >> It's also pretty dead :). NVLoadPalette is not ever used, because nouveau >> hooks up the .gamma_set function in xf86CrtcFuncsRec, so xf86HandleColormaps >> ignores the NVLoadPalette pointer. Iow. dead code that...

...rk, and with measurement equipment to make sure identity gamma ramps actually are identity mappings at the output. v2: Also deal with X-Server 1.19 and earlier, which as of v1.19.6 lack a fix to color palette handling and can not deal with depths/bpc > 24/8 bpc. On < 1.20 we skip xf86HandleColormaps() setup at > 8 bpc. This disables color palette handling on such servers at > 8 bpc, but still keeps RandR gamma table handling intact. Tested on 1.19.6 and 1.20.0 to do the right thing. Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com> --- src/nv_driver.c | 1...

On 03/03/2018 12:59 AM, Ilia Mirkin wrote: > On Fri, Mar 2, 2018 at 6:46 PM, Mario Kleiner > <mario.kleiner.de at gmail.com> wrote: >> On 03/02/2018 11:29 PM, Ilia Mirkin wrote: >>> OK, so even if you're passing 1024 to xf86HandleColormaps, gamma_set >>> still only gets called with a 256-entry LUT? If so, that works nicely >>> here, but is not intuitive :) >> >> Yes. Lots of remapping in the server, i get dizzy everytime i look at it, >> and forget almost immediately how stuff fits together when i...

...n wrote: >>> >>> On Fri, Mar 2, 2018 at 6:46 PM, Mario Kleiner >>> <mario.kleiner.de at gmail.com> wrote: >>>> >>>> On 03/02/2018 11:29 PM, Ilia Mirkin wrote: >>>>> >>>>> OK, so even if you're passing 1024 to xf86HandleColormaps, gamma_set >>>>> still only gets called with a 256-entry LUT? If so, that works nicely >>>>> here, but is not intuitive :) >>>> >>>> >>>> Yes. Lots of remapping in the server, i get dizzy everytime i look at it, >>>> and...

On Fri, Mar 2, 2018 at 6:46 PM, Mario Kleiner <mario.kleiner.de at gmail.com> wrote: > On 03/02/2018 11:29 PM, Ilia Mirkin wrote: >> OK, so even if you're passing 1024 to xf86HandleColormaps, gamma_set >> still only gets called with a 256-entry LUT? If so, that works nicely >> here, but is not intuitive :) > > Yes. Lots of remapping in the server, i get dizzy everytime i look at it, > and forget almost immediately how stuff fits together when i don't look at &...

...03/2018 12:59 AM, Ilia Mirkin wrote: >> >> On Fri, Mar 2, 2018 at 6:46 PM, Mario Kleiner >> <mario.kleiner.de at gmail.com> wrote: >>> >>> On 03/02/2018 11:29 PM, Ilia Mirkin wrote: >>>> >>>> OK, so even if you're passing 1024 to xf86HandleColormaps, gamma_set >>>> still only gets called with a 256-entry LUT? If so, that works nicely >>>> here, but is not intuitive :) >>> >>> >>> Yes. Lots of remapping in the server, i get dizzy everytime i look at it, >>> and forget almost immediate...

...numColors=256, indices=0xbb611c00, colors=0xbb649800, pVisual=0xbb62f5b0) at nv_driver.c:1890 #7 0x080b4962 in CMapRefreshColors (pmap=0xbb6b6000, defs=256, indices=0xbb611c00) at xf86cmap.c:644 #8 0x080b4ddc in CMapReinstallMap (pmap=0xbb6b6000) at xf86cmap.c:517 #9 0x080b5db9 in xf86HandleColormaps (pScreen=0xbb6344e0, maxColors=256, sigRGBbits=8, loadPalette=0xbb5d018c <NVLoadPalette>, setOverscan=0, flags=<value optimized out>) at xf86cmap.c:216 #10 0xbb5d2a89 in NVScreenInit (scrnIndex=0, pScreen=0xbb6344e0, argc=9, argv=0xbfbfe978) at nv_driver.c:2246 #11 0x080...

...t;>>> On Fri, Mar 2, 2018 at 6:46 PM, Mario Kleiner >>>> <mario.kleiner.de at gmail.com> wrote: >>>>> >>>>> On 03/02/2018 11:29 PM, Ilia Mirkin wrote: >>>>>> >>>>>> OK, so even if you're passing 1024 to xf86HandleColormaps, gamma_set >>>>>> still only gets called with a 256-entry LUT? If so, that works nicely >>>>>> here, but is not intuitive :) >>>>> >>>>> >>>>> Yes. Lots of remapping in the server, i get dizzy everytime i look at it,...

...akim Tjernlund (1): Fix non GLAMOR build Keith Packard (2): modesetting: Skip no-longer-present connectors when resetting BAD links modesetting: Update property values at detect and uevent time Mario Kleiner (5): Define per x-screen individual drmmode_crtc_funcs Skip xf86HandleColormaps() at color depth 30. (v2) Support exa screen color depth 30 on Linux 3.16 and later. (v2) Add missing depth 30 -> cpp=4 handling for DRI2. Make XvMC extension initialize at depth 30. Michel Dänzer (23): Fix VT switching with ShadowFB Post-release version bump...

...& !nouveau_exa_init(pScreen)) @@ -1441,19 +1587,19 @@ NVScreenInit(SCREEN_INIT_ARGS_DECL) * Initialize colormap layer. * Must follow initialization of the default colormap */ - if (xf86_config->num_crtc && + if (!xorgMir && xf86_config->num_crtc && !xf86HandleColormaps(pScreen, 256, 8, NVLoadPalette, NULL, CMAP_PALETTED_TRUECOLOR)) - return FALSE; /* Report any unused options (only for the first generation) */ if (serverGeneration == 1) xf86ShowUnusedOptions(pScrn->scrnIndex, pScrn->options); - if (xf86_config->num_crtc) + if (!xorgMir...

http://bugs.freedesktop.org/show_bug.cgi?id=18286 Summary: GeForce 8300 not supported (10de:0848/C77/MCP77) Product: xorg Version: 7.4 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org

...depth 30. glamor: Fix loose ends in color depth 30 support. glamor: Enable composite acceleration for rgb10 formats. (v2) glamor: Bump version to 1.0.1 to signal depth 30 support. xfree86/modes: Adapt xf86Randr12CrtcComputeGamma() for depth 30. (v2) modesetting: Adapt xf86HandleColorMaps() for > 24 color depth. (v2) modesetting: Enable screen color depth 30 support. Mariusz Bialonczyk (1): configure.ac: fix checking for libdrm version after 9232835bd Martin Peres (2): tests: shuffle around the linking order to please GNU ld modesetting: re-set the crtc...