search for: write_size

Hi, On systems with HAVE_SETATTRLIST, commit b936741 breaks compilation. This is because do_setattrlist_times hasn't been converted to STRUCT_STAT *stp. Here's a small patch to do it. Cheers, Filipe PS: I've been playing with IO_BUFFER_SIZE, MAX_MAP_SIZE and WRITE_SIZE. Any plans to make it configurable at runtime? It seems to make a big difference for large files on a fast link (about 5x in my case) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.samba.org/pipermail/rsync/attachments/20200425/72421087/attachment.h...

In looking at source, I started at fileio and found write routines but no read routines. I found a 'WRITE_SIZE' (32K), but no 'READ_SIZE' -- is that' what the MAX_MAP_SIZE (256K)? I would like to make so that rsync can use larger I/O sizes if (maybe a command line option?).... The map routine led me to receiver -- where it looks like it is responsible for reading the file. A comment says:...

I'm transferring 1.1 Mb files over very poor GSM EDGE connection. My rsync command is: rsync --partial --remove-source-files --timeout=120 --append --progress --rsh=ssh -z LOCAL_FILE root at SERVER:REMOTE_PATH File on remote server "grows" in size in steps of 262144 bytes. That is a lot, because system needs to transfer at least 262144 (before compression) every time connection

https://bugzilla.samba.org/show_bug.cgi?id=8512 Summary: rsync -a slower than cp -a Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: core AssignedTo: wayned at samba.org ReportedBy: linux.news at bucksch.org QAContact:

...ls. #5 0x080d6c39 in i_panic ( format=0xb7e3cf50 "file %s: line %d (%s): assertion failed: (%s)") at failures.c:197 No locals. #6 0xb7e39a82 in uidlist_write_array (output=0x965c9bc, uid_list=0xb79cae0c, uid_count=31, packed_flags=<value optimized out>, offset=0, write_size=true, size_r=0xbfa0ddd8) at squat-uidlist.c:153 uidbuf = (uint8_t *) 0x96117b8 "?\030=" bufp = (uint8_t *) 0x96117ba "=" sizebuf = "?h???" sizebufp = <value optimized out> listbuf = "?????" listbufp = (uint8_t *) 0xbfa0dd52 "??????h???????&qu...

Attached is a patch that makes window strides constant when files are walked with a constant block size. In these cases, it completely avoids all memmoves. In my simple local test of rsyncing 57MB of 10 local files, memmoved bytes went from 18MB to zero. I haven't tested this for a big variety of file cases. I think that this will always reduce the memmoves involved with walking a large