Hi, On systems with HAVE_SETATTRLIST, commit b936741 breaks compilation. This is because do_setattrlist_times hasn't been converted to STRUCT_STAT *stp. Here's a small patch to do it. Cheers, Filipe PS: I've been playing with IO_BUFFER_SIZE, MAX_MAP_SIZE and WRITE_SIZE. Any plans to make it configurable at runtime? It seems to make a big difference for large files on a fast link (about 5x in my case) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.samba.org/pipermail/rsync/attachments/20200425/72421087/attachment.htm> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Update-do_setattrlist_times-to-use-the-new-STRUCT_ST.patch Type: application/octet-stream Size: 1543 bytes Desc: not available URL: <http://lists.samba.org/pipermail/rsync/attachments/20200425/72421087/0001-Update-do_setattrlist_times-to-use-the-new-STRUCT_ST.obj>
This has now been fixed by 1c7785a. On Sat, 25 Apr 2020 at 23:53, Filipe Maia <filipe.c.maia at gmail.com> wrote:> Hi, > > On systems with HAVE_SETATTRLIST, commit b936741 breaks compilation. > This is because do_setattrlist_times hasn't been converted to STRUCT_STAT > *stp. > Here's a small patch to do it. > > Cheers, > Filipe > > PS: I've been playing with IO_BUFFER_SIZE, MAX_MAP_SIZE and WRITE_SIZE. > Any plans to make it configurable at runtime? It seems to make a big > difference for large files on a fast link (about 5x in my case) >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.samba.org/pipermail/rsync/attachments/20200427/5aac66d3/attachment.htm>