search for: with_zlib

...ude "sshbuf.h" #include "ssherr.h" #include "digest.h" +#include "kex.h" #include "openbsd-compat/openssl-compat.h" @@ -142,12 +143,33 @@ cipher_alg_list(char sep, int auth_only) const char * compression_alg_list(int compression) { -#ifdef WITH_ZLIB - return compression ? "zlib at openssh.com,zlib,none" : - "none,zlib at openssh.com,zlib"; +#ifdef HAVE_LIBZSTD +#define COMP_ZSTD_WITH "zstd at breakpoint.cc," +#define COMP_ZSTD_NONE ",zstd at breakpoint.cc" #else - return "none"; +#define C...

I added ZSTD support to OpenSSH roughly three years ago and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port

I hacked zstd support into OpenSSH a while ago and just started to clean it up in the recent days. The cleanup includes configuration support among other things that I did not have. During testing I noticed the following differences compared to zlib: - highly interactive shell output (as in refreshed at a _very_ high rate) may result in higher bandwidth compared to zlib. Since zstd is quicker

I added ZSTD support to OpenSSH roughly over a year and I've been playing with it ever since. The nice part is that ZSTD achieves reasonable compression (like zlib) but consumes little CPU so it is unlikely that compression becomes the bottle neck of a transfer. The compression overhead (CPU) is negligible even when uncompressed data is tunneled over the SSH connection (SOCKS proxy, port

...const struct sshcipher *); u_int cipher_authlen(const struct sshcipher *); diff --git a/packet.c b/packet.c index a71820f..377f608 100644 --- a/packet.c +++ b/packet.c @@ -55,6 +55,7 @@ #include <poll.h> #include <signal.h> #include <time.h> +#include <util.h> #ifdef WITH_ZLIB #include <zlib.h> @@ -850,6 +851,7 @@ ssh_set_newkeys(struct ssh *ssh, int mode) const char *wmsg; int r, crypt_type; const char *dir = mode == MODE_OUT ? "out" : "in"; + char blocks_s[FMT_SCALED_STRSIZE], bytes_s[FMT_SCALED_STRSIZE]; debug2_f("mode %d&quot...

...quot; ( ( ( ( ( L. Gonick & W. Smith (1993) ) ) ) ) ) ....................................................................... === my configure.in ================= AC_INIT(DESCRIPTION) AC_PROG_CC AC_ARG_WITH(zlib, --with-zlib=/XTRA/hdf5) if test -n "$with_zlib"; then ZLIBLDFLAGS=-L${with_zlib}/lib ZLIBCPPFLAGS=-I${with_zlib}/include fi AC_ARG_WITH(hdf5, --with-hdf5=/XTRA/hdf5) if test -n "$with_hdf5"; then HDF5LDFLAGS=-L${with_hdf5}/lib HDF5CPPFLAGS=-I${with_hdf5}/include fi LIBS=-lm CPPFLAGS="$ZLIBCPPFLAGS $HDF5CPPFLAGS $...

...seclen(const struct sshcipher *); u_int cipher_authlen(const struct sshcipher *); diff --git a/packet.c b/packet.c index a71820f..377f608 100644 --- a/packet.c +++ b/packet.c @@ -55,6 +55,7 @@ #include <poll.h> #include <signal.h> #include <time.h> +#include <util.h> #ifdef WITH_ZLIB #include <zlib.h> @@ -850,6 +851,7 @@ ssh_set_newkeys(struct ssh *ssh, int mode) const char *wmsg; int r, crypt_type; const char *dir = mode == MODE_OUT ? "out" : "in"; + char blocks_s[FMT_SCALED_STRSIZE], bytes_s[FMT_SCALED_STRSIZE]; debug2_f("mode %d", mode);...

...const struct sshcipher *); > diff --git a/packet.c b/packet.c > index a71820f..377f608 100644 > --- a/packet.c > +++ b/packet.c > @@ -55,6 +55,7 @@ > #include <poll.h> > #include <signal.h> > #include <time.h> > +#include <util.h> > > #ifdef WITH_ZLIB > #include <zlib.h> > @@ -850,6 +851,7 @@ ssh_set_newkeys(struct ssh *ssh, int mode) > const char *wmsg; > int r, crypt_type; > const char *dir = mode == MODE_OUT ? "out" : "in"; > + char blocks_s[FMT_SCALED_STRSIZE], bytes_s[FMT_SCALED_STRSIZE]; > &g...

...plugin). +dnl Check for zlib (only if you want to compile the gzip filter). AC_ARG_WITH([zlib], [AS_HELP_STRING([--without-zlib], - [disable gzip plugin @<:@default=check@:>@])], + [disable gzip filter @<:@default=check@:>@])], [], [with_zlib=check]) AS_IF([test "$with_zlib" != "no"],[ @@ -911,7 +912,7 @@ AS_IF([test "$with_zlib" != "no"],[ AC_SUBST([ZLIB_LIBS]) AC_DEFINE([HAVE_ZLIB],[1],[zlib found at compile time.]) ], - [AC_MSG_WARN([zlib >= 1.2.3.5 not found, gzip...

I was wondering if there was something specific to the internal chacha20 cipher as opposed to OpenSSL implementation. I can't just change the block size because it breaks compatibility. I can do something like as a hack (though it would probably be better to do it with the compat function): if (strstr(enc->name, "chacha")) *max_blocks = (u_int64_t)1 << (16*2);

...(const struct sshcipher *); > diff --git a/packet.c b/packet.c > index a71820f..377f608 100644 > --- a/packet.c > +++ b/packet.c > @@ -55,6 +55,7 @@ > #include <poll.h> > #include <signal.h> > #include <time.h> > +#include <util.h> > > #ifdef WITH_ZLIB > #include <zlib.h> > @@ -850,6 +851,7 @@ ssh_set_newkeys(struct ssh *ssh, int mode) > const char *wmsg; > int r, crypt_type; > const char *dir = mode == MODE_OUT ? "out" : "in"; > + char blocks_s[FMT_SCALED_STRSIZE], bytes_s[FMT_SCALED_STRSIZE]; > &gt...

...ine PACKAGE_NAME "OpenSSH" | #define PACKAGE_TARNAME "openssh" | #define PACKAGE_VERSION "Portable" | #define PACKAGE_STRING "OpenSSH Portable" | #define PACKAGE_BUGREPORT "openssh-unix-dev at mindrot.org" [...] | #define HAVE_BASENAME 1 | #define WITH_ZLIB 1 | #define HAVE_LIBZ 1 | /* end confdefs.h. */ | | #include <stdio.h> | #include <stdlib.h> | #include <zlib.h> | | int | main (void) | { | | int a=0, b=0, c=0, d=0, n, v; | n = sscanf(ZLIB_VERSION, "%d.%d.%d.%d", &a, &b, &c, &d); |...

v2: - Fixes a number of bugs in corner cases. - Uses a 1M block size to fetch from the underlying plugin. This improves performance considerably. I also tested this much more thoroughly and can't find any more bugs. Rich.

...c | 1367 ---------------------------------- 4 files changed, 17 insertions(+), 1405 deletions(-) delete mode 100644 plugins/nbd/nbd-standalone.c diff --git a/configure.ac b/configure.ac index f28eb43f..3024a2c8 100644 --- a/configure.ac +++ b/configure.ac @@ -838,10 +838,10 @@ AS_IF([test "$with_zlib" != "no"],[ ]) AM_CONDITIONAL([HAVE_ZLIB],[test "x$ZLIB_LIBS" != "x"]) -dnl Check for libnbd (only if you want to compile the full nbd plugin). +dnl Check for libnbd (only if you want to compile the nbd plugin). AC_ARG_WITH([libnbd], [AS_HELP_STRING([--wi...

Matt asked if xz should really be a filter rather than a plugin. The answer is yes, of course it should be! That's been something in the todo file for a while. The commit converts the xz plugin code into a filter (leaving the plugin around, but deprecating it). plugin: nbdkit xz file.xz filter: nbdkit --filter=xz file file.xz plugin: # can't be done filter: nbdkit

Patch 1 played with an early draft of Rich's Fedora 30 libnbd package: https://bugzilla.redhat.com/show_bug.cgi?id=1713767#c17 Note that comment 21 provides a newer package 0.1.1-1 with a different API; and that libnbd has more unreleased API changes in the pipeline (whether that will be called 0.2 or 0.1.2); so we'll have to tweak things based on what is actually available in distros.

libnbd-0.1.2-1 is now available in Fedora 29/30 updates-testing, although it was not compiled against libxml2 so it lacks uri support (I ended up testing patch 4 with a self-built libnbd). Diffs since v1 - rebase to master, bump from libnbd 0.1 to 0.1.2, add URI support, better timing results Still not done - patch 5 needs associated tests Eric Blake (5): nbd: Check for libnbd nbd:

libnbd-0.1.4-1 is now available in Fedora 29/30 updates testing. Diffs since v2 - rebase to master, bump from libnbd 0.1.2 to 0.1.3+, add tests to TLS usage which flushed out the need to turn relative pathnames into absolute, doc tweaks Now that the testsuite covers TLS and libnbd has been fixed to provide the things I found lacking when developing v2, I'm leaning towards pushing this on