search for: win_utf8_io_stat

All MSVC projects that generate .lib files have '_static' suffix in their names; all but win_utf8_io. This patch renames it so that it follows this naming convention. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_static.patch Type: application/octet-stream Size: 9097 bytes Desc: not available Url :

For some reasons libFLAC_dynamic, libFLAC++_dynamic and libFLAC++_static projects depend on win_utf8_io_static project, but there's no such dependency for libFLAC_static project. The patch adds such dependency. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_dependency.patch Type: application/octet-stream Size: 1484 bytes Desc: not available Url : http://l...

...Also I noticed that all projects with '_static' suffix produce static library files (*.lib), projects with '_dynamic' suffix produce dynamic library files (*.dll), and projects without suffixes produce executables (*.exe). The only exception is win_utf8_io. Should it be renamed to win_utf8_io_static?

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

...dynamic.dll, and > none of them contain win_utf8_io stuff. I was wrong. In Visual Studio, 'flac' project depends on 'libFLAC_static' project and all the projects from src/share: getopt_static, grabbag_static, replaygain_analysis_static, replaygain_synthesis_static, utf8_static, win_utf8_io_static Both 'libFLAC_static' and 'libFLAC_dynamic' projects depend (only) on 'win_utf8_io_static'. I tried to remove this dependency and libFLAC_dynamic failed to compile since metadata_iterators.c uses e.g. flac_fopen, which is defined in share/compat.h as fopen_utf8. metad...

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.

...at is linked to thr libFLAC DLL file, but it requires manual editing of various projects in the FLAC solution. is this configuration supported? I ask because such configuration breaks support of non-ASCII filenames. Both flac.exe and libFLAC_dynamic.dll were staically linked to different copies of win_utf8_io_static.lib, then flac.exe sets its copy of win_utf8_io_codepage variable to CP_UTF8, and the copy of this variable inside libFLAC_dynamic.dll is always equal to CP_ACP. As a result flac sends UTF8-encoded strings to libFLAC, and libFLAC treats them as ANSI-encoded.