search for: win_utf8_io

Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote: > --- > src/share/win_utf8_io/win_utf8_io.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/share/win_utf8_io/win_utf8_io.c > b/src/share/win_utf8_io/win_utf8_io.c > index c61d27f3..1437b41e 100644 > --- a/src/share/win_utf8_io/win_utf8_io.c > +++ b/src/share/win_utf8_io/win_utf8_io....

...that CreateFile function in grabbag had been left out of UTF-8 treatment at some point. This causes re-encoding an existing flac to the same name to break the file if it contains non-ascii characters. Attached patch fixes this. -------------- next part -------------- diff --git a/include/share/win_utf8_io.h b/include/share/win_utf8_io.h index b48e85e..b689db0 100644 --- a/include/share/win_utf8_io.h +++ b/include/share/win_utf8_io.h @@ -10,7 +10,7 @@ extern "C" { #include <stdio.h> #include <sys/stat.h> #include <stdarg.h> - +#include <windows.h> int get_utf8_...

...----------- | Program | <----------> | libFLAC | ------------- UTF-8 ----------- ^ ^ ^ | | UTF-8 | UTF-8 | v v | --------------------------------- | | win_utf8_io | | --------------------------------- | ^ | | UTF-16 v v -------------------------------------- | Windows | -------------------------------------- (BTW, a 'Program' here...

...o do it. Please let me know what you think! Regards, Hugo Beauzée-Luyssen (5): configure.ac: Allow the programs to be disabled configure.ac: Allow bench to be disabled configure.ac: Don't build any tests when they are explicitely disabled configure.ac: Allow examples to be disabled win_utf8_io: Avoid forbidden functions when building for WinRT/UWP configure.ac | 10 ++++++++++ examples/Makefile.am | 2 ++ microbench/Makefile.am | 4 ++++ src/Makefile.am | 10 +++++++--- src/flac/Makefile.am | 13 +++...

Currently it is required to include share/compat.h before inclusion of share/win_utf8_io.h. That's because of print_console() declaration: its 3rd argument have type 'uint32_t' which is defined in share/compat.h. So share/win_utf8_io.h depends on share/compat.h which in turn includes share/win_utf8_io.h. Not a problem but it's a bit ugly imho. Actually, the 3rd argume...

Hi all, I tried building the latest flac.git on Windows with MinGW just today, and got the following build error: (I had to copy-paste this 'by hand', so there might be a few small mistakes) > CCLD utf8/libutf8.la > CC win_utf8_io/win_utf8_io.lo > win_utf8__io/win_utf8_io.c:266:13: error: static declaration > of 'set_filename_utf8' follows non-static declaration > static void set_filename_utf8(int b) > ^ > win_utf8__io/win_utf8_io.c:106:6: note: previous declaration > of 'set_fil...

...t from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes the problem for the >>>> Makefile.lite and Visual Studio build systems without moving >>>> win_utf8_io.c or touching the Autotools system. >> >> When I compile flac project with MSYS/MinGW-w64, I can see two files: >> libFLAC.a and libFLAC-static.a. The only difference between them >> is that libFLAC.a contains functions from win_utf8_io. >> But 'make install' a...

I noticed that share/win_utf8_io.h includes windows.h anyway, so another include in win_utf8_io.c is unnecessary. Also, the comment there is incorrect. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_io.patch Type: application/octet-stream Size: 423 bytes Desc: not available Url : http...

...ther programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >> Makefile.lite and Visual Studio build systems without moving >> win_utf8_io.c or touching the Autotools system. >> >> -Evan When I compile flac project with MSYS/MinGW-w64, I can see two files: libFLAC.a and libFLAC-static.a. The only difference between them is that libFLAC.a contains functions from win_utf8_io. But 'make install' adds libFLAC.a into...

So far I can see three ideal solutions of this issue: 1) Make Unicode support a part of the libFLAC API. In this case there will be no need in separate -lFLAC -lwin_utf8_io options, just -lFLAC will be needed. 2) Remove the dependency between libFLAC and win_utf8_io. In this case win_utf8_io will be linked statically to 1st-party apps, like other libraries from src/share: getopt, grabbag, ... 3) Leave it as is. The first solution: It's not f...

lvqcl wrote: > all I can suggest > is to apply this patch, then fix issues if they'll happen after > this. But seriously, as a matter of fact win_utf8_io is a part of libFLAC. Functions from libFLAC call functions from win_utf8_io... For example: FLAC__stream_decoder_init_file() calls init_file_internal_() that calls flac_fopen() that is defined as fopen_utf8(). Currently functions in win_utf8_io.c are a compatibility layer for libFLAC. I can'...

...RN wrote: > On 01.04.2013 14:40, Erik de Castro Lopo wrote: >> Hi all, > >> The latest pre-release is here: > >> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz > >> > flac-1.3.0pre3/include/share/compat.h:146:31: fatal error: > share/win_utf8_io.h: No such file or directory > OK, i downloaded that one from git, now i get a different problem: flac-1.3.0pre3/include/share/win_utf8_io.h:23:43: warning: 'struct _stat64' declared inside parameter list [enabled by default] flac-1.3.0pre3/include/share/win_utf8_io.h:23:43: warning: it...

This patch changes win_utf8_io.c: simplifies *print functions, improves file related functions and prepates to move all file related functions into libFLAC. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_io.patch Type: application/octet-stream Size: 14476 bytes Desc: not available Ur...

The set of four patches that remove dependency of libFLAC on win_utf8_io. Tested only on Windows, with MSVC and MSYS/MinGW (both autotools and makefile.lite) Please review, especially makefile patches, I'm not very familiar with them. -------------- next part -------------- A non-text attachment was scrubbed... Name: 1_sources.zip Type: application/zip Size: 3524...

All MSVC projects that generate .lib files have '_static' suffix in their names; all but win_utf8_io. This patch renames it so that it follows this naming convention. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_static.patch Type: application/octet-stream Size: 9097 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/...

lvqcl wrote: > IIRC libFLAC.a built with "./autogen.sh && ./configure && make" > contains all functions from win_utf8_io. So I think it's possible > to change some Makefile.lite or maybe build/*.mk files so that > there will be no need to add -lwin_utf8_io to -lFLAC. Version 2 of my patch attached, which fixes the problem for the Makefile.lite and Visual Studio build systems without moving win_utf8_io.c or...

lvqcl wrote: > Then IMHO all three build systems (configure && make, Makefile.lite > and MSVC) should be synchronized with each other +1 > TO ERIK: > > I have some patches, but they either modify MSVC .vcxproj files, > or win_utf8_io.c/.h, so they conflict with patches from Evan Ramos. > So should they be applied? rejected? postponed until after flac 1.3.2? We should figure out the bext way to get them appled. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.meg...

Erik de Castro Lopo wrote: >> Currently functions in win_utf8_io.c are a compatibility layer for >> libFLAC. I can't see reasons not to move win_utf8_io.c into libFLAC. > > Ok, lets do it. I just thought that it's more complicated. All *file* functions should really be moved to libFLAC. But other functions should not, because libFLAC doesn...

...#39;t use MSVCRT. Therefore, compiling on mingw with -D__USE_MINGW_ANSI_STDIO=1 and redirecting stderr to a file, the printing result is corrupt. We should use fputws simply. A patch is attached. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-win_utf8_io.c-Use-fputws-instead-of-fwprintf.patch Type: application/octet-stream Size: 823 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140913/f1410d7a/attachment.obj

...* filename argument into #ifndef FLAC__FILENAME_API_DISABLED ... #endif and maybe also all functions that take FILE* argument into #ifndef FLAC__FILEPTR_API_DISABLED ... #endif Then try to compile flac.exe/metaflac.exe/etc with -DFLAC__FILENAME_API_DISABLED. When it's done, remove win_utf8_io dependency from libFLAC.