lvqcl wrote:> IIRC libFLAC.a built with "./autogen.sh && ./configure && make" > contains all functions from win_utf8_io. So I think it's possible > to change some Makefile.lite or maybe build/*.mk files so that > there will be no need to add -lwin_utf8_io to -lFLAC.Version 2 of my patch attached, which fixes the problem for the Makefile.lite and Visual Studio build systems without moving win_utf8_io.c or touching the Autotools system. -Evan -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_io library fix.patch Type: application/octet-stream Size: 57956 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20160108/25f391cf/attachment-0001.obj
Win_utf8 stuff should not be included in libflac since it's only to be used by the flac.exe frontend. It is not needed by other programs nor would they benefit from it without doing the extra work of converting their ansi filenames and functions to utf-8. -- Janne On 9.1.2016 5.08, Evan Ramos wrote:> lvqcl wrote: > >> IIRC libFLAC.a built with "./autogen.sh && ./configure && make" >> contains all functions from win_utf8_io. So I think it's possible >> to change some Makefile.lite or maybe build/*.mk files so that >> there will be no need to add -lwin_utf8_io to -lFLAC. > Version 2 of my patch attached, which fixes the problem for the > Makefile.lite and Visual Studio build systems without moving > win_utf8_io.c or touching the Autotools system. > > -Evan > > > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20160109/102949ce/attachment.htm
Janne Hyv?rinen wrote:> Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >> Makefile.lite and Visual Studio build systems without moving >> win_utf8_io.c or touching the Autotools system. >> >> -EvanWhen I compile flac project with MSYS/MinGW-w64, I can see two files: libFLAC.a and libFLAC-static.a. The only difference between them is that libFLAC.a contains functions from win_utf8_io. But 'make install' adds libFLAC.a into /local/lib, not libFLAC-static.a.