search for: webrev

Displaying 18 results from an estimated 18 matches for "webrev".

Did you mean: webdev
2008 Oct 14
6
code review for 6734731 and 6734123
I''d like reviewers for: 6734731 vif-vnic instances can race against each other 6734123 xpvd-event logging is dismal The webrev is at http://dme.org/solaris/webrev/xvm-script-cleanup.
2012 Oct 17
24
[zfs] portable zfs send streams (preview webrev)
We have finished a beta version of the feature. A webrev for it can be found here: http://cr.illumos.org/~webrev/sensille/fits-send/ It adds a command ''zfs fits-send''. The resulting streams can currently only be received on btrfs, but more receivers will follow. It would be great if anyone interested could give it some testing and/or...
2008 Apr 01
10
Request for code review: the brendan() action
...-------------------------------------------------------------------- with the resulting output: ------------------------------------------------------------------------ Tracing... Hit Ctrl-C to end. ------------------------------------------------------------------------ I''ve put up a webrev for this at the following URL: http://cr.opensolaris.org/~cmynhier/brendan/ [1] http://www.brendangregg.com/dtrace.html
2008 Jun 18
6
Please advise: sending out bogus gratuitous ARP packet from vna
I''ve implemented code to send out bogus gratuitous ARP packet from vna in order to fix CR 6701114. The webrev is at: http://jurassic.eng/net/consulte.prc/export/build/xvm-6701114/webrev Some backgroud information (see CR 6701114 for more detail): During live migration of an xVM domain from one dom0 to another, the VNIC will be moved from one switch port to another. But, the corresponding entry in <MAC...
2008 Aug 04
6
[Fwd: [networking-discuss] code-review: fine-grained privileges for datalink administration]
...Folks, I''m looking for code-reviewers for the following set of changes: PSARC 2008/473 Fine-Grained Privileges for Datalink Administration 6695904 least privileges for datalink actions 6729477 pcwl accidentally requires privileges for WLAN_GET_PARAM ioctl 6679049 ucred_t leak in dlmgmtd Webrev: http://cr.opensolaris.org/~seb/dladm-privs-webrev/ Don''t be put-off by the webrev''s claim of 1800+ lines of changes, as only 800 or so of those lines are modified or new. There are over 1000 lines of deleted code. Workspace with cscope database: /net/zhadum.east/export/ws/se...
2011 Jul 29
12
booting from ashift=12 pool..
.. evidently doesn''t work. GRUB reboots the machine moments after loading stage2, and doesn''t recognise the fstype when examining the disk loaded from an alernate source. This is with SX-151. Here''s hoping a future version (with grub2?) resolves this, as well as lets us boot from raidz. Just a note for the archives in case it helps someone else get back the afternoon
2008 Dec 04
2
Round four: Re: code review req: 6750659 drti.o crashes app due to corrupt environment
I believe that I have incorporated all of the feedback given (thanks!). Changes since the 2008-11-16 version include: - ksh style & coding standards compliance in test script (Roland) - "dof_init_debug == B_FALSE" vs. "!dof_init_debug" (Adam) The updated webrev is at: http://cr.opensolaris.org/~mgerdts/6750659-2008-12-03/ -- Mike Gerdts http://mgerdts.blogspot.com/
2008 Oct 15
0
Code Review for NFS v3 client DTrace provider
Hi, I have got an implementation of DTrace probes for NFS v3 client. Webrev of my change is at: http://cr.opensolaris.org/~danhua/webrev/ The provider and probes are described in attached proposal. Welcome comments! Regards, Danhua -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: proposal-nfsv3client.txt URL: <...
2008 May 07
0
xVM least privilege: please review
See the PSARC case for rationale: http://www.opensolaris.org/jive/thread.jspa?threadID=58816&tstart=30 Review notes: If you haven''t reviewed xVM changes before it''s a bit confusing. Basically the dirs ending in .hg/ are normal webrevs. The ones with other names are webrevs of a particular MQ patch added on top (for virt-install and xen repos). ''solaris-support.diff'' shows the difference between the old and new version of the ''solaris-support'' patch to virt-install. Reminder, you can find the...
2008 Nov 17
0
Overhead evaluation of my nfsv3client probe implementation
Hi, Thanks for the comment for my nfsv3client probe implementation! I have made changes accordingly. Webrev: http://cr.opensolaris.org/~danhua/webrev/ To reduce the overhead, I use a local variable to save XID, rather than alloc memory space with kmem_zalloc(). According to the overhead caused by tsd_get() and tsd_set(), I did an experiment to measure it. In this experiment, I run a dtrace script to...
2008 Sep 11
3
ZFS Crypto [Prelim] Codereview
Here''s my comments for the preliminary ZFS Crypto review. - Dan Webrev: http://cr.opensolaris.org/~darrenm/zfs-crypto-gate/webrev/ General comments: DEA-1 - SCCS keywords need to be removed DEA-2 - Copyright updated ------------------------------------------------------------------ usr/src/lib/libcryptoutil/common/keyfile.c pkcs11_read_data() This code in pkcs11_...
2009 Jun 28
10
pygrub caching issue
https://bugzilla.redhat.com/show_bug.cgi?id=466681 just to be sure that some one in xvm-team notices that before any bits from xvm-gate are putback ;) Florian
2008 Jul 24
5
printa stddev error
Hi, Searched for similar errors and nothing came up. Anybody know what this is? When using aggregate stddev, and then trying to print it at END, using printa, I get this error: dtrace: processing aborted: Invalid return value from callback avg works fine. Tried on two recent builds of solaris (build 89 and build 94), on two difference sparc systems. Here''s a sample script:
2008 Oct 09
11
Crossbow Code Review Phase III ready
...project''s third and last phase of code review. The third phase of the review starts today, and will last for two weeks. It covers the following parts of the code: VLANs Link Aggregations Xen mac_datapath_setup All drivers (excluding e1000g) The webrev is available in http://www.opensolaris.org/os/project/crossbow/Code-review3 Interested? please send the code review comments by October 24th, 2008 Thanks, The Crossbow team.
2009 Nov 06
7
Status of DTrace NFSv3/v4 client providers
We recently had a strange NFS performance anomaly between a V880 running snv_124 and two NetApp filers. To investigate, a DTrace NFSv4 (and eventually NFSv3) client provider would been extremely helpful. Unfortunately, all I could find were a request for code review of a v3 client provider and another request for help developing a v4 provider. Nothing seems to have come from those initiatives,
2007 Nov 05
0
RFC: multicast add/remove for network frontend
...is feature would be controlled using "feature" and "request" flags in xenstore (i.e. the backend would advertise the feature and the frontend would request that it be enabled). Changes to the current OpenSolaris implementation to provide this are at http://dme.org/solaris/webrev/x24, with the changes to the inter- domain protocol expressed in the diffs to netif.h (this is based on 3.0.4-2 at the moment). There''s no requirement to change an implementation other than OpenSolaris with this approach - we''d continue to support frontends that don'...
2009 Apr 06
2
Code review for stopper: 7315 xVM VNC service doesn''t work
http://cr.opensolaris.org/~johnlev/xvm-vnc-chown/ Now Xvnc runs as the ''jack'' user on the live CD, the password file must be owned by jack for it to work. Note that a full fix for this would make this VNC service only exist on the live CD[1]. As a temporary measure, we just disable ourselves post-install. Process question: after putting back to pkg-gate, does this need
2009 Jul 19
7
How xVM is integrated with Crossbow
Hi, all I want to get some information of How xVM is integrated with Crossbow project. Do some buddies have those documents or blogs? Thanks --luke