John Levon
2009-Apr-06 10:25 UTC
Code review for stopper: 7315 xVM VNC service doesn''t work
http://cr.opensolaris.org/~johnlev/xvm-vnc-chown/ Now Xvnc runs as the ''jack'' user on the live CD, the password file must be owned by jack for it to work. Note that a full fix for this would make this VNC service only exist on the live CD[1]. As a temporary measure, we just disable ourselves post-install. Process question: after putting back to pkg-gate, does this need including in a respin gate for 2009.06 or not? Not clear on the dates here. thanks john [1] if someone can tell me how to go about this, I''ll file a lower-priority bug to clean this up post-commit
David.Comay@Sun.COM
2009-Apr-06 15:12 UTC
Re: Code review for stopper: 7315 xVM VNC service doesn''t work
> http://cr.opensolaris.org/~johnlev/xvm-vnc-chown/ > > Now Xvnc runs as the ''jack'' user on the live CD, the password file must > be owned by jack for it to work.Looks good. As this service only makes sense on the Live CD, it might make sense to change the description from "xVM VNC Server" to something like "Live CD xVM VNC Server" or somesuch. Also, I just noticed in vnc-config.xml that the documentation tag refers to Xorg.1 but I assume you meant Xvnc.1.> Process question: after putting back to pkg-gate, does this need > including in a respin gate for 2009.06 or not? Not clear on the dates > here.If you get it in this week, it will be included in our build 3.
John Levon
2009-Apr-06 16:12 UTC
Re: Code review for stopper: 7315 xVM VNC service doesn''t work
On Mon, Apr 06, 2009 at 08:12:11AM -0700, David.Comay@Sun.COM wrote:> >http://cr.opensolaris.org/~johnlev/xvm-vnc-chown/ > > > >Now Xvnc runs as the ''jack'' user on the live CD, the password file must > >be owned by jack for it to work. > > Looks good. As this service only makes sense on the Live CD, it might > make sense to change the description from "xVM VNC Server" to something > like "Live CD xVM VNC Server" or somesuch. > > Also, I just noticed in vnc-config.xml that the documentation tag > refers to Xorg.1 but I assume you meant Xvnc.1.Webrev re-generated. Thanks for the review. regards john