search for: vtotal

...t;>> +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c > > >>> @@ -143,7 +143,6 @@ static const struct versatile_panel_type versatile_panels[] = { > > >>> .vsync_start = 240 + 5, > > >>> .vsync_end = 240 + 5 + 6, > > >>> .vtotal = 240 + 5 + 6 + 5, > > >>> - .vrefresh = 116, > > >> > > >> Are you sure vrefresh calculated (from totals and clock) is different > > >> than this field? If not, we risk regressions. > > >> > > >> This case is OK, but ther...

...-versatile.c > >>> +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c > >>> @@ -143,7 +143,6 @@ static const struct versatile_panel_type versatile_panels[] = { > >>> .vsync_start = 240 + 5, > >>> .vsync_end = 240 + 5 + 6, > >>> .vtotal = 240 + 5 + 6 + 5, > >>> - .vrefresh = 116, > >> > >> Are you sure vrefresh calculated (from totals and clock) is different > >> than this field? If not, we risk regressions. > >> > >> This case is OK, but there is plenty other cases. >...

...t; --- a/drivers/gpu/drm/panel/panel-arm-versatile.c > > +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c > > @@ -143,7 +143,6 @@ static const struct versatile_panel_type versatile_panels[] = { > > .vsync_start = 240 + 5, > > .vsync_end = 240 + 5 + 6, > > .vtotal = 240 + 5 + 6 + 5, > > - .vrefresh = 116, > > > Are you sure vrefresh calculated (from totals and clock) is different > than this field? If not, we risk regressions. > > This case is OK, but there is plenty other cases. IIRC I did spot check a few of them. But which co...

...0..47b37fef7ee8 100644 > --- a/drivers/gpu/drm/panel/panel-arm-versatile.c > +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c > @@ -143,7 +143,6 @@ static const struct versatile_panel_type versatile_panels[] = { > .vsync_start = 240 + 5, > .vsync_end = 240 + 5 + 6, > .vtotal = 240 + 5 + 6 + 5, > - .vrefresh = 116, Are you sure vrefresh calculated (from totals and clock) is different than this field? If not, we risk regressions. This case is OK, but there is plenty other cases. Regards Andrzej > .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, &...

...s/gpu/drm/panel/panel-arm-versatile.c >>> +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c >>> @@ -143,7 +143,6 @@ static const struct versatile_panel_type versatile_panels[] = { >>> .vsync_start = 240 + 5, >>> .vsync_end = 240 + 5 + 6, >>> .vtotal = 240 + 5 + 6 + 5, >>> - .vrefresh = 116, >> >> Are you sure vrefresh calculated (from totals and clock) is different >> than this field? If not, we risk regressions. >> >> This case is OK, but there is plenty other cases. > IIRC I did spot check a few of...

...1c4 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -775,9 +775,7 @@ int drm_mode_vrefresh(const struct drm_display_mode *mode) { int refresh = 0; - if (mode->vrefresh > 0) - refresh = mode->vrefresh; - else if (mode->htotal > 0 && mode->vtotal > 0) { + if (mode->htotal > 0 && mode->vtotal > 0) { unsigned int num, den; num = mode->clock * 1000; @@ -1324,7 +1322,7 @@ static int drm_mode_compare(void *priv, struct list_head *lh_a, struct list_head if (diff) return diff; - diff = b->vrefresh - a-&g...

Hi, Here I post these 2 misc patches. Best regards, Maxim Levitsky

...7bd 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -759,9 +759,7 @@ int drm_mode_vrefresh(const struct drm_display_mode *mode) { int refresh = 0; - if (mode->vrefresh > 0) - refresh = mode->vrefresh; - else if (mode->htotal > 0 && mode->vtotal > 0) { + if (mode->htotal > 0 && mode->vtotal > 0) { unsigned int num, den; num = mode->clock * 1000; @@ -1308,7 +1306,7 @@ static int drm_mode_compare(void *priv, struct list_head *lh_a, struct list_head if (diff) return diff; - diff = b->vrefresh - a-&g...

...erent value now. So is the recommendation that even in the case of compression mode->clock should always hold uncompressed pixel clock value because with this part of the change we will now get a different value when we call this API. > - else if (mode->htotal > 0 && mode->vtotal > 0) { > + if (mode->htotal > 0 && mode->vtotal > 0) { > unsigned int num, den; > > num = mode->clock * 1000; > @@ -1308,7 +1306,7 @@ static int drm_mode_compare(void *priv, struct > list_head *lh_a, struct list_head > if (diff) > return...

...7bd 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -759,9 +759,7 @@ int drm_mode_vrefresh(const struct drm_display_mode *mode) { int refresh = 0; - if (mode->vrefresh > 0) - refresh = mode->vrefresh; - else if (mode->htotal > 0 && mode->vtotal > 0) { + if (mode->htotal > 0 && mode->vtotal > 0) { unsigned int num, den; num = mode->clock * 1000; @@ -1308,7 +1306,7 @@ static int drm_mode_compare(void *priv, struct list_head *lh_a, struct list_head if (diff) return diff; - diff = b->vrefresh - a-&g...

...Native backend timings for DFP-0: (II) NVIDIA(0): 640 x 480 @ 60 Hz (II) NVIDIA(0): Pixel Clock : 25.175 MHz (II) NVIDIA(0): HRes, HSyncStart : 640, 656 (II) NVIDIA(0): HSyncEnd, HTotal : 752, 800 (II) NVIDIA(0): VRes, VSyncStart : 480, 490 (II) NVIDIA(0): VSyncEnd, VTotal : 492, 525 (II) NVIDIA(0): H/V Polarity : -/- (II) NVIDIA(0): (II) NVIDIA(0): Validating Mode "1920x1080": (II) NVIDIA(0): 1920 x 1080 @ 60 Hz (II) NVIDIA(0): Mode Source: X Configuration file ModeLine (II) NVIDIA(0): Pixel Clock : 148.300 MHz (II) NVIDIA(0)...

Hi, Here is my patch queue I accumulated over quite a long time. Patches 1-6 are bugfixes, and rest is mostly RFC. Comments are welcome. Best regards, Maxim Levitsky

Hello there This is the first time I have used r-help message board so I hope I have got the right address. I am trying to check the residuals of a GLMM model(run using the package lme4). I have been able to check the residiuals of REMLs in lme4 using the following: m1<-lmer(vTotal~Week+fCollar+ (1|fCat), collars) res<-resid(m1) plot(res) qqnorm(res) library(MASS) par(mfrow=c(2,3)) res<-residuals(m1) truehist(res,main="Histogram of Residuals") curve(dnorm(x,mean=mean(res),sd=sd(res)),add=TRUE) qqnorm(fitted(m1),resid(m1), ylim=range(fitted(m1)), main="QQ...

...irrus_convert_to(fb); + + if (convert_cpp) + return convert_cpp * fb->width; + return fb->pitches[0]; +} + +static int cirrus_mode_set(struct cirrus_device *cirrus, + struct drm_display_mode *mode, + struct drm_framebuffer *fb) +{ + int hsyncstart, hsyncend, htotal, hdispend; + int vtotal, vdispend; + int tmp; + int sr07 = 0, hdr = 0; + + htotal = mode->htotal / 8; + hsyncend = mode->hsync_end / 8; + hsyncstart = mode->hsync_start / 8; + hdispend = mode->hdisplay / 8; + + vtotal = mode->vtotal; + vdispend = mode->vdisplay; + + vdispend -= 1; + vtotal -= 2; + + htot...

...\ > + > + > +static int cirrus_mode_set(struct cirrus_device *cirrus, > + struct drm_crtc_state *crtc_state) > +{ > + struct drm_display_mode *mode = &crtc_state->mode; > + int hsyncstart, hsyncend, htotal, hdispend; > + int vtotal, vdispend; > + int tmp; > + int sr07 = 0, hdr = 0; > + > + htotal = mode->htotal / 8; > + hsyncend = mode->hsync_end / 8; > + hsyncstart = mode->hsync_start / 8; > + hdispend = mode->hdisplay / 8; > + > + vtotal = mode...

...RREG8(VGA_DAC_MASK); \ + WREG8(VGA_DAC_MASK, v); \ + } while (0) \ + + +static int cirrus_mode_set(struct cirrus_device *cirrus, + struct drm_crtc_state *crtc_state) +{ + struct drm_display_mode *mode = &crtc_state->mode; + int hsyncstart, hsyncend, htotal, hdispend; + int vtotal, vdispend; + int tmp; + int sr07 = 0, hdr = 0; + + htotal = mode->htotal / 8; + hsyncend = mode->hsync_end / 8; + hsyncstart = mode->hsync_start / 8; + hdispend = mode->hdisplay / 8; + + vtotal = mode->vtotal; + vdispend = mode->vdisplay; + + vdispend -= 1; + vtotal -= 2; + + htot...

...RREG8(VGA_DAC_MASK); \ + WREG8(VGA_DAC_MASK, v); \ + } while (0) \ + + +static int cirrus_mode_set(struct cirrus_device *cirrus, + struct drm_crtc_state *crtc_state) +{ + struct drm_display_mode *mode = &crtc_state->mode; + int hsyncstart, hsyncend, htotal, hdispend; + int vtotal, vdispend; + int tmp; + int sr07 = 0, hdr = 0; + + htotal = mode->htotal / 8; + hsyncend = mode->hsync_end / 8; + hsyncstart = mode->hsync_start / 8; + hdispend = mode->hdisplay / 8; + + vtotal = mode->vtotal; + vdispend = mode->vdisplay; + + vdispend -= 1; + vtotal -= 2; + + htot...

...crt(cirrus, 0x1d); + tmp &= 0x7f; + tmp |= (addr >> 12) & 0x80; + wreg_crt(cirrus, 0x1d, tmp); +} + +static int cirrus_mode_set(struct cirrus_device *cirrus, + struct drm_display_mode *mode, + struct drm_framebuffer *fb) +{ + int hsyncstart, hsyncend, htotal, hdispend; + int vtotal, vdispend; + int tmp; + int sr07 = 0, hdr = 0; + + htotal = mode->htotal / 8; + hsyncend = mode->hsync_end / 8; + hsyncstart = mode->hsync_start / 8; + hdispend = mode->hdisplay / 8; + + vtotal = mode->vtotal; + vdispend = mode->vdisplay; + + vdispend -= 1; + vtotal -= 2; + + htot...

* Frame-packing modes add an extra vtotal raster lines to each frame above and beyond what the basic mode description calls for. Account for this during scaler configuration (possibly a bit of a hack), during CRTC configuration (clearly not a hack), and when checking that a mode is vaild for a given connector (cribbed from the i915 driver)...

...de/mcde_dsi.c > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > @@ -538,7 +538,7 @@ static void mcde_dsi_setup_video_mode(struct mcde_dsi *d, > */ > /* (ps/s) / (pixels/s) = ps/pixels */ > pclk = DIV_ROUND_UP_ULL(1000000000000, > - (mode->vrefresh * mode->htotal * mode->vtotal)); > + (drm_mode_vrefresh(mode) * mode->htotal * mode->vtotal)); > dev_dbg(d->dev, "picoseconds between two pixels: %llu\n", > pclk); > This just caught my eye while browsing the patch. It looks like a backward way to get the clock. But patch is fine, it w...