search for: vm_action

...of file diff --git a/src/app/services/vm_service.rb b/src/app/services/vm_service.rb index 3d9777c..a78e17d 100644 --- a/src/app/services/vm_service.rb +++ b/src/app/services/vm_service.rb @@ -211,13 +211,42 @@ module VmService # <tt>VmTask.action_privilege(@action)</tt> def svc_vm_action(id, vm_action, action_args) @vm = Vm.find(id) + unless @vm.valid_action?(vm_action) + raise ActionError.new("#{vm_action} is an invalid action.") + end authorized!(VmTask.action_privilege(vm_action), VmTask.action_privilege_object(vm_action, at vm))...

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next

The following two patches should be applied in the order: * [PATCH server] Add svc_vm_actions method to VmService. * [PATCH server] Cloud UI layer to initiate actions on vms. The service layer patch should work fine on its own (and not break anything), but cloud patch relies on service being there.

Forwarding to the list for Jay or Scott to have a look. Ignazio, do you see any more details (traceback or something) in the rails log? -------------- next part -------------- An embedded message was scrubbed... From: ignazio.cassano at provincia.torino.it Subject: Re: [Ovirt-devel] [PATCH node-image] keep NIC and HBA firmwares Date: Wed, 16 Sep 2009 16:48:47 +0200 Size: 4031 URL:

...tart the Virtual Machine. Leave the selection blank to allow oVirt to choose the most appropriate starting host. +<%- end -%> +<div class="panel_header"></div> + +<form method="POST" id="start_vm_form" action="<%= url_for :action => 'vm_action' %>"> + <div class="dialog_form"> + <%= error_messages_for 'start_vm' %> + + <%= render :partial => '/host/grid', :locals => { + :table_id => 'start_vm_grid', + :hwpool => @vm.get_hardware...

...d_rows[i].id; + } + if (selected_ids.length == 1) { + $('#selected_starting_host') + .load('<%= url_for :controller => "host", :action => "quick_summary" %>', + { id: parseInt(selected_ids[0].substring(3)) }); + $('#vm_action_data').val(selected_ids[0].substring(3)); + } + } + + function start_vm_deselect(selected_rows) { + var selected_ids = new Array() + for (i=0; i<selected_rows.length; i++) { + load_widget_deselect(selected_rows[i]); + selected_ids[i] = selected_rows[i].id; + } + re...

...ex 00cf982..8930a4b 100644 --- a/src/app/services/vm_resource_pool_service.rb +++ b/src/app/services/vm_resource_pool_service.rb @@ -73,7 +73,6 @@ module VmResourcePoolService # permission is action-specific as determined by # <tt>VmTask.action_privilege(@action)</tt> def svc_vm_actions(pool_id, vm_action, vm_ids) - # from before_filter @pool = VmResourcePool.find(pool_id) @parent = @pool.parent @action = vm_action diff --git a/src/app/services/vm_service.rb b/src/app/services/vm_service.rb index fb58b51..4c29bcf 100644 --- a/src/app/services/vm_service.rb +++ b...

...;).html()) != -1){ empty_summary('vms_selection', 'Virtual Machine'); - } + } }, 'json'); } } @@ -81,7 +81,7 @@ var vms = get_selected_vms(); if (validate_selected(vms, "vm")) { jQuery.facebox('<div id="vm_action_results">'); - $('#vm_action_results').load('<%= url_for :controller => "resources", + $('#vm_action_results').load('<%= url_for :controller => "resources", :action => "vm_actions", :id => @...

..._perms(@user, + Privilege::VIEW, + # NOTE: maybe this ^^ part could be taken care of behind the scenes? + # Also, needs to be changed to a cloud priv + page, order) + @actions = VmTask.get_vm_actions + show + end + + def show + ids = params[:ids] + task_page = find_in_params_or_default(:task_page, 1) + task_order = find_in_params_or_default(:task_order, "tasks.id") + @vm_details = Vm.find(ids) if ids + if @vm_details + @tasks = VmTask.paginate(:conditions =&g...