search for: visibilitytyp

I tried to compile the "bugpoint" project on Windows 7 MSVC 10 64-bit and I see the following failure: 8>W:\LLVM_org\llvm\include\llvm/ADT/Optional.h(73): error C2839: invalid return type 'llvm::GlobalValue::VisibilityTypes *' for overloaded 'operator ->' 8> W:\LLVM_org\llvm\include\llvm/ADT/Optional.h(71) : while compiling class template member function 'void llvm::Optional<T>::reset(void)' 8> with 8> [ 8> T=llvm::GlobalValue::Visibili...

...additional linkage type(s) for the combinations to GlobalValue::LinkageTypes. This appears to be the least invasive way, but adds new linkage types to an already large list. 2. Handle dllexport/import similar to ELF visibility by adding new "visibility" types to GlobalValue::VisibilityTypes and IR visibility styles. This feels like kind of a band-aid. While dllexport could be construed as similar to default visibility (some code uses both in the same place depending on platform), dllimport feels wrong here. This would also prevent mixing ELF visibility with dllexport...

If I remove this code, diff --git a/tools/gold/gold-plugin.cpp b/tools/gold/gold-plugin.cpp index 46a5f46..a8978d5 100644 --- a/tools/gold/gold-plugin.cpp +++ b/tools/gold/gold-plugin.cpp @@ -428,8 +428,6 @@ getMinVisibility(GlobalValue::VisibilityTypes A, return A; if (B == GlobalValue::HiddenVisibility) return B; - if (A == GlobalValue::ProtectedVisibility) - return A; return B; } @@ -520,15 +518,9 @@ static ld_plugin_status claim_file_hook(const ld_plugin_input_file *file, Res.IsLinkonceOdr &= GV->hasLinkOn...

...additional linkage type(s) for the combinations to GlobalValue::LinkageTypes. This appears to be the least invasive way, but adds new linkage types to an already large list. 2. Handle dllexport/import similar to ELF visibility by adding new "visibility" types to GlobalValue::VisibilityTypes and IR visibility styles. This feels like kind of a band-aid. While dllexport could be construed as similar to default visibility (some code uses both in the same place depending on platform), dllimport feels wrong here. This would also prevent mixing ELF visibility with dllexport...

On Tue, Apr 4, 2017 at 12:36 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > On 2017-Apr-04, at 12:12, Peter Collingbourne <peter at pcc.me.uk> wrote: > > On Mon, Apr 3, 2017 at 8:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Apr 3, 2017, at 7:08 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: >>