search for: virtio_pci_legaci

Device VQs were getting freed twice: once in every devices removal functions, and then again in virtio_pci_legacy_remove(). Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 ---

Device VQs were getting freed twice: once in every devices removal functions, and then again in virtio_pci_legacy_remove(). Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 ---

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

This is based on Sasha's patch, with some tweaks. Michael S. Tsirkin (2): virtio_pci: device-specific release callback virtio_pci: document why we defer kfree Sasha Levin (1): virtio_pci: defer kfree until release callback drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --------- drivers/virtio/virtio_pci_legacy.c | 12 +++++++++++- 3 files

This is based on Sasha's patch, with some tweaks. Michael S. Tsirkin (2): virtio_pci: device-specific release callback virtio_pci: document why we defer kfree Sasha Levin (1): virtio_pci: defer kfree until release callback drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --------- drivers/virtio/virtio_pci_legacy.c | 12 +++++++++++- 3 files

VIRTIO_PCI_CONFIG() is deprecated. Use VIRTIO_PCI_CONFIG_OFF() instead. Signed-off-by: Dongli Zhang <dongli.zhang at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 6 ++++-- include/uapi/linux/virtio_pci.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index de062fb..eff9ddc 100644 ---

VIRTIO_PCI_CONFIG() is deprecated. Use VIRTIO_PCI_CONFIG_OFF() instead. Signed-off-by: Dongli Zhang <dongli.zhang at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 6 ++++-- include/uapi/linux/virtio_pci.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index de062fb..eff9ddc 100644 ---

On Wed, Mar 11, 2020 at 03:44:14PM -0700, Ram Muthiah wrote: > On Sat, Feb 29, 2020 at 11:32 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Fri, Feb 28, 2020 at 03:27:36PM -0800, Ram Muthiah wrote: > > > The legacy pci driver should no longer be default enabled. QEMU has > > > implemented support for Virtio 1 for virtio-pci since June 2015 >

On Fri, Feb 28, 2020 at 03:27:36PM -0800, Ram Muthiah wrote: > The legacy pci driver should no longer be default enabled. QEMU has > implemented support for Virtio 1 for virtio-pci since June 2015 > on SHA dfb8e184db75. > > Signed-off-by: Ram Muthiah <rammuthiah at google.com> I see little reason to do this: y is safer and will boot on more hypervisors, so people that

kbuild does not seem to like it when we name source files same as the module. Let's rename virtio_pci -> virtio_pci_common, and get rid of #include-ing c files. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/{virtio_pci.h => virtio_pci_common.h} | 4 ++-- drivers/virtio/{virtio_pci.c => virtio_pci_common.c} | 2 +- drivers/virtio/virtio_pci_legacy.c

kbuild does not seem to like it when we name source files same as the module. Let's rename virtio_pci -> virtio_pci_common, and get rid of #include-ing c files. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/{virtio_pci.h => virtio_pci_common.h} | 4 ++-- drivers/virtio/{virtio_pci.c => virtio_pci_common.c} | 2 +- drivers/virtio/virtio_pci_legacy.c

On Tue, Apr 11, 2023 at 06:36:39AM +0000, Angus Chen wrote: > Hi. > > > -----Original Message----- > > From: Jason Wang <jasowang at redhat.com> > > Sent: Tuesday, April 11, 2023 1:24 PM > > To: Angus Chen <angus.chen at jaguarmicro.com> > > Cc: mst at redhat.com; virtualization at lists.linux-foundation.org; > > linux-kernel at

It turns out we need to add device-specific code in release callback. Move it to virtio_pci_legacy.c. Reported-by: Sasha Levin <sasha.levin at oracle.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is intended as dependency for Sasha's patch adding code to release callback. drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9

It turns out we need to add device-specific code in release callback. Move it to virtio_pci_legacy.c. Reported-by: Sasha Levin <sasha.levin at oracle.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is intended as dependency for Sasha's patch adding code to release callback. drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

Move resource allocation from common code to legacy and modern code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++-

On Fri, Jan 02, 2015 at 02:47:40PM -0500, Sasha Levin wrote: > When releasing a virtio device, We can't free a struct virtio_device until the > underlying struct device has been released, which might not happen immediately > on device_unregister() even if that was the device's last reference. > > Instead, free the memory only once we know the device is gone in the release