search for: virtio_pci_legacy

Device VQs were getting freed twice: once in every devices removal functions, and then again in virtio_pci_legacy_remove(). Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 --- a/drivers/virtio/virtio_pci...

Device VQs were getting freed twice: once in every devices removal functions, and then again in virtio_pci_legacy_remove(). Signed-off-by: Sasha Levin <sasha.levin at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 --- a/drivers/virtio/virtio_pci...

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the virtio_pci driver was moved...

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the virtio_pci driver was moved...

...weaks. Michael S. Tsirkin (2): virtio_pci: device-specific release callback virtio_pci: document why we defer kfree Sasha Levin (1): virtio_pci: defer kfree until release callback drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --------- drivers/virtio/virtio_pci_legacy.c | 12 +++++++++++- 3 files changed, 11 insertions(+), 11 deletions(-) -- MST

...weaks. Michael S. Tsirkin (2): virtio_pci: device-specific release callback virtio_pci: document why we defer kfree Sasha Levin (1): virtio_pci: defer kfree until release callback drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --------- drivers/virtio/virtio_pci_legacy.c | 12 +++++++++++- 3 files changed, 11 insertions(+), 11 deletions(-) -- MST

VIRTIO_PCI_CONFIG() is deprecated. Use VIRTIO_PCI_CONFIG_OFF() instead. Signed-off-by: Dongli Zhang <dongli.zhang at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 6 ++++-- include/uapi/linux/virtio_pci.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index de062fb..eff9ddc 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_lega...

VIRTIO_PCI_CONFIG() is deprecated. Use VIRTIO_PCI_CONFIG_OFF() instead. Signed-off-by: Dongli Zhang <dongli.zhang at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 6 ++++-- include/uapi/linux/virtio_pci.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index de062fb..eff9ddc 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_lega...

...; > > > Signed-off-by: Ram Muthiah <rammuthiah at google.com> > > > > I see little reason to do this: y is safer and will boot on more > > hypervisors, so people that aren't sure should enable it. > > > > In that case, would it be reasonable to fold VIRTIO_PCI_LEGACY > into VIRTIO_PCI? > > The result would boot more hypervisors as well and remove the > CONFIG in the process. This might break configurations relying on the flying car joke to be there. > > > --- > > > drivers/virtio/Kconfig | 6 ------ > > > 1 file chang...

...onfig | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 078615cf2afc..eacd0b90d32b 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -26,7 +26,6 @@ config VIRTIO_PCI > > config VIRTIO_PCI_LEGACY > bool "Support for legacy virtio draft 0.9.X and older devices" > - default y > depends on VIRTIO_PCI > ---help--- > Virtio PCI Card 0.9.X Draft (circa 2014) and older device support. > @@ -36,11 +35,6 @@ config VIRTIO_PCI_LEGACY > If disabled, y...

...et's rename virtio_pci -> virtio_pci_common, and get rid of #include-ing c files. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/{virtio_pci.h => virtio_pci_common.h} | 4 ++-- drivers/virtio/{virtio_pci.c => virtio_pci_common.c} | 2 +- drivers/virtio/virtio_pci_legacy.c | 2 +- drivers/virtio/Makefile | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) rename drivers/virtio/{virtio_pci.h => virtio_pci_common.h} (97%) rename drivers/virtio/{virtio_pci.c => virtio_pci_common.c} (99%) diff --git a/drivers/...

...et's rename virtio_pci -> virtio_pci_common, and get rid of #include-ing c files. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/{virtio_pci.h => virtio_pci_common.h} | 4 ++-- drivers/virtio/{virtio_pci.c => virtio_pci_common.c} | 2 +- drivers/virtio/virtio_pci_legacy.c | 2 +- drivers/virtio/Makefile | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) rename drivers/virtio/{virtio_pci.h => virtio_pci_common.h} (97%) rename drivers/virtio/{virtio_pci.c => virtio_pci_common.c} (99%) diff --git a/drivers/...

...tly when the host use the other kernel like ubuntu or centos8. > > So we hope we can fix this by upstream . > > > > Thanks > > > > > > > > Signed-off-by: Angus Chen <angus.chen at jaguarmicro.com> > > > --- > > > drivers/virtio/virtio_pci_legacy.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c > > > index 2257f1b3d8ae..f2d241563e4f 100644 > > > --- a/drivers/virtio/virtio_pci_legacy.c...

It turns out we need to add device-specific code in release callback. Move it to virtio_pci_legacy.c. Reported-by: Sasha Levin <sasha.levin at oracle.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is intended as dependency for Sasha's patch adding code to release callback. drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --...

It turns out we need to add device-specific code in release callback. Move it to virtio_pci_legacy.c. Reported-by: Sasha Levin <sasha.levin at oracle.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is intended as dependency for Sasha's patch adding code to release callback. drivers/virtio/virtio_pci_common.h | 1 - drivers/virtio/virtio_pci_common.c | 9 --...

...n code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++- drivers/virtio/virtio_pci_modern.c | 24 ++++++++++++++++++------ 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index eba1b7a..327a121 100644 --- a/drivers/virtio/virtio_pci_common.c +++...

...n code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++- drivers/virtio/virtio_pci_modern.c | 24 ++++++++++++++++++------ 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index eba1b7a..327a121 100644 --- a/drivers/virtio/virtio_pci_common.c +++...

...n code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++- drivers/virtio/virtio_pci_modern.c | 24 ++++++++++++++++++------ 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index eba1b7a..327a121 100644 --- a/drivers/virtio/virtio_pci_common.c +++...

...n code. Only request resources actually used, i.e. bar0 in legacy mode and the bar(s) specified by capabilities in modern mode. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/virtio/virtio_pci_common.c | 7 ------- drivers/virtio/virtio_pci_common.h | 2 ++ drivers/virtio/virtio_pci_legacy.c | 13 ++++++++++++- drivers/virtio/virtio_pci_modern.c | 24 ++++++++++++++++++------ 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index eba1b7a..327a121 100644 --- a/drivers/virtio/virtio_pci_common.c +++...

...igned-off-by: Sasha Levin <sasha.levin at oracle.com> Isn't this an old bug: do we need to copy stable on a fix? What is the behaviour without this patch? Is there a way to make this cause a crash? > --- > drivers/virtio/virtio_pci_common.c | 9 ++++----- > drivers/virtio/virtio_pci_legacy.c | 1 - > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c > index 59d3685..caa483d 100644 > --- a/drivers/virtio/virtio_pci_common.c > +++ b/drivers/virtio/virtio_pci_common.c > @@ -4...