search for: virtio_mmio_queuepfn

Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/standard-headers/linux/virtio_mmio.h | 141 +++++++++++++++++++++++++++ 1 file changed, 141 insertions(+) create mode 100644 include/standard-headers/linux/virtio_mmio.h diff --git a/include/standard-headers/linux/virtio_mmio.h b/include/standard-headers/linux/virtio_mmio.h new file mode 100644 index 0000000..c4b0968 ---

Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/standard-headers/linux/virtio_mmio.h | 141 +++++++++++++++++++++++++++ 1 file changed, 141 insertions(+) create mode 100644 include/standard-headers/linux/virtio_mmio.h diff --git a/include/standard-headers/linux/virtio_mmio.h b/include/standard-headers/linux/virtio_mmio.h new file mode 100644 index 0000000..c4b0968 ---

...> + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > break; > case VIRTIO_MMIO_QUEUEPFN: > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 8f69ffa..57190ba 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -69,7 +69,6 @@ typedef struct VRing > struct VirtQueue > { > VRing vring; > - hwaddr pa; > uint16_t last_av...

...> + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > break; > case VIRTIO_MMIO_QUEUEPFN: > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 8f69ffa..57190ba 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -69,7 +69,6 @@ typedef struct VRing > struct VirtQueue > { > VRing vring; > - hwaddr pa; > uint16_t last_av...

...; > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEPFN: > if (value == 0) { Let's just call virtio_queue_update_rings from virtio_queue_set_align? > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 8f69ffa..b2d553e 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -69,7 +69,6 @@ typedef str...

...; > break; > case VIRTIO_MMIO_QUEUEALIGN: > + /* Note: this is only valid for legacy devices */ > virtio_queue_set_align(vdev, vdev->queue_sel, value); > + virtio_queue_update_rings(vdev, vdev->queue_sel); > break; > case VIRTIO_MMIO_QUEUEPFN: > if (value == 0) { Let's just call virtio_queue_update_rings from virtio_queue_set_align? > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 8f69ffa..b2d553e 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -69,7 +69,6 @@ typedef str...

...pdate_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > break; > > case VIRTIO_MMIO_QUEUEPFN: (...) > > /* virt queue functions */ > > -static void virtqueue_init(VirtQueue *vq) > > +void virtio_queue_update_rings(VirtIODevice *vdev, int n) > > Perhaps something in the name to emphasise that this is only for <v1.0 > devices? virtio_queue_legacy_update_rin...

...pdate_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > break; > > case VIRTIO_MMIO_QUEUEPFN: (...) > > /* virt queue functions */ > > -static void virtqueue_init(VirtQueue *vq) > > +void virtio_queue_update_rings(VirtIODevice *vdev, int n) > > Perhaps something in the name to emphasise that this is only for <v1.0 > devices? virtio_queue_legacy_update_rin...

...t; case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEPFN: > > if (value == 0) { > > Let's just call virtio_queue_update_rings from virtio_queue_set_align? You're right, set_align is legacy only so we can always call update_rings. > > @@ -748,6 +756,11 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int ali...

...t; case VIRTIO_MMIO_QUEUEALIGN: > > + /* Note: this is only valid for legacy devices */ > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > break; > > case VIRTIO_MMIO_QUEUEPFN: > > if (value == 0) { > > Let's just call virtio_queue_update_rings from virtio_queue_set_align? You're right, set_align is legacy only so we can always call update_rings. > > @@ -748,6 +756,11 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int ali...

On Tue, 2 Dec 2014 21:03:45 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) > > { > > + /* > > + * For virtio-1 devices, the number of buffers may only be > > + * updated if the ring addresses have

On Tue, 2 Dec 2014 21:03:45 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) > > { > > + /* > > + * For virtio-1 devices, the number of buffers may only be > > + * updated if the ring addresses have

...QUEUEALIGN: > > > + /* Note: this is only valid for legacy devices */ > > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > > break; > > > case VIRTIO_MMIO_QUEUEPFN: > > > if (value == 0) { > > > > Let's just call virtio_queue_update_rings from virtio_queue_set_align? > > You're right, set_align is legacy only so we can always call > update_rings. > > > > > @@ -748,6 +756,11 @@ void virtio_queue...

...QUEUEALIGN: > > > + /* Note: this is only valid for legacy devices */ > > > virtio_queue_set_align(vdev, vdev->queue_sel, value); > > > + virtio_queue_update_rings(vdev, vdev->queue_sel); > > > break; > > > case VIRTIO_MMIO_QUEUEPFN: > > > if (value == 0) { > > > > Let's just call virtio_queue_update_rings from virtio_queue_set_align? > > You're right, set_align is legacy only so we can always call > update_rings. > > > > > @@ -748,6 +756,11 @@ void virtio_queue...

...this function for legacy devices */ + virtio_queue_update_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEALIGN: + /* Note: this is only valid for legacy devices */ virtio_queue_set_align(vdev, vdev->queue_sel, value); break; case VIRTIO_MMIO_QUEUEPFN: diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 8f69ffa..57190ba 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -69,7 +69,6 @@ typedef struct VRing struct VirtQueue { VRing vring; - hwaddr pa; uint16_t last_avail_idx; /* Last used index value we have sig...

...this function for legacy devices */ + virtio_queue_update_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEALIGN: + /* Note: this is only valid for legacy devices */ virtio_queue_set_align(vdev, vdev->queue_sel, value); break; case VIRTIO_MMIO_QUEUEPFN: diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 8f69ffa..57190ba 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -69,7 +69,6 @@ typedef struct VRing struct VirtQueue { VRing vring; - hwaddr pa; uint16_t last_avail_idx; /* Last used index value we have sig...

...ate_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEALIGN: + /* Note: this is only valid for legacy devices */ virtio_queue_set_align(vdev, vdev->queue_sel, value); + virtio_queue_update_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEPFN: if (value == 0) { diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 8f69ffa..b2d553e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -69,7 +69,6 @@ typedef struct VRing struct VirtQueue { VRing vring; - hwaddr pa; uint16_t last_avail_idx; /* Last u...

...ate_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEALIGN: + /* Note: this is only valid for legacy devices */ virtio_queue_set_align(vdev, vdev->queue_sel, value); + virtio_queue_update_rings(vdev, vdev->queue_sel); break; case VIRTIO_MMIO_QUEUEPFN: if (value == 0) { diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 8f69ffa..b2d553e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -69,7 +69,6 @@ typedef struct VRing struct VirtQueue { VRing vring; - hwaddr pa; uint16_t last_avail_idx; /* Last u...

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features