search for: virtio_mem

...manually merge resources later when e.g., trying to create a kdump header). Before this patch, we get (/proc/iomem) when hotplugging 2G via virtio-mem on x86-64: [...] 100000000-13fffffff : System RAM 140000000-33fffffff : virtio0 140000000-147ffffff : System RAM (virtio_mem) 148000000-14fffffff : System RAM (virtio_mem) 150000000-157ffffff : System RAM (virtio_mem) 158000000-15fffffff : System RAM (virtio_mem) 160000000-167ffffff : System RAM (virtio_mem) 168000000-16fffffff : System RAM (virtio_mem) 17000000...

rc is initialized to -ENIVAL but that's never used. Drop it. Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug") Reported-by: kernel test robot <lkp at intel.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index f658fe9149be..2f357142ea5e 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(st...

Fixes: 676fa9ba893e ("virtio_mem: convert device block size into 64bit") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 7b1bece8a331..50c689f2504...

...we hit the "break;" statement on the first iteration through the loop. I suspect that this can't happen in real life, but returning a zero literal is cleaner and silence the static checker warning. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- drivers/virtio/virtio_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index f658fe9149beb..893ef18060a02 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(st...

...ABI change, but it's not too late to make it, and it will allow supporting >4Gbyte blocks while might become necessary down the road. Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 14 +++++++------- include/uapi/linux/virtio_mem.h | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 2f357142ea5e..7b1bece8a331 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c...

...ABI change, but it's not too late to make it, and it will allow supporting >4Gbyte blocks while might become necessary down the road. Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 14 +++++++------- include/uapi/linux/virtio_mem.h | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 2f357142ea5e..7b1bece8a331 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c...

...(blocks in the gigabyte range were never the original intention of virtio-mem, but I am not completely opposed to that) > Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_mem.c | 14 +++++++------- > include/uapi/linux/virtio_mem.h | 4 ++-- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index 2f357142ea5e..7b1bece8a331 100644 > --- a/drivers/virtio/virtio_mem.c >...

.... I'd like to avoid that complexity and code churn for now. David Hildenbrand (5): kernel/resource: make release_mem_region_adjustable() never fail kernel/resource: merge_child_mem_resources() to merge memory resources after adding succeeded virtio-mem: try to merge "System RAM (virtio_mem)" resources xen/balloon: try to merge "System RAM" resources hv_balloon:: try to merge "System RAM" resources drivers/hv/hv_balloon.c | 3 ++ drivers/virtio/virtio_mem.c | 14 ++++- drivers/xen/balloon.c | 4 ++ include/linux/ioport.h | 7 ++- ke...

...r_managed()"). This will result in no entries in /sys/firmware/memmap ("raw firmware- provided memory map"), the memory resource will be flagged IORESOURCE_MEM_DRIVER_MANAGED (esp., kexec_file_load() will not place kexec images on this memory), and it is exposed as "System RAM (virtio_mem)" in /proc/iomem, so esp. kexec-tools can properly handle it. Example /proc/iomem before this change: [...] 140000000-333ffffff : virtio0 140000000-147ffffff : System RAM 334000000-533ffffff : virtio1 338000000-33fffffff : System RAM 340000000-347ffffff : System RAM 3480...

...r_managed()"). This will result in no entries in /sys/firmware/memmap ("raw firmware- provided memory map"), the memory resource will be flagged IORESOURCE_MEM_DRIVER_MANAGED (esp., kexec_file_load() will not place kexec images on this memory), and it is exposed as "System RAM (virtio_mem)" in /proc/iomem, so esp. kexec-tools can properly handle it. Example /proc/iomem before this change: [...] 140000000-333ffffff : virtio0 140000000-147ffffff : System RAM 334000000-533ffffff : virtio1 338000000-33fffffff : System RAM 340000000-347ffffff : System RAM 3480...

Virtio mem is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index f26f5f64ae82..c08512fcea90 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1530,21 +1530,21 @@ static...

...a ..." -- "mm/memory_hotplug: Introduce offline_and_remove_memory()" v2 -> v3: - "virtio-mem: Paravirtualized memory hotplug" -- Include "linux/slab.h" to fix build issues -- Remember the "region_size", helpful for patch #11 -- Minor simplifaction in virtio_mem_overlaps_range() -- Use notifier_from_errno() instead of notifier_to_errno() in notifier -- More reliable check for added memory when unloading the driver - "virtio-mem: Allow to specify an ACPI PXM as nid" -- Also print the nid - Added patch #11-#15 David Hildenbrand (15): virtio-mem:...

...4ed2d533f799cb0da2b29cc6f0 # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp at intel.com> All error/warnings (new ones prefixed by >>): drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);...

...4ed2d533f799cb0da2b29cc6f0 # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp at intel.com> All error/warnings (new ones prefixed by >>): drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);...

...ee > > make ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kbuild test robot <lkp at intel.com> > > > > All error/warnings (new ones prefixed by >>): > > > > drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': > >>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);...

...ee > > make ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kbuild test robot <lkp at intel.com> > > > > All error/warnings (new ones prefixed by >>): > > > > drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': > >>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);...

...gt; > >>> If you fix the issue, kindly add following tag as appropriate > >>> Reported-by: kbuild test robot <lkp at intel.com> > >>> > >>> All error/warnings (new ones prefixed by >>): > >>> > >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': > >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] > >>> vdev->priv = vm = kzalloc(sizeof(*vm...

...gt; > >>> If you fix the issue, kindly add following tag as appropriate > >>> Reported-by: kbuild test robot <lkp at intel.com> > >>> > >>> All error/warnings (new ones prefixed by >>): > >>> > >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': > >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] > >>> vdev->priv = vm = kzalloc(sizeof(*vm...

...ve the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp at intel.com> All errors (new ones prefixed by >>): In file included from <command-line>:1:0: >> ./usr/include/linux/virtio_mem.h:185:2: error: unknown type name 'uint32_t' uint32_t block_size; ^ >> ./usr/include/linux/virtio_mem.h:187:2: error: unknown type name 'uint16_t' uint16_t node_id; ^ ./usr/include/linux/virtio_mem.h:188:2: error: unknown type name 'uint16_t'...

...redhat.com [2] https://lkml.kernel.org/r/20200506094948.76388-1-david at redhat.com v2 -> v3: - "virtio-mem: Paravirtualized memory hotplug" -- Include "linux/slab.h" to fix build issues -- Remember the "region_size", helpful for patch #11 -- Minor simplifaction in virtio_mem_overlaps_range() -- Use notifier_from_errno() instead of notifier_to_errno() in notifier -- More reliable check for added memory when unloading the driver - "virtio-mem: Allow to specify an ACPI PXM as nid" -- Also print the nid - Added patch #11-#15 Cc: Sebastien Boeuf <sebastien.boe...