Linux Virtualization - May 2020 - [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   da1742791d8c0c0a8e5471f181549c4726a5c5f9
commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem:
Paravirtualized memory hotplug
config: x86_64-randconfig-b002-20200505 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp at intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/virtio/virtio_mem.c: In function
'virtio_mem_probe':
>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of
function 'kzalloc'; did you mean 'vzalloc'?
[-Werror=implicit-function-declaration]
     vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
                       ^~~~~~~
                       vzalloc
>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer
from integer without a cast [-Wint-conversion]
     vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
                     ^
>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of
function 'kfree'; did you mean 'vfree'?
[-Werror=implicit-function-declaration]
     kfree(vm);
     ^~~~~
     vfree
   cc1: some warnings being treated as errors

vim +1375 drivers/virtio/virtio_mem.c

  1369	
  1370	static int virtio_mem_probe(struct virtio_device *vdev)
  1371	{
  1372		struct virtio_mem *vm;
  1373		int rc = -EINVAL;
  1374	
> 1375		vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
  1376		if (!vm)
  1377			return -ENOMEM;
  1378	
  1379		init_waitqueue_head(&vm->host_resp);
  1380		vm->vdev = vdev;
  1381		INIT_WORK(&vm->wq, virtio_mem_run_wq);
  1382		mutex_init(&vm->hotplug_mutex);
  1383		INIT_LIST_HEAD(&vm->next);
  1384		spin_lock_init(&vm->removal_lock);
  1385		hrtimer_init(&vm->retry_timer, CLOCK_MONOTONIC,
HRTIMER_MODE_REL);
  1386		vm->retry_timer.function = virtio_mem_timer_expired;
  1387	
  1388		/* register the virtqueue */
  1389		rc = virtio_mem_init_vq(vm);
  1390		if (rc)
  1391			goto out_free_vm;
  1392	
  1393		/* initialize the device by querying the config */
  1394		rc = virtio_mem_init(vm);
  1395		if (rc)
  1396			goto out_del_vq;
  1397	
  1398		/* register callbacks */
  1399		vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb;
  1400		rc = register_memory_notifier(&vm->memory_notifier);
  1401		if (rc)
  1402			goto out_del_vq;
  1403		rc = register_virtio_mem_device(vm);
  1404		if (rc)
  1405			goto out_unreg_mem;
  1406	
  1407		virtio_device_ready(vdev);
  1408	
  1409		/* trigger a config update to start processing the requested_size */
  1410		atomic_set(&vm->config_changed, 1);
  1411		queue_work(system_freezable_wq, &vm->wq);
  1412	
  1413		return 0;
  1414	out_unreg_mem:
  1415		unregister_memory_notifier(&vm->memory_notifier);
  1416	out_del_vq:
  1417		vdev->config->del_vqs(vdev);
  1418	out_free_vm:
> 1419		kfree(vm);
  1420		vdev->priv = NULL;
  1421	
  1422		return rc;
  1423	}
  1424	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 29432 bytes
Desc: not available
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20200505/c7d3efb5/attachment-0001.gz>

On 05.05.20 16:15, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> head:   da1742791d8c0c0a8e5471f181549c4726a5c5f9
> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem:
Paravirtualized memory hotplug
> config: x86_64-randconfig-b002-20200505 (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
>         git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp at intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of
function 'kzalloc'; did you mean 'vzalloc'?
[-Werror=implicit-function-declaration]
>      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>                        ^~~~~~~
>                        vzalloc
>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes
pointer from integer without a cast [-Wint-conversion]
>      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>                      ^
>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of
function 'kfree'; did you mean 'vfree'?
[-Werror=implicit-function-declaration]
>      kfree(vm);
>      ^~~~~
>      vfree
>    cc1: some warnings being treated as errors
> 
> vim +1375 drivers/virtio/virtio_mem.c
Guess we simply need

 #include <linux/slab.h>

to make it work for that config.

-- 
Thanks,

David / dhildenb

On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand
wrote:
> On 05.05.20 16:15, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
vhost
> > head:   da1742791d8c0c0a8e5471f181549c4726a5c5f9
> > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem:
Paravirtualized memory hotplug
> > config: x86_64-randconfig-b002-20200505 (attached as .config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> > reproduce:
> >         git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp at intel.com>
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >    drivers/virtio/virtio_mem.c: In function
'virtio_mem_probe':
> >>> drivers/virtio/virtio_mem.c:1375:20: error: implicit
declaration of function 'kzalloc'; did you mean 'vzalloc'?
[-Werror=implicit-function-declaration]
> >      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >                        ^~~~~~~
> >                        vzalloc
> >>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes
pointer from integer without a cast [-Wint-conversion]
> >      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
> >                      ^
> >>> drivers/virtio/virtio_mem.c:1419:2: error: implicit
declaration of function 'kfree'; did you mean 'vfree'?
[-Werror=implicit-function-declaration]
> >      kfree(vm);
> >      ^~~~~
> >      vfree
> >    cc1: some warnings being treated as errors
> > 
> > vim +1375 drivers/virtio/virtio_mem.c
> 
> Guess we simply need
> 
>  #include <linux/slab.h>
> 
> to make it work for that config.

OK I added that in the 1st commit that introduced virtio-mem.
> -- 
> Thanks,
> 
> David / dhildenb