search for: virtio_balloon_f_balloon_chunk

Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables the transfer of the ballooned (i.e. inflated/deflated) pages in chunks to the host. The implementation of the previous virtio-balloon is not very efficient, because the ballooned pages are transferred to the host one by one. Here is the breakdown of the time in percentage spent on...

On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: > Hi Michael, could you please give some feedback? I'm sorry, I'm not sure feedback on what you are requesting. The interface looks reasonable now, even though there's a way to make it even simpler if we can limit chunk size to 2G (in fact 4G - 1). Do you think we can live with this limitation? But the code still needs

On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: > On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: > > > Hi Michael, could you please give some feedback? > > I'm sorry, I'm not sure feedback on what you are requesting. > Oh, just some trivial things (e.g. use a field in the > header,

On Sun, May 07, 2017 at 04:19:28AM +0000, Wang, Wei W wrote: > On 05/06/2017 06:26 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: > > > On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: > > > > > Hi Michael, could you please give some

On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: >> Hi Michael, could you please give some feedback? > I'm sorry, I'm not sure feedback on what you are requesting. Oh, just some trivial things (e.g. use a field in the header, hdr->chunks to indicate the number of chunks in the payload) that wasn't confirmed.

On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: >> Hi Michael, could you please give some feedback? > I'm sorry, I'm not sure feedback on what you are requesting. Oh, just some trivial things (e.g. use a field in the header, hdr->chunks to indicate the number of chunks in the payload) that wasn't confirmed.

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler function to get the free page block. v7->v8: 1) Use only one chunk format, instead of two. 2) re-write the virtio-balloon implementation patch. 3) commit changes 4) patch re-org Liang Li (1):...

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler function to get the free page block. v7->v8: 1) Use only one chunk format, instead of two. 2) re-write the virtio-balloon implementation patch. 3) commit changes 4) patch re-org Liang Li (1):...

On 05/06/2017 06:26 AM, Michael S. Tsirkin wrote: > On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: > > On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > > > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: > > > > Hi Michael, could you please give some feedback? > > > I'm sorry, I'm not sure feedback on what you are

On 05/06/2017 06:26 AM, Michael S. Tsirkin wrote: > On Thu, Apr 27, 2017 at 02:31:49PM +0800, Wei Wang wrote: > > On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote: > > > On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote: > > > > Hi Michael, could you please give some feedback? > > > I'm sorry, I'm not sure feedback on what you are

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned pages are tr...

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned pages are tr...

...orresponds to pfn-0x1000 (i.e. pfn_start) Then the chunk base = 0x1004 (one is the position of the "Set" bit, which is 4), so pfn_start +one=0x1004 >> +static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq) >> +{ >> + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_BALLOON_CHUNKS)) { >> + int pfns, page_bmaps, i; >> + unsigned long pfn_start, pfns_len; >> + >> + pfn_start = vb->pfn_start; >> + pfns = vb->pfn_stop - pfn_start + 1; >> + pfns = roundup(roundup(pfns, BITS_PER_LONG), >> + PFNS_PER_PAGE_BMAP); >&gt...

On 04/15/2017 05:38 AM, Michael S. Tsirkin wrote: > On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: >> On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: >>> On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: >>> >>> So we don't need the bitmap to talk to host, it is just >>> a data structure we chose to maintain lists of pages,

Hi Michael, could you please give some feedback? On Monday, April 17, 2017 11:35 AM, Wei Wang wrote: > On 04/15/2017 05:38 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: > >> On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: > >>> On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > >>> > >>>

Hi Michael, could you please give some feedback? On Monday, April 17, 2017 11:35 AM, Wei Wang wrote: > On 04/15/2017 05:38 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: > >> On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: > >>> On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > >>> > >>>

...izeof(struct virtio_balloon_miscq_hdr) + + sizeof(struct virtio_balloon_page_chunk_hdr); + } +} + static int virtballoon_probe(struct virtio_device *vdev) { struct virtio_balloon *vb; @@ -869,6 +1046,9 @@ static int virtballoon_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_BALLOON_CHUNKS)) balloon_page_chunk_init(vb); + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_MISC_VQ)) + miscq_init(vb); + mutex_init(&vb->balloon_lock); init_waitqueue_head(&vb->acked); vb->vdev = vdev; @@ -946,6 +1126,8 @@ static void virtballoon_remove(struct virtio_device *vdev)...

...fn_start) > Then the chunk base = 0x1004 > (one is the position of the "Set" bit, which is 4), so pfn_start +one=0x1004 > > > > +static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq) > > > +{ > > > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_BALLOON_CHUNKS)) { > > > + int pfns, page_bmaps, i; > > > + unsigned long pfn_start, pfns_len; > > > + > > > + pfn_start = vb->pfn_start; > > > + pfns = vb->pfn_stop - pfn_start + 1; > > > + pfns = roundup(roundup(pfns, BITS_PER_LONG), > > &g...

...fn_start) > Then the chunk base = 0x1004 > (one is the position of the "Set" bit, which is 4), so pfn_start +one=0x1004 > > > > +static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq) > > > +{ > > > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_BALLOON_CHUNKS)) { > > > + int pfns, page_bmaps, i; > > > + unsigned long pfn_start, pfns_len; > > > + > > > + pfn_start = vb->pfn_start; > > > + pfns = vb->pfn_stop - pfn_start + 1; > > > + pfns = roundup(roundup(pfns, BITS_PER_LONG), > > &g...

...+ sizeof(struct virtio_balloon_page_chunk_hdr); > + } > +} > + > static int virtballoon_probe(struct virtio_device *vdev) > { > struct virtio_balloon *vb; > @@ -869,6 +1046,9 @@ static int virtballoon_probe(struct virtio_device *vdev) > if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_BALLOON_CHUNKS)) > balloon_page_chunk_init(vb); > > + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_MISC_VQ)) > + miscq_init(vb); > + > mutex_init(&vb->balloon_lock); > init_waitqueue_head(&vb->acked); > vb->vdev = vdev; > @@ -946,6 +1126,8 @@ static void v...