search for: virtgpu_hw_h

...(+) > create mode 100644 include/hw/virtio/virtgpu_hw.h > > diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h > new file mode 100644 > index 0000000..461f452 > --- /dev/null > +++ b/include/hw/virtio/virtgpu_hw.h > @@ -0,0 +1,158 @@ > +#ifndef VIRTGPU_HW_H > +#define VIRTGPU_HW_H Non-trivial file, deserves a copyright and license notice. > + > +enum virtgpu_ctrl_type { > + VIRTGPU_UNDEFINED = 0, > + > + /* 2d commands */ > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, Please consider also adding: #define VIRTG...

...(+) > create mode 100644 include/hw/virtio/virtgpu_hw.h > > diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h > new file mode 100644 > index 0000000..461f452 > --- /dev/null > +++ b/include/hw/virtio/virtgpu_hw.h > @@ -0,0 +1,158 @@ > +#ifndef VIRTGPU_HW_H > +#define VIRTGPU_HW_H Non-trivial file, deserves a copyright and license notice. > + > +enum virtgpu_ctrl_type { > + VIRTGPU_UNDEFINED = 0, > + > + /* 2d commands */ > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, Please consider also adding: #define VIRTG...

Hi folks, Lets kick off the virtio-gpu review process, starting with the virtio protocol. This is a tiny patch series for qemu. Patch #1 carries the header file describing the virtual hardware: config space, command structs being sent over the rings, defines etc. Patch #2 adds a text file describing virtio-gpu to docs/specs/. It covers 2D support only for now. For anybody who wants to dig a

Hi folks, Lets kick off the virtio-gpu review process, starting with the virtio protocol. This is a tiny patch series for qemu. Patch #1 carries the header file describing the virtual hardware: config space, command structs being sent over the rings, defines etc. Patch #2 adds a text file describing virtio-gpu to docs/specs/. It covers 2D support only for now. For anybody who wants to dig a

...s(+) > create mode 100644 include/hw/virtio/virtgpu_hw.h > > diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h > new file mode 100644 > index 0000000..461f452 > --- /dev/null > +++ b/include/hw/virtio/virtgpu_hw.h > @@ -0,0 +1,158 @@ > +#ifndef VIRTGPU_HW_H > +#define VIRTGPU_HW_H > + > +enum virtgpu_ctrl_type { > + VIRTGPU_UNDEFINED = 0, > This is clearly all well out of line with our coding style guide, which isn't a terribly good start... thanks -- PMM

Hi, > > @@ -0,0 +1,158 @@ > > +#ifndef VIRTGPU_HW_H > > +#define VIRTGPU_HW_H > > Non-trivial file, deserves a copyright and license notice. Added. > > + > > +enum virtgpu_ctrl_type { > > + VIRTGPU_UNDEFINED = 0, > > + > > + /* 2d commands */ > > + VIRTGPU_CMD_GET_DISPLAY_INFO =...

...s(+) > create mode 100644 include/hw/virtio/virtgpu_hw.h > > diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h > new file mode 100644 > index 0000000..461f452 > --- /dev/null > +++ b/include/hw/virtio/virtgpu_hw.h > @@ -0,0 +1,158 @@ > +#ifndef VIRTGPU_HW_H > +#define VIRTGPU_HW_H > + > +enum virtgpu_ctrl_type { > + VIRTGPU_UNDEFINED = 0, > This is clearly all well out of line with our coding style guide, which isn't a terribly good start... thanks -- PMM

...+++++++++++++ 1 file changed, 158 insertions(+) create mode 100644 include/hw/virtio/virtgpu_hw.h diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h new file mode 100644 index 0000000..461f452 --- /dev/null +++ b/include/hw/virtio/virtgpu_hw.h @@ -0,0 +1,158 @@ +#ifndef VIRTGPU_HW_H +#define VIRTGPU_HW_H + +enum virtgpu_ctrl_type { + VIRTGPU_UNDEFINED = 0, + + /* 2d commands */ + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, + VIRTGPU_CMD_RESOURCE_CREATE_2D, + VIRTGPU_CMD_RESOURCE_UNREF, + VIRTGPU_CMD_SET_SCANOUT, + VIRTGPU_CMD_RESOURC...

On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, which are 3-clause BSD, prefixed with this reminder: This header is BSD licensed so anyone can use...

On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, which are 3-clause BSD, prefixed with this reminder: This header is BSD licensed so anyone can use...