search for: vfree

...d test robot <lkp at intel.com> All error/warnings (new ones prefixed by >>): drivers/remoteproc/remoteproc_sysfs.c: In function 'firmware_store': >> drivers/remoteproc/remoteproc_sysfs.c:55:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] kfree(rproc->firmware); ^~~~~ vfree cc1: some warnings being treated as errors -- drivers/char/hw_random/virtio-rng.c: In function 'probe_common': >> drivers/char/hw_random/virtio-rng.c:92:7: error: implicit declara...

...it was fine - the thing is it can't have been a bad rule as the first thing the server does is load the firewall (same) rules.. In /var/log/messages I can see:- -------------------------------------------------------------------------------------------- Oct 13 09:27:46 new kernel: Trying to vfree() nonexistent vm area (ffffffff885d9000) Oct 13 09:27:46 new kernel: WARNING: at mm/vmalloc.c:329 __vunmap() Oct 13 09:27:46 new kernel: Oct 13 09:27:46 new kernel: Call Trace: Oct 13 09:27:46 new kernel: [<ffffffff800a8b6b>] sys_delete_module+0x1b3/0x1d4 Oct 13 09:27:46 new kernel: [<ff...

...later on after this one is merged. > > > > > > To this larger audience and last week without reply: > > > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel at perches.com/ > > > > > > Are there _any_ fastpath uses of kfree or vfree? > > > > I'd consider kfree performance critical for cases where it is called > > under locks. If possible the kfree is moved outside of the critical > > section, but we have rbtrees or lists that get deleted under locks and > > restructuring the code to do eg. sp...

...later on after this one is merged. > > > > > > To this larger audience and last week without reply: > > > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel at perches.com/ > > > > > > Are there _any_ fastpath uses of kfree or vfree? > > > > I'd consider kfree performance critical for cases where it is called > > under locks. If possible the kfree is moved outside of the critical > > section, but we have rbtrees or lists that get deleted under locks and > > restructuring the code to do eg. sp...

...<linux/string.h> #include <linux/slab.h> +#include <linux/vmalloc.h> #include <linux/init.h> #include <linux/blkdev.h> #include <linux/parser.h> @@ -145,7 +146,7 @@ kfree(sbi->s_debts); brelse (sbi->s_sbh); sb->s_fs_info = NULL; - kfree(sbi); + vfree(sbi); return; } @@ -571,7 +572,7 @@ int db_count; int i, j; - sbi = kmalloc(sizeof(*sbi), GFP_KERNEL); + sbi = vmalloc(sizeof(*sbi)); if (!sbi) return -ENOMEM; sb->s_fs_info = sbi; diff -Nru a/fs/ext3/super.c b/fs/ext3/super.c --- a/fs/ext3/super.c Tue Nov 4 07:19:37 2003 +++...

...m integer without a cast [-Wint-conversion] > >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > >>> ^ > >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > >>> kfree(vm); > >>> ^~~~~ > >>> vfree > >>> cc1: some warnings being treated as errors > >>> > >>> vim +1375 drivers/virtio/virtio_mem.c > >> > >...

...m integer without a cast [-Wint-conversion] > >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > >>> ^ > >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > >>> kfree(vm); > >>> ^~~~~ > >>> vfree > >>> cc1: some warnings being treated as errors > >>> > >>> vim +1375 drivers/virtio/virtio_mem.c > >> > >...

...gnment makes pointer from integer without a cast [-Wint-conversion] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > > ^ > >>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > > kfree(vm); > > ^~~~~ > > vfree > > cc1: some warnings being treated as errors > > > > vim +1375 drivers/virtio/virtio_mem.c > > Guess we simply need > > #include <linux/slab.h&...

...gnment makes pointer from integer without a cast [-Wint-conversion] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > > ^ > >>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > > kfree(vm); > > ^~~~~ > > vfree > > cc1: some warnings being treated as errors > > > > vim +1375 drivers/virtio/virtio_mem.c > > Guess we simply need > > #include <linux/slab.h&...

...ll be > > introduced as a separate patch later on after this one is merged. > > To this larger audience and last week without reply: > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel at perches.com/ > > Are there _any_ fastpath uses of kfree or vfree? I'd consider kfree performance critical for cases where it is called under locks. If possible the kfree is moved outside of the critical section, but we have rbtrees or lists that get deleted under locks and restructuring the code to do eg. splice and free it outside of the lock is not always...

...ll be > > introduced as a separate patch later on after this one is merged. > > To this larger audience and last week without reply: > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel at perches.com/ > > Are there _any_ fastpath uses of kfree or vfree? I'd consider kfree performance critical for cases where it is called under locks. If possible the kfree is moved outside of the critical section, but we have rbtrees or lists that get deleted under locks and restructuring the code to do eg. splice and free it outside of the lock is not always...

...el >> header files). >> >> Signed-off-by: Randy Dunlap <rdunlap at infradead.org> > > I threw it at a random selection of configs and so far the only failures > I'm seeing are: > > lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] > lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] > lib/test...

...el >> header files). >> >> Signed-off-by: Randy Dunlap <rdunlap at infradead.org> > > I threw it at a random selection of configs and so far the only failures > I'm seeing are: > > lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] > lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] > lib/test...

..._mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); ^ >> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] kfree(vm); ^~~~~ vfree cc1: some warnings being treated as errors vim +1375 drivers/virtio/virtio_mem.c 1369 1370 static int virtio_mem_probe(struct virtio_device *vdev) 1371 { 1372 struct virtio_mem *vm; 1373 int rc = -...

..._mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); ^ >> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] kfree(vm); ^~~~~ vfree cc1: some warnings being treated as errors vim +1375 drivers/virtio/virtio_mem.c 1369 1370 static int virtio_mem_probe(struct virtio_device *vdev) 1371 { 1372 struct virtio_mem *vm; 1373 int rc = -...

...); if (!vm->pgt) { kfree(vm); return -ENOMEM; @@ -371,7 +371,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, ret = nouveau_mm_init(&vm->mm, mm_offset >> 12, mm_length >> 12, block >> 12); if (ret) { - kfree(vm->pgt); + vfree(vm->pgt); kfree(vm); return ret; } @@ -446,7 +446,7 @@ nouveau_vm_del(struct nouveau_vm *vm) } nouveau_mm_fini(&vm->mm); - kfree(vm->pgt); + vfree(vm->pgt); kfree(vm); } -- 1.8.1.4

On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > > Not just performance critical, but correctness critical. Since kvfree() > > > may allocate from the vmalloc allocator, I really think that kvfree() > > > should assert that it's !in_atomic(). Otherwise we can get into trouble > > > if we end up calling vfree() and have to take the mutex. > > > > FWIW __vfree already checks...

On Wed 17-06-20 04:08:20, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 09:12:12AM +0200, Michal Hocko wrote: > > On Tue 16-06-20 17:37:11, Matthew Wilcox wrote: > > > Not just performance critical, but correctness critical. Since kvfree() > > > may allocate from the vmalloc allocator, I really think that kvfree() > > > should assert that it's !in_atomic(). Otherwise we can get into trouble > > > if we end up calling vfree() and have to take the mutex. > > > > FWIW __vfree already checks...

...[-Wint-conversion] > >>>>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > >>>>> ^ > >>>>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > >>>>> kfree(vm); > >>>>> ^~~~~ > >>>>> vfree > >>>>> cc1: some warnings being treated as errors > >>>>> > >>>>> vim +1375 dri...

...cussion on what is best. It will be > introduced as a separate patch later on after this one is merged. To this larger audience and last week without reply: https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel at perches.com/ Are there _any_ fastpath uses of kfree or vfree? Many patches have been posted recently to fix mispairings of specific types of alloc and free functions. To eliminate these mispairings at a runtime cost of four comparisons, should the kfree/vfree/kvfree/kfree_const functions be consolidated into a single kfree? Something like the below: v...