Displaying 20 results from an estimated 69 matches for "use_napi".
2018 Dec 06
7
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> When use_napi is set, let's enable BQLs. Note: some of the issues are
> similar to wifi. It's worth considering whether something similar to
> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> benefitial.
I've played a similar patch several days before. The t...
2018 Dec 06
7
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> When use_napi is set, let's enable BQLs. Note: some of the issues are
> similar to wifi. It's worth considering whether something similar to
> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> benefitial.
I've played a similar patch several days before. The t...
2018 Dec 05
3
[PATCH RFC 0/2] virtio-net: interrupt related improvements
Now that we have brought the virtio overhead way down with a fast packed
ring implementation, we seem to be actually observing TCP drops
indicative of bufferbloat. So let's try to enable TSQ. Note: it isn't
clear that the default pacing is great for the virt usecase. It's worth
trying to play with sk_pacing_shift_update to see what happens.
For this reason, and for a more important
2018 Dec 27
2
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>> similar to wifi. It's worth considering whether something similar to
>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>> benefitial.
>>
>> I've played a...
2018 Dec 27
2
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>> similar to wifi. It's worth considering whether something similar to
>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>> benefitial.
>>
>> I've played a...
2018 Dec 27
2
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/26 ??11:22, Michael S. Tsirkin wrote:
> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>> similar to wifi. It's worth considering whether something similar to
>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>> benefitial.
>>
>> I've played a...
2018 Dec 27
2
[PATCH RFC 1/2] virtio-net: bql support
On 2018/12/26 ??11:22, Michael S. Tsirkin wrote:
> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>> similar to wifi. It's worth considering whether something similar to
>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>> benefitial.
>>
>> I've played a...
2018 Dec 05
0
[PATCH RFC 1/2] virtio-net: bql support
When use_napi is set, let's enable BQLs. Note: some of the issues are
similar to wifi. It's worth considering whether something similar to
commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
benefitial.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/n...
2019 Jan 02
2
[PATCH RFC 1/2] virtio-net: bql support
...sirkin wrote:
> On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
>> On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
>>> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>>>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>>>> similar to wifi. It's worth considering whether something similar to
>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>>>> benefitial.
>>>...
2019 Jan 02
2
[PATCH RFC 1/2] virtio-net: bql support
...sirkin wrote:
> On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
>> On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
>>> On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>>>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are
>>>>> similar to wifi. It's worth considering whether something similar to
>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
>>>>> benefitial.
>>>...
2018 Dec 26
0
[PATCH RFC 1/2] virtio-net: bql support
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>
> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > similar to wifi. It's worth considering whether something similar to
> > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > benefitial.
>
>
> I've played a similar pa...
2018 Dec 26
0
[PATCH RFC 1/2] virtio-net: bql support
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>
> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > similar to wifi. It's worth considering whether something similar to
> > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > benefitial.
>
>
> I've played a similar pa...
2018 Dec 26
0
[PATCH RFC 1/2] virtio-net: bql support
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
>
> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > similar to wifi. It's worth considering whether something similar to
> > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > benefitial.
>
>
> I've played a similar pa...
2018 Dec 30
0
[PATCH RFC 1/2] virtio-net: bql support
On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote:
>
> On 2018/12/26 ??11:22, Michael S. Tsirkin wrote:
> > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
> > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > > > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > > > similar to wifi. It's worth considering whether something similar to
> > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > > > benefitial.
> > >...
2018 Dec 30
0
[PATCH RFC 1/2] virtio-net: bql support
On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
>
> On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
> > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
> > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > > > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > > > similar to wifi. It's worth considering whether something similar to
> > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > > > benefitial.
> > >...
2019 Jan 02
0
[PATCH RFC 1/2] virtio-net: bql support
...27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
> > > On 2018/12/26 ??11:19, Michael S. Tsirkin wrote:
> > > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
> > > > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote:
> > > > > > When use_napi is set, let's enable BQLs. Note: some of the issues are
> > > > > > similar to wifi. It's worth considering whether something similar to
> > > > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
> > > > > &g...
2017 Apr 18
1
[PATCH net-next v2 5/5] virtio-net: keep tx interrupts disabled unless kick
...sertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index b14c82ce0032..b107ae011632 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1196,8 +1196,14 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
bool use_napi = sq->napi.weight;
/* Free up any pending old buffers before queueing new ones. */
- if (!use_napi)
+ if (use_napi) {
+ if (kick)
+ virtqueue_enable_cb_delayed(sq->vq);
+ else
+ virtqueue_disable_cb(sq->vq);
+ } else {
free_old_xmit_skbs(sq);
+ }
/* timestamp packet in sof...
2017 Apr 20
1
[PATCH net-next v2 5/5] virtio-net: keep tx interrupts disabled unless kick
>> - if (!use_napi)
>> + if (use_napi) {
>> + if (kick)
>> + virtqueue_enable_cb_delayed(sq->vq);
>> + else
>> + virtqueue_disable_cb(sq->vq);
>
>
> Since virtqueue_disable_cb() do nothing for ev...
2017 Apr 20
1
[PATCH net-next v2 5/5] virtio-net: keep tx interrupts disabled unless kick
>> - if (!use_napi)
>> + if (use_napi) {
>> + if (kick)
>> + virtqueue_enable_cb_delayed(sq->vq);
>> + else
>> + virtqueue_disable_cb(sq->vq);
>
>
> Since virtqueue_disable_cb() do nothing for ev...
2017 Apr 20
1
[PATCH net-next v2 2/5] virtio-net: transmit napi
...xbuf *hdr;
>> @@ -1130,9 +1172,11 @@ static netdev_tx_t start_xmit(struct sk_buff *skb,
>> struct net_device *dev)
>> int err;
>> struct netdev_queue *txq = netdev_get_tx_queue(dev, qnum);
>> bool kick = !skb->xmit_more;
>> + bool use_napi = sq->napi.weight;
>> /* Free up any pending old buffers before queueing new ones. */
>> - free_old_xmit_skbs(sq);
>> + if (!use_napi)
>> + free_old_xmit_skbs(sq);
>
>
> I'm not sure this is best or even correct. Consider we...