search for: unretir

...cmd->cb.callback) > + cmd->cb.callback (LIBNBD_CALLBACK_FREE, cmd->cb.user_data, > + 0, NULL); > + > free (cmd); nbd_aio_command_completed is skipped when a user calls nbd_close. While we've documented that nbd_close loses the exit status of any unretired command (different from the fact that completion callbacks run on transition to DEAD but the handle is still around), it is still probably worth tweaking nbd_close's use of free_cmd_list() to still call FREE on any pending callbacks on commands stranded by abrupt close to allow the user to st...

...of special casing in nbd_aio_[peek_]command_completed. Note that although this is not an API change, it does change ABI, but that's okay as we have not declared a stable interface yet. Update a couple of the tests and examples to give this coverage: examples/glib-main-loop no longer piles up unretired commands, and tests/server-death shows that even a command stranded by server death can still be auto-retired. --- This probably will conflict with Rich's work to improve callbacks to make it easier to free data on the last use of a callback. examples/glib-main-loop.c | 6 +++-- generator...

...completion_cb, NULL, 0); > + nbd_close (nbd); > + > + assert (read_cb_free == 1); > + assert (completion_cb_free == 1); Worth asserting that read_cb_valid and completion_cb_valid are 0 (if we are confident in our ability to strand the command unretired due to use of a filter delay)? > + > + exit (EXIT_SUCCESS); > +} > diff --git a/tests/meta-base-allocation.c b/tests/meta-base-allocation.c > index 95e029b..9e88d6b 100644 > --- a/tests/meta-base-allocation.c Most of my comments can be addressed by followups or pertain to the...

I think I've addressed everything that was raised in review. Some of the highlights: - Callbacks should be freed reliably along all exit paths. - There's a simple test of closure lifetimes. - I've tried to use VALID|FREE in all the places where I'm confident that it's safe and correct to do. There may be more places. Note this is an optimization and shouldn't

v1 was here: https://www.redhat.com/archives/libguestfs/2019-July/thread.html#00231 The changes address everything that Eric picked up in his review of the first two patches. I have also added two more patches (4 and 5) which respectively fix docs and change int status -> unsigned status, as discussed. Passes make, check, check-valgrind. Rich.