search for: unchanged_file

Hi, below you find a patch fixing a bug in the file comparison code: The current code skips the unchanged_file() check when that check succeeded for an earlier candidate, which could lead to accepting a file with a different checksum as unchanged, for example. Please be aware that the patch is untested. Florian diff --git a/generator.c b/generator.c index a112da6..2df1b28 100644 --- a/generator.c +++ b/g...

https://bugzilla.samba.org/show_bug.cgi?id=5644 Summary: Option to recheck basis dirs for existing dest files Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy:

...le | grep Mod If the diff shows a difference, then the rsync didn't copy afile's contents over. However, note the stat info from the last two lines - the updated modify timestamp *will* be synced, making an inconsistent sync. The following patch adds a check of the high-res timestamp to unchanged_file. This solves the problem for me, and I've guarded it so it shouldn't break on systems with no high-res timestamp. Please let me know if I can be helpful in testing it further or making it more robust. diff --git a/generator.c b/generator.c index 3a4504f..2f64f5d 100644 --- a/generator.c...

I am looking at rsync 2.6.6 When I try to rsync a directory using --link-dest it never creates hardlinks. After crashing my way through the code here is what I found: generator.c: function 'unchanged_file' if (ignore_times) return 0; return cmp_modtime(st->st_mtime, file->modtime) == 0; shouldn't these lines be: if (ignore_times) return 1; return cmp_modtime(st->st_mtime, file->modtime) >= 0; Or do I not understand something... Nathan Bullo...

I noticed that rsync is happy to hard-link a device node from a --link-dest dir even if its mtime differs from that of the source device node and --times is given. Is this behavior expected? It seems to break the rule that a difference in preserved attributes disqualifies a hard link. To see the behavior, run the following as root: mkdir src dest basis mknod src/null c 1 3 sleep 1 mknod

https://bugzilla.samba.org/show_bug.cgi?id=12036 Bug ID: 12036 Summary: Multiple --link-dest, --copy-dest, or --compare-dest flags produce incorrect behavior Product: rsync Version: 3.1.2 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 Component:

...ion 3.1.0. (At our site, we use a patched version of rsync which links a file from the link-dest directory rather copying from source when a file is identical in the source and link-dest directory, but exists and is different in the destination.) I was not aware of the issue in the case where the unchanged_file() test is passed, but not the unchanged_attrs() test, and the potential for over-writing the attributes in not just the destination, but for all hard-linked files. This means that recycling directories, which as Teodor Milkov noted: > "Such a behaviour (unlink changed files and then hard...

...create a new copy of the file and attrs # from the source, but could copy the file in the destination # and update attrs, and remove the old file else # current behaviour update just the attributes endif endif Or, in the terms used in previous posts: if ( destination unchanged_file() is true and unchanged_attrs() is false) .... The test on the link-count is done, since teh new behaviour is needed only when the target file has a link-count greater than 1. Regards Rob. Bell e-mail: Robert.Bell at csiro.au -- Dr Robert C. Bell, BSc (Hons) PhD Technical Services...

...if ((iflags & ITEM_REPORT_CHANGE) && code != FNONE && verbose) rprintf(code, "%s\n", fname); #ifdef SUPPORT_HARD_LINKS if (preserve_hard_links && F_IS_HLINKED(file)) @@ -1776,13 +1800,31 @@ else if (fnamecmp_type == FNAMECMP_FUZZY) ; else if (unchanged_file(fnamecmp, file, &sx.st)) { + /* fnamecmp == fname, fnamecmp_type == FNAMECMP_FNAME */ + int iflags = 0; + if (partialptr) { do_unlink(partialptr); handle_partial_dir(partialptr, PDIR_DELETE); } - set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT); + if (inplace) {...