search for: ttm_agp_tt_create

https://bugs.freedesktop.org/show_bug.cgi?id=53402 Bug #: 53402 Summary: nouveau_bo.c:463:3: error: implicit declaration of function 'ttm_agp_tt_create' Classification: Unclassified Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at l...

...@@ static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, > struct radeon_ttm_tt *gtt; > > rdev = radeon_get_rdev(bo->bdev); > -#if IS_ENABLED(CONFIG_AGP) > +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) > if (rdev->flags & RADEON_IS_AGP) { > return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, > page_flags); > @@ -683,7 +683,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm, > } > > rdev = radeon_get_rdev(ttm->bdev); > -#if IS_ENABLED(CONFIG_AGP) > +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) > if (rdev->fl...

...t;< PAGE_SHIFT; @@ -631,7 +631,7 @@ static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, struct radeon_ttm_tt *gtt; rdev = radeon_get_rdev(bo->bdev); -#if IS_ENABLED(CONFIG_AGP) +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) if (rdev->flags & RADEON_IS_AGP) { return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, page_flags); @@ -683,7 +683,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm, } rdev = radeon_get_rdev(ttm->bdev); -#if IS_ENABLED(CONFIG_AGP) +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) if (rdev->flags & RADEON_IS_AGP) { return ttm...

Hi guys, Well let's face it AGP is a total headache to maintain and dead for at least 10+ years. We have a lot of x86 specific stuff in the architecture independent graphics memory management to get the caching right, abusing the DMA API on multiple occasions, need to distinct between AGP and driver specific page tables etc etc... So the idea here is to just go ahead and remove the support

Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in functionality since drivers will just fallback to the driver specific PCI GART. For now just deprecate the code and don't enable the AGP GART in TTM even when general AGP support is available. Please comment, Christian.

v2 was doing some pretty nasty things with the DMA API, so I took a different approach for this v3. As suggested, this version uses ttm_dma_populate() to populate BOs. The reason for doing this was that it would entitle us to using the DMA sync functions, but since the memory returned is already coherent anyway, we do not even need to call these functions anymore. So this series has turned into

https://bugs.freedesktop.org/show_bug.cgi?id=81485 Priority: medium Bug ID: 81485 Assignee: nouveau at lists.freedesktop.org Summary: dmesg spam on startup QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: fry.kun at gmail.com Hardware: Other

...t;< PAGE_SHIFT; > @@ -631,12 +609,6 @@ static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, > struct radeon_ttm_tt *gtt; > > rdev = radeon_get_rdev(bo->bdev); > -#if IS_ENABLED(CONFIG_AGP) > - if (rdev->flags & RADEON_IS_AGP) { > - return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, > - page_flags); > - } > -#endif > > gtt = kzalloc(sizeof(struct radeon_ttm_tt), GFP_KERNEL); > if (gtt == NULL) { > @@ -683,11 +655,6 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm, > } > > rdev = radeon_...

...m->bus.offset = mem->start << PAGE_SHIFT; @@ -631,12 +609,6 @@ static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, struct radeon_ttm_tt *gtt; rdev = radeon_get_rdev(bo->bdev); -#if IS_ENABLED(CONFIG_AGP) - if (rdev->flags & RADEON_IS_AGP) { - return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, - page_flags); - } -#endif gtt = kzalloc(sizeof(struct radeon_ttm_tt), GFP_KERNEL); if (gtt == NULL) { @@ -683,11 +655,6 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm, } rdev = radeon_get_rdev(ttm->bdev); -#if IS_ENABLED(CONFIG_AGP...

...31,12 +609,6 @@ static struct ttm_tt *radeon_ttm_tt_create(struct ttm_buffer_object *bo, > struct radeon_ttm_tt *gtt; > > rdev = radeon_get_rdev(bo->bdev); > -#if IS_ENABLED(CONFIG_AGP) > - if (rdev->flags & RADEON_IS_AGP) { > - return ttm_agp_tt_create(bo, rdev->ddev->agp->bridge, > - page_flags); > - } > -#endif > > gtt = kzalloc(sizeof(struct radeon_ttm_tt), GFP_KERNEL); > if (gtt == NULL) { > @@ -683,11 +655,6 @@ static int radeon_ttm_tt_populate(struct...