Nouveau - Aug 2012 - [Bug 53402] New: nouveau_bo.c:463:3: error: implicit declaration of function 'ttm_agp_tt_create'

https://bugs.freedesktop.org/show_bug.cgi?id=53402

             Bug #: 53402
           Summary: nouveau_bo.c:463:3: error: implicit declaration of
                    function 'ttm_agp_tt_create'
    Classification: Unclassified
           Product: xorg
           Version: git
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: ronald645 at gmail.com
         QAContact: xorg-team at lists.x.org


Hello nouveau developers and community,
I'm having issue's compiling latest HEAD (as of right now): 088fba1c7c7

CC drivers/gpu/drm/nouveau/nouveau_bo.o
drivers/gpu/drm/nouveau/nouveau_bo.c: In function
'nouveau_ttm_tt_create':
drivers/gpu/drm/nouveau/nouveau_bo.c:463:3: error: implicit declaration of
function 'ttm_agp_tt_create'
drivers/gpu/drm/nouveau/nouveau_bo.c:463:3: attention: return makes pointer
from integer without a cast

$ cat .config | grep NOUVEAU
CONFIG_DRM_NOUVEAU=y
CONFIG_NOUVEAU_DEBUG=5
CONFIG_NOUVEAU_DEBUG_DEFAULT=3
CONFIG_DRM_NOUVEAU_BACKLIGHT=y
I have posted my full .config @ http://pastebin.com/YuHnMnH4

Reverting commit d5ef81 (drm/nouveau: port remainder of drm code, and rip out
compat layer) makes compilation go past this point. However, it crashes later
because other bits and pieces rely on this specific commit.

Using Gentoo Hardened with GCC:

gebruiker at Charlie ~ $ gcc -v 
Builtin specs are being used.
COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/4.5.3/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.5.3/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-4.5.3-r2/work/gcc-4.5.3/configure --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/4.5.3
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.5.3
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.5.3/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.5.3/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/include/g++-v4
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --disable-altivec
--disable-fixed-point --with-ppl --with-cloog --disable-ppl-version-check
--with-cloog-include=/usr/include/cloog-ppl --disable-lto --enable-nls
--without-included-gettext --with-system-zlib --disable-werror
--enable-secureplt --enable-multilib --enable-libmudflap --disable-libssp
--enable-esp --disable-libgomp
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/4.5.3/python
--enable-checking=release --disable-libgcj --enable-languages=c,c++
--enable-shared --enable-threads=posix --enable-__cxa_atexit
--enable-clocale=gnu --enable-targets=all --with-bugurl=http://bugs.gentoo.org/
--with-pkgversion='Gentoo Hardened 4.5.3-r2 p1.1, pie-0.4.7'
Thread model: posix
gcc version 4.5.3 (Gentoo Hardened 4.5.3-r2 p1.1, pie-0.4.7)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #1 from Ronald <ronald645 at gmail.com> 2012-08-15 19:23:04
UTC ---
No dice as of latest HEAD. Fails in the same frustrating way.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #2 from Ronald <ronald645 at gmail.com> 2012-08-21 20:15:33
UTC ---
No dice as of latest HEAD.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #3 from maximlevitsky at gmail.com 2012-08-22 05:17:51 UTC ---
I did send a patch to fix this issue. You need to put this call under
CONFIG_AGP.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #4 from Ronald <ronald645 at gmail.com> 2012-08-22 17:35:05
UTC ---
Thanks a lot, I will test with your patch applied.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #5 from Ronald <ronald645 at gmail.com> 2012-08-25 18:39:29
UTC ---
Created attachment 66112
  --> https://bugs.freedesktop.org/attachment.cgi?id=66112
Makes latest nouveau build with !CONFIG_AGP

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #6 from Ronald <ronald645 at gmail.com> 2012-08-25 18:39:57
UTC ---
Thanks again for your suggestion, build proceeds nice and dandy! I have
attached a patch for all the other souls who end up on this bug. Warning, I
have no idea if this is 100% correct.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

--- Comment #7 from Ronald <ronald645 at gmail.com> 2012-09-14 06:42:24
UTC ---
Any idea why your fix has not made it upstream yet?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=53402

Marcin Slusarz <marcin.slusarz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=df1b4b91e5dae04782f65f657d771b23ca3bdc99

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20121111/d28dfbd2/attachment.html>